Small docs clean up and remove unused ArrayStoreLibrary message.

Author: aardvark179

src/main/java/org/truffleruby/core/array/library/ArrayStoreLibrary.java

@@ -115,9 +115,6 @@ public Object initialStore(Object store) {
         return INITIAL_STORE;
     }
 
-    /** Return whether {@code store} and {@code other} share the same underlying array storage. */
-    public abstract boolean isSameStorage(Object store, Object other);
-
     /** Return the underlying storage used by this array, which may be behind multiple wrappers. Stores which wrap some
      * array store should always recursively unwrap that store using this same library call. */
     public Object backingStore(Object store) {
@@ -203,7 +200,8 @@ public void sort(Object store, int size) {
      * {@code newStore}. */
     public abstract ArrayAllocator generalizeForStore(Object store, Object newStore);
 
-    /** Return an allocator that can accept all the values of {@code store} and will propagate sharing. */
+    /** Return an allocator that can accept all the values of {@code store} and will share values stored in storage
+     * created by it. */
     public abstract ArrayAllocator generalizeForSharing(Object store);
 
     /** Return a new store of length {@code length} that can accept all the values of {@code store} and {@code newValue}

src/main/java/org/truffleruby/core/array/library/DelegatedArrayStorage.java

@@ -14,7 +14,6 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.TruffleSafepoint;
 import com.oracle.truffle.api.dsl.Cached;
-import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.profiles.LoopConditionProfile;
 import org.truffleruby.core.array.ArrayGuards;
 import org.truffleruby.core.array.library.ArrayStoreLibrary.ArrayAllocator;
@@ -25,7 +24,6 @@
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.GenerateUncached;
 import com.oracle.truffle.api.dsl.ImportStatic;
-import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.library.CachedLibrary;
 import com.oracle.truffle.api.library.ExportLibrary;
 import com.oracle.truffle.api.library.ExportMessage;
@@ -57,30 +55,6 @@ protected boolean isPrimitive(
         return stores.isPrimitive(storage);
     }
 
-    @ExportMessage
-    @ImportStatic(ArrayGuards.class)
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameDelegated(DelegatedArrayStorage store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "storageStrategyLimit()") ArrayStoreLibrary stores) {
-            return store.offset == other.offset && stores.isSameStorage(store.storage, other.storage);
-        }
-
-        @Specialization
-        protected static boolean sameShared(DelegatedArrayStorage store, SharedArrayStorage other,
-                @CachedLibrary(limit = "storageStrategyLimit()") ArrayStoreLibrary stores) {
-            return stores.isSameStorage(other.storage, store);
-        }
-
-        @Fallback
-        protected static boolean sameOther(DelegatedArrayStorage store, Object other,
-                @CachedLibrary(limit = "storageStrategyLimit()") ArrayStoreLibrary stores) {
-            return store.offset == 0 && stores.isSameStorage(store.storage, other);
-        }
-
-    }
-
     @ExportMessage
     public Object backingStore(
             @CachedLibrary(limit = "1") ArrayStoreLibrary stores) {

src/main/java/org/truffleruby/core/array/library/DoubleArrayStore.java

@@ -85,33 +85,6 @@ protected static boolean isPrimitive(double[] store) {
         return true;
     }
 
-    @ExportMessage
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameDoubleStore(double[] store, double[] other) {
-            return store == other;
-        }
-
-        @Specialization
-        protected static boolean sameDelegated(double[] store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Specialization
-        protected static boolean sameShared(double[] store, SharedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Fallback
-        protected static boolean sameShared(double[] store, Object other) {
-            return false;
-        }
-
-    }
-
     @ExportMessage
     protected static String toString(double[] store) {
         return "double[]";

src/main/java/org/truffleruby/core/array/library/IntegerArrayStore.java

@@ -85,33 +85,6 @@ protected static boolean isPrimitive(int[] store) {
         return true;
     }
 
-    @ExportMessage
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameIntegerStore(int[] store, int[] other) {
-            return store == other;
-        }
-
-        @Specialization
-        protected static boolean sameDelegated(int[] store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Specialization
-        protected static boolean sameShared(int[] store, SharedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Fallback
-        protected static boolean sameShared(int[] store, Object other) {
-            return false;
-        }
-
-    }
-
     @ExportMessage
     protected static String toString(int[] store) {
         return "int[]";

src/main/java/org/truffleruby/core/array/library/LongArrayStore.java

@@ -90,33 +90,6 @@ protected static boolean isPrimitive(long[] store) {
         return true;
     }
 
-    @ExportMessage
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameLongStore(long[] store, long[] other) {
-            return store == other;
-        }
-
-        @Specialization
-        protected static boolean sameDelegated(long[] store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Specialization
-        protected static boolean sameShared(long[] store, SharedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Fallback
-        protected static boolean sameShared(long[] store, Object other) {
-            return false;
-        }
-
-    }
-
     @ExportMessage
     protected static String toString(long[] store) {
         return "long[]";

src/main/java/org/truffleruby/core/array/library/NativeArrayStorage.java

@@ -31,7 +31,6 @@
 import org.truffleruby.language.objects.shared.WriteBarrierNode;
 
 import com.oracle.truffle.api.dsl.Cached;
-import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.dsl.Cached.Shared;
 import com.oracle.truffle.api.dsl.GenerateUncached;
@@ -83,33 +82,6 @@ protected boolean isNative() {
         return true;
     }
 
-    @ExportMessage
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameNativeStore(NativeArrayStorage store, NativeArrayStorage other) {
-            return store == other;
-        }
-
-        @Specialization
-        protected static boolean sameDelegated(NativeArrayStorage store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Specialization
-        protected static boolean sameShared(NativeArrayStorage store, SharedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Fallback
-        protected static boolean sameShared(NativeArrayStorage store, Object other) {
-            return false;
-        }
-
-    }
-
     @ExportMessage
     protected static String toString(NativeArrayStorage storage) {
         return "NativeArrayStorage";

src/main/java/org/truffleruby/core/array/library/ObjectArrayStore.java

@@ -15,7 +15,6 @@
 
 import com.oracle.truffle.api.TruffleSafepoint;
 import com.oracle.truffle.api.dsl.Cached;
-import com.oracle.truffle.api.dsl.Fallback;
 import com.oracle.truffle.api.dsl.Cached.Exclusive;
 import com.oracle.truffle.api.profiles.LoopConditionProfile;
 import org.truffleruby.core.array.ArrayGuards;
@@ -55,33 +54,6 @@ protected static boolean isMutable(Object[] store) {
         return true;
     }
 
-    @ExportMessage
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameObjectStore(Object[] store, Object[] other) {
-            return store == other;
-        }
-
-        @Specialization
-        protected static boolean sameDelegated(Object[] store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Specialization
-        protected static boolean sameShared(Object[] store, SharedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Fallback
-        protected static boolean sameShared(Object[] store, Object other) {
-            return false;
-        }
-
-    }
-
     @ExportMessage
     protected static String toString(Object[] store) {
         return "Object[]";

src/main/java/org/truffleruby/core/array/library/SharedArrayStorage.java

@@ -111,12 +111,6 @@ public Object initialStore() {
         return ArrayStoreLibrary.initialStorage(true);
     }
 
-    @ExportMessage
-    protected boolean isSameStorage(Object other,
-            @CachedLibrary(limit = "1") ArrayStoreLibrary stores) {
-        return stores.isSameStorage(storage, other);
-    }
-
     @ExportMessage
     public Object backingStore(
             @CachedLibrary(limit = "1") ArrayStoreLibrary stores) {

src/main/java/org/truffleruby/core/array/library/ZeroLengthArrayStore.java

@@ -45,33 +45,6 @@ protected boolean isPrimitive() {
         return true;
     }
 
-    @ExportMessage
-    static class IsSameStorage {
-
-        @Specialization
-        protected static boolean sameZeroLength(ZeroLengthArrayStore store, ZeroLengthArrayStore other) {
-            return true;
-        }
-
-        @Specialization
-        protected static boolean sameDelegated(ZeroLengthArrayStore store, DelegatedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Specialization
-        protected static boolean sameShared(ZeroLengthArrayStore store, SharedArrayStorage other,
-                @CachedLibrary(limit = "1") ArrayStoreLibrary others) {
-            return others.isSameStorage(other, store);
-        }
-
-        @Fallback
-        protected static boolean sameShared(ZeroLengthArrayStore store, Object other) {
-            return false;
-        }
-
-    }
-
     @ExportMessage
     protected static String toString(ZeroLengthArrayStore store) {
         return "empty";