Skip to content

Commit d1f8516

Browse files
committed
[GR-18163] jt lint: find_unused_primitives needs truffleruby to be built
PullRequest: truffleruby/3401
2 parents dcd78ca + f281820 commit d1f8516

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
- name: Install RuboCop
2727
run: gem install --no-document rubocop:0.66.0
2828
- run: jt lint
29-
- run: jt spotbugs
3029

3130
build:
3231
name: build jvm

ci.jsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ local part_definitions = {
368368
"pip:pylint": "==2.4.4",
369369
"shellcheck": "==0.6.0",
370370
},
371-
run+: jt(["lint"]) + jt(["spotbugs"]),
371+
run+: jt(["lint"]),
372372
},
373373

374374
test_mri: { run+: jt(["test", "mri", "--no-sulong"]) },

tool/jt.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2935,7 +2935,10 @@ def lint(*args)
29352935

29362936
check_source_files if ci?
29372937
check_heap_dump if ci?
2938+
2939+
build
29382940
run_ruby('tool/find_unused_primitives.rb')
2941+
spotbugs
29392942
end
29402943
end
29412944

@@ -2985,7 +2988,6 @@ def check_abi(fail: true)
29852988
`git diff --cached --name-only #{base_commit}`.lines.map(&:chomp)
29862989
end
29872990

2988-
# Separate from lint as it needs to build
29892991
def spotbugs
29902992
mx 'ruby_spotbugs'
29912993
end

0 commit comments

Comments
 (0)