Cleanups

Author: eregon

src/main/java/org/truffleruby/language/control/ExecuteAndReturnTrueNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2013, 2021 Oracle and/or its affiliates. All rights reserved. This
+ * Copyright (c) 2022, 2023 Oracle and/or its affiliates. All rights reserved. This
  * code is released under a tri EPL/GPL/LGPL license. You can use it,
  * redistribute it and/or modify it under the terms of the:
  *
@@ -15,6 +15,7 @@
 import com.oracle.truffle.api.frame.VirtualFrame;
 
 public final class ExecuteAndReturnTrueNode extends RubyContextSourceNode {
+
     @Child RubyNode child;
 
     public ExecuteAndReturnTrueNode(RubyNode child) {
@@ -23,7 +24,7 @@ public ExecuteAndReturnTrueNode(RubyNode child) {
 
     @Override
     public Object execute(VirtualFrame frame) {
-        child.execute(frame);
+        child.doExecuteVoid(frame);
         return true;
     }
 

src/main/java/org/truffleruby/parser/BodyTranslator.java

@@ -151,7 +151,6 @@
 import org.truffleruby.parser.ast.ArgsPushParseNode;
 import org.truffleruby.parser.ast.ArgumentParseNode;
 import org.truffleruby.parser.ast.ArrayParseNode;
-import org.truffleruby.parser.ast.ArrayPatternParseNode;
 import org.truffleruby.parser.ast.AssignableParseNode;
 import org.truffleruby.parser.ast.AttrAssignParseNode;
 import org.truffleruby.parser.ast.BackRefParseNode;
@@ -218,7 +217,6 @@
 import org.truffleruby.parser.ast.NextParseNode;
 import org.truffleruby.parser.ast.NilImplicitParseNode;
 import org.truffleruby.parser.ast.NilParseNode;
-import org.truffleruby.parser.ast.NilRestArgParseNode;
 import org.truffleruby.parser.ast.NthRefParseNode;
 import org.truffleruby.parser.ast.OpAsgnAndParseNode;
 import org.truffleruby.parser.ast.OpAsgnConstDeclParseNode;
@@ -305,7 +303,6 @@ public BodyTranslator(
     }
 
     private RubySymbol translateNameNodeToSymbol(ParseNode node) {
-
         if (node instanceof LiteralParseNode) {
             return language.getSymbol(((LiteralParseNode) node).getName());
         } else if (node instanceof SymbolParseNode) {
@@ -410,11 +407,6 @@ public RubyNode visitArrayNode(ArrayParseNode node) {
         return addNewlineIfNeeded(node, ret);
     }
 
-    @Override
-    public RubyNode visitArrayPatternNode(ArrayPatternParseNode node) {
-        throw CompilerDirectives.shouldNotReachHere("TODO"); // TODO
-    }
-
     @Override
     public RubyNode visitAttrAssignNode(AttrAssignParseNode node) {
         final CallParseNode callNode = new CallParseNode(
@@ -2210,10 +2202,6 @@ public RubyNode visitNilNode(NilParseNode node) {
         return addNewlineIfNeeded(node, ret);
     }
 
-    public RubyNode visitNilRestArgNode(NilRestArgParseNode node) {
-        throw CompilerDirectives.shouldNotReachHere("TODO"); // TODO
-    }
-
     @Override
     public RubyNode visitNthRefNode(NthRefParseNode node) {
         final SourceIndexLength sourceSection = node.getPosition();

src/main/java/org/truffleruby/parser/LoadArgumentsTranslator.java

@@ -15,7 +15,6 @@
 import java.util.Deque;
 import java.util.List;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.RubyLanguage;
 import org.truffleruby.core.IsNilNode;
 import org.truffleruby.core.array.ArrayIndexNodes;
@@ -51,7 +50,6 @@
 import org.truffleruby.parser.ast.LocalAsgnParseNode;
 import org.truffleruby.parser.ast.MultipleAsgnParseNode;
 import org.truffleruby.parser.ast.NilImplicitParseNode;
-import org.truffleruby.parser.ast.NilRestArgParseNode;
 import org.truffleruby.parser.ast.NoKeywordsArgParseNode;
 import org.truffleruby.parser.ast.OptArgParseNode;
 import org.truffleruby.parser.ast.ParseNode;
@@ -264,11 +262,6 @@ public RubyNode visitNoKeywordsArgNode(NoKeywordsArgParseNode node) {
         return new CheckNoKeywordArgumentsNode();
     }
 
-    @Override
-    public RubyNode visitNilRestArgNode(NilRestArgParseNode node) {
-        throw CompilerDirectives.shouldNotReachHere("TODO"); // TODO
-    }
-
     @Override
     public RubyNode visitKeywordArgNode(KeywordArgParseNode node) {
         final SourceIndexLength sourceSection = node.getPosition();

src/main/java/org/truffleruby/parser/ParameterCollector.java

@@ -12,7 +12,6 @@
 import java.util.ArrayList;
 import java.util.List;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import org.truffleruby.parser.ast.ArgsParseNode;
 import org.truffleruby.parser.ast.ArgumentParseNode;
 import org.truffleruby.parser.ast.ArrayParseNode;
@@ -24,7 +23,6 @@
 import org.truffleruby.parser.ast.ListParseNode;
 import org.truffleruby.parser.ast.LocalAsgnParseNode;
 import org.truffleruby.parser.ast.MultipleAsgnParseNode;
-import org.truffleruby.parser.ast.NilRestArgParseNode;
 import org.truffleruby.parser.ast.NoKeywordsArgParseNode;
 import org.truffleruby.parser.ast.OptArgParseNode;
 import org.truffleruby.parser.ast.ParseNode;
@@ -147,9 +145,4 @@ public Object visitNoKeywordsArgNode(NoKeywordsArgParseNode node) {
         return null;
     }
 
-    @Override
-    public Object visitNilRestArgNode(NilRestArgParseNode node) {
-        throw CompilerDirectives.shouldNotReachHere("TODO"); // TODO
-    }
-
 }