[GR-43903] Address new Truffle DSL warnings (idempotent and assumptions)

Author: eregon

src/main/java/org/truffleruby/core/binding/BindingNodes.java

@@ -17,6 +17,7 @@
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.dsl.GenerateNodeFactory;
 import com.oracle.truffle.api.dsl.GenerateUncached;
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.frame.FrameSlotKind;
 import com.oracle.truffle.api.strings.TruffleString;
@@ -155,7 +156,8 @@ public static boolean isHiddenVariable(Object name) {
         }
     }
 
-    private static boolean isHiddenVariable(String name) {
+    @Idempotent
+    static boolean isHiddenVariable(String name) {
         assert !name.isEmpty();
         final char first = name.charAt(0);
         return first == '$' || // Frame-local global variable

src/main/java/org/truffleruby/core/encoding/EncodingNodes.java

@@ -11,6 +11,7 @@
  */
 package org.truffleruby.core.encoding;
 
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.strings.AbstractTruffleString;
@@ -213,6 +214,7 @@ private TruffleString.GetByteCodeRangeNode getCodeRangeNode() {
         /** Indicates whether the encoding is one of the runtime-default encodings. Many (most?) applications do not
          * override the default encodings and as such, this set of encodings is used very frequently in real-world Ruby
          * applications. */
+        @Idempotent
         protected boolean isStandardEncoding(RubyEncoding encoding) {
             return encoding == Encodings.UTF_8 || encoding == Encodings.US_ASCII || encoding == Encodings.BINARY;
         }

src/main/java/org/truffleruby/core/numeric/IntegerNodes.java

@@ -15,6 +15,7 @@
 
 import com.oracle.truffle.api.dsl.Cached.Shared;
 import com.oracle.truffle.api.dsl.Fallback;
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.profiles.LoopConditionProfile;
 import com.oracle.truffle.api.strings.TruffleString;
 import org.truffleruby.annotations.CoreMethod;
@@ -515,6 +516,7 @@ protected int modPowerOfTwo(int a, int b,
             return a & (cachedB - 1);
         }
 
+        @Idempotent
         protected static boolean isPowerOfTwo(int n) {
             return n > 0 && (n & (n - 1)) == 0;
         }

src/main/java/org/truffleruby/language/RubyBaseNode.java

@@ -10,6 +10,7 @@
 package org.truffleruby.language;
 
 import com.oracle.truffle.api.CompilerAsserts;
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.ImportStatic;
 import com.oracle.truffle.api.dsl.TypeSystemReference;
 import com.oracle.truffle.api.nodes.EncapsulatingNodeReference;
@@ -50,6 +51,7 @@ public abstract class RubyBaseNode extends Node {
 
     public static final int MAX_EXPLODE_SIZE = 16;
 
+    @Idempotent
     public boolean isSingleContext() {
         return getLanguage().singleContext;
     }

src/main/java/org/truffleruby/language/RubyGuards.java

@@ -12,6 +12,7 @@
 import com.oracle.truffle.api.CompilerAsserts;
 import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.dsl.Cached;
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.NeverDefault;
 import com.oracle.truffle.api.strings.TruffleString;
 import org.truffleruby.core.CoreLibrary;
@@ -94,6 +95,7 @@ public static boolean isPrimitive(Object value) {
         return value instanceof Boolean || value instanceof Integer || value instanceof Long || value instanceof Double;
     }
 
+    @Idempotent
     public static boolean isPrimitiveClass(Class<?> clazz) {
         return clazz == Boolean.class || clazz == Integer.class || clazz == Long.class || clazz == Double.class;
     }
@@ -113,6 +115,7 @@ public static boolean isRubyArray(Object value) {
         return value instanceof RubyArray;
     }
 
+    @Idempotent
     public static boolean isRubyClass(Object value) {
         return value instanceof RubyClass;
     }

src/main/java/org/truffleruby/language/globals/GlobalVariableStorage.java

@@ -9,6 +9,7 @@
  */
 package org.truffleruby.language.globals;
 
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.NeverDefault;
 import org.truffleruby.RubyContext;
 import org.truffleruby.core.proc.RubyProc;
@@ -89,6 +90,7 @@ public Assumption getUnchangedAssumption() {
         return unchangedAssumption.getAssumption();
     }
 
+    @Idempotent
     public boolean isAssumeConstant() {
         return assumeConstant;
     }

src/main/java/org/truffleruby/language/globals/LookupGlobalVariableStorageNode.java

@@ -42,7 +42,7 @@ public final GlobalVariableStorage execute(Object dynamicArgument) {
     protected abstract GlobalVariableStorage executeInternal();
 
     @Specialization(
-            guards = "getLanguage().singleContext",
+            guards = "isSingleContext()",
             assumptions = "getLanguage().getGlobalVariableNeverAliasedAssumption(index)")
     protected GlobalVariableStorage singleContext(
             @Cached("getContext().getGlobalVariableStorage(index)") GlobalVariableStorage storage) {

src/main/java/org/truffleruby/language/globals/ReadSimpleGlobalVariableNode.java

@@ -38,7 +38,7 @@ public ReadSimpleGlobalVariableNode(String name) {
     public abstract Object execute();
 
     @Specialization(
-            guards = "getLanguage().singleContext",
+            guards = "isSingleContext()",
             assumptions = {
                     "storage.getUnchangedAssumption()",
                     "getLanguage().getGlobalVariableNeverAliasedAssumption(index)" })

src/main/java/org/truffleruby/language/globals/WriteSimpleGlobalVariableNode.java

@@ -36,7 +36,7 @@ public WriteSimpleGlobalVariableNode(String name) {
 
     @Specialization(
             guards = {
-                    "getLanguage().singleContext",
+                    "isSingleContext()",
                     "referenceEqualNode.executeReferenceEqual(value, previousValue)" },
             assumptions = {
                     "storage.getUnchangedAssumption()",
@@ -53,7 +53,7 @@ protected Object writeTryToKeepConstant(Object value,
     }
 
     @Specialization(
-            guards = { "getLanguage().singleContext", "storage.isAssumeConstant()" },
+            guards = { "isSingleContext()", "storage.isAssumeConstant()" },
             assumptions = {
                     "storage.getUnchangedAssumption()",
                     "getLanguage().getGlobalVariableNeverAliasedAssumption(index)" })

src/main/java/org/truffleruby/language/methods/CallForeignMethodNode.java

@@ -12,6 +12,7 @@
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
 import com.oracle.truffle.api.dsl.GenerateUncached;
+import com.oracle.truffle.api.dsl.Idempotent;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.interop.InteropException;
 import com.oracle.truffle.api.interop.InteropLibrary;
@@ -100,11 +101,13 @@ protected Object assignmentMethod(Object receiver, String name, Object[] args,
             }
         }
 
+        @Idempotent
         @TruffleBoundary
         protected static boolean isOperatorMethod(String name) {
             return !name.isEmpty() && !Character.isLetter(name.charAt(0));
         }
 
+        @Idempotent
         @TruffleBoundary
         protected static boolean isAssignmentMethod(String name) {
             return !name.isEmpty() && Character.isLetter(name.charAt(0)) && name.charAt(name.length() - 1) == '=';