Raise ArgumentError uncoditionally when Proc.new is called without a block

Author: andrykonchin

spec/tags/core/proc/new_tags.txt

@@ -1,5 +1 @@
 fails:Proc.new with an associated block raises a LocalJumpError when context of the block no longer exists
-fails:Proc.new without a block can be created if invoked from within a method with a block
-fails:Proc.new without a block can be created if invoked on a subclass from within a method with a block
-fails:Proc.new without a block can be create when called with no block
-fails:Proc.new without a block raises an ArgumentError when passed no block

src/main/java/org/truffleruby/core/proc/ProcNodes.java

@@ -31,19 +31,15 @@
 import org.truffleruby.core.symbol.SymbolNodes;
 import org.truffleruby.language.Nil;
 import org.truffleruby.language.Visibility;
-import org.truffleruby.language.WarnNode;
 import org.truffleruby.language.arguments.ArgumentDescriptorUtils;
-import org.truffleruby.language.arguments.ReadCallerFrameNode;
 import org.truffleruby.language.arguments.RubyArguments;
 import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.dispatch.DispatchNode;
-import org.truffleruby.language.locals.FindDeclarationVariableNodes.FindAndReadDeclarationVariableNode;
 import org.truffleruby.language.methods.Arity;
 import org.truffleruby.language.objects.AllocationTracing;
 import org.truffleruby.language.objects.LogicalClassNode;
 import org.truffleruby.language.yield.CallBlockNode;
 import org.truffleruby.parser.ArgumentDescriptor;
-import org.truffleruby.parser.TranslatorEnvironment;
 
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.dsl.Cached;
@@ -75,27 +71,8 @@ public static ProcNewNode create() {
         public abstract RubyProc executeProcNew(VirtualFrame frame, RubyClass procClass, Object[] args, Object block);
 
         @Specialization
-        protected RubyProc proc(VirtualFrame frame, RubyClass procClass, Object[] args, Nil block,
-                @Cached FindAndReadDeclarationVariableNode readNode,
-                @Cached ReadCallerFrameNode readCaller,
-                @Cached ProcNewNode recurseNode,
-                @Cached("new()") WarnNode warnNode) {
-            final MaterializedFrame parentFrame = readCaller.execute(frame);
-
-            Object parentBlock = readNode.execute(parentFrame, TranslatorEnvironment.METHOD_BLOCK_NAME, nil);
-
-            if (parentBlock == nil) {
-                throw new RaiseException(getContext(), coreExceptions().argumentErrorProcWithoutBlock(this));
-            } else {
-                if (warnNode.shouldWarnForDeprecation()) {
-                    warnNode.warningMessage(
-                            getContext().getCallStack().getTopMostUserSourceSection(),
-                            "Capturing the given block using Kernel#proc is deprecated; use `&block` instead");
-                }
-
-                final RubyProc proc = (RubyProc) parentBlock;
-                return recurseNode.executeProcNew(frame, procClass, args, proc);
-            }
+        protected RubyProc proc(VirtualFrame frame, RubyClass procClass, Object[] args, Nil block) {
+            throw new RaiseException(getContext(), coreExceptions().argumentErrorProcWithoutBlock(this));
         }
 
         @Specialization(guards = { "procClass == getProcClass()", "block.getShape() == getProcShape()" })