Raise a SyntaxError if the translator does not know how to deal with a node

* So it can still be caught in user code, e.g. for missing find pattern matching.

Author: eregon

src/main/java/org/truffleruby/debug/TruffleDebugNodes.java

@@ -76,7 +76,6 @@
 import org.truffleruby.language.arguments.NoKeywordArgumentsDescriptor;
 import org.truffleruby.language.arguments.RubyArguments;
 import org.truffleruby.language.backtrace.BacktraceFormatter;
-import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.library.RubyStringLibrary;
 import org.truffleruby.language.loader.ByteBasedCharSequence;
 import org.truffleruby.language.methods.DeclarationContext;
@@ -1461,16 +1460,7 @@ Object parseAndDump(Object code, Object focusedNodeClassName, int index, boolean
                 @Cached RubyStringLibrary strings,
                 @Cached TruffleString.FromJavaStringNode fromJavaStringNode) {
             String nodeClassNameString = RubyGuards.getJavaString(focusedNodeClassName);
-            RubyRootNode rootNode;
-            try {
-                rootNode = parse(code, mainScript);
-            } catch (Error e) {
-                if (e.getMessage() != null && e.getMessage().contains("does not know how to translate")) {
-                    throw new RaiseException(getContext(), coreExceptions().runtimeError(e.getMessage(), this));
-                } else {
-                    throw e;
-                }
-            }
+            RubyRootNode rootNode = parse(code, mainScript);
             String output = TruffleASTPrinter.dump(rootNode, nodeClassNameString, index);
             return createString(fromJavaStringNode, output, Encodings.UTF_8);
         }

src/main/java/org/truffleruby/parser/YARPBaseTranslator.java

@@ -11,7 +11,6 @@
 
 import java.util.List;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import org.prism.AbstractNodeVisitor;
 import org.prism.Nodes;
 import org.truffleruby.RubyLanguage;
@@ -21,6 +20,7 @@
 import org.truffleruby.language.RubyContextSourceNode;
 import org.truffleruby.language.RubyNode;
 import org.truffleruby.language.arguments.NoKeywordArgumentsDescriptor;
+import org.truffleruby.language.control.RaiseException;
 import org.truffleruby.language.control.SequenceNode;
 import org.truffleruby.language.dispatch.RubyCallNodeParameters;
 import org.truffleruby.language.literal.NilLiteralNode;
@@ -70,9 +70,9 @@ protected RuntimeException fail(Nodes.Node node) {
         var message = this.getClass().getSimpleName() + " does not know how to translate " +
                 node.getClass().getSimpleName() + " at " + context.fileLine(getSourceSection(node)) +
                 "\nCode snippet:\n" + code + "\nPrism AST:\n" + node;
-        // throw new RaiseException(context,
-        //         context.getCoreExceptions().syntaxError(message, null, getSourceSection(node)));
-        throw CompilerDirectives.shouldNotReachHere(message);
+        throw new RaiseException(context,
+                context.getCoreExceptions().syntaxError(message, null, getSourceSection(node)));
+        // throw CompilerDirectives.shouldNotReachHere(message); // Useful for debugging
     }
 
     @Override