Avoid storing the source path in RubySource because that is problematic for pre-initialization

* Notably the absolute path of did_you_mean.rb, etc would get in the image and fail the check.

Author: eregon

src/main/java/org/truffleruby/parser/RubySource.java

@@ -30,10 +30,6 @@
 public final class RubySource {
 
     private final Source source;
-    /** The path that will be used by the parser for __FILE__, warnings and syntax errors. Currently, the same as
-     * {@link RubyLanguage#getPath(Source)}. Kept separate as we might want to change Source#getName() for non-file
-     * Sources in the future (but then we'll need to still use this path in Ruby backtraces). */
-    private final String sourcePath;
     private final TruffleString code;
     private byte[] bytes;
     private final RubyEncoding encoding;
@@ -52,11 +48,14 @@ private RubySource(Source source, String sourcePath, TStringWithEncoding code, b
         this(source, sourcePath, code, isEval, 0);
     }
 
+    /** @param sourcePath The path that will be used by the parser for __FILE__, warnings and syntax errors. Currently,
+     *            the same as {@link RubyLanguage#getPath(Source)}. Kept separate as we might want to change
+     *            Source#getName() for non-file Sources in the future (but then we'll need to still use this path in
+     *            Ruby backtraces). */
     public RubySource(Source source, String sourcePath, TStringWithEncoding code, boolean isEval, int lineOffset) {
         assert RubyLanguage.getPath(source).equals(sourcePath) : RubyLanguage.getPath(source) + " vs " + sourcePath;
+
         this.source = Objects.requireNonNull(source);
-        //intern() to improve footprint
-        this.sourcePath = Objects.requireNonNull(sourcePath).intern();
 
         if (code == null) {
             // We only have the Source, which only contains a java.lang.String.
@@ -87,8 +86,9 @@ public Source getSource() {
         return source;
     }
 
-    public String getSourcePath() {
-        return sourcePath;
+    public String getSourcePath(RubyLanguage language) {
+        // NOTE: we avoid storing the source path in RubySource because that is problematic for pre-initialization
+        return language.getSourcePath(source);
     }
 
     public TruffleString getTruffleString() {

src/main/java/org/truffleruby/parser/TranslatorDriver.java

@@ -157,7 +157,7 @@ public RootCallTarget parse(RubySource rubySource, ParserContext parserContext,
             }
         }
 
-        boolean isInlineSource = rubySource.getSourcePath().equals("-e");
+        boolean isInlineSource = rubySource.getSourcePath(language).equals("-e");
         boolean isEvalParse = parserContext.isEval();
         final ParserConfiguration parserConfiguration = new ParserConfiguration(
                 context,

src/main/java/org/truffleruby/parser/YARPTranslatorDriver.java

@@ -166,7 +166,8 @@ public RootCallTarget parse(RubySource rubySource, ParserContext parserContext,
             }
         }
 
-        boolean isInlineSource = rubySource.getSourcePath().equals("-e");
+        String sourcePath = rubySource.getSourcePath(language);
+        boolean isInlineSource = sourcePath.equals("-e");
         boolean isEvalParse = parserContext.isEval();
         final ParserConfiguration parserConfiguration = new ParserConfiguration(
                 context,
@@ -430,8 +431,11 @@ public static org.prism.ParseResult parseToYARPAST(RubyContext context, RubyLang
         byte version = (byte) 1;
         byte[][][] scopes;
 
+        // intern() to improve footprint
+        String sourcePath = rubySource.getSourcePath(language).intern();
+
         if (rubySource.isEval()) {
-            filepath = rubySource.getSourcePath().getBytes(Encodings.FILESYSTEM_CHARSET);
+            filepath = sourcePath.getBytes(Encodings.FILESYSTEM_CHARSET);
 
             int scopesCount = localVariableNames.size();
             scopes = new byte[scopesCount][][];
@@ -452,7 +456,7 @@ public static org.prism.ParseResult parseToYARPAST(RubyContext context, RubyLang
         } else {
             assert localVariableNames.isEmpty(); // parsing of the whole source file cannot have outer scopes
 
-            filepath = rubySource.getSourcePath().getBytes(Encodings.FILESYSTEM_CHARSET);
+            filepath = sourcePath.getBytes(Encodings.FILESYSTEM_CHARSET);
             scopes = new byte[0][][];
         }
 
@@ -465,7 +469,6 @@ public static org.prism.ParseResult parseToYARPAST(RubyContext context, RubyLang
         ParseResult parseResult = YARPLoader.load(serializedBytes, yarpSource, context.getEncodingManager(),
                 rubySource);
 
-        final String filename = rubySource.getSourcePath();
         final ParseResult.Error[] errors = parseResult.errors;
 
         // collect warnings generated by the parser
@@ -475,8 +478,8 @@ public static org.prism.ParseResult parseToYARPAST(RubyContext context, RubyLang
             int lineNumber = RubySource.getStartLineAdjusted(context, section);
 
             switch (warning.level) {
-                case WARNING_DEFAULT -> rubyWarnings.warn(filename, lineNumber, warning.message);
-                case WARNING_VERBOSE -> rubyWarnings.warning(filename, lineNumber, warning.message);
+                case WARNING_DEFAULT -> rubyWarnings.warn(sourcePath, lineNumber, warning.message);
+                case WARNING_VERBOSE -> rubyWarnings.warning(sourcePath, lineNumber, warning.message);
             }
         }
 

src/main/java/org/truffleruby/parser/lexer/LexerSource.java

@@ -38,6 +38,7 @@
 
 import com.oracle.truffle.api.strings.TruffleString;
 import org.jcodings.Encoding;
+import org.truffleruby.RubyLanguage;
 import org.truffleruby.core.encoding.RubyEncoding;
 import org.truffleruby.core.string.TStringConstants;
 import org.truffleruby.parser.RubySource;
@@ -59,7 +60,7 @@ public final class LexerSource {
 
     public LexerSource(RubySource rubySource) {
         this.source = rubySource.getSource();
-        this.sourcePath = rubySource.getSourcePath();
+        this.sourcePath = RubyLanguage.getPath(rubySource.getSource());
 
         final RubyEncoding rubyEncoding = rubySource.getEncoding();
         this.sourceBytes = rubySource.getTruffleString();