Improved handling vmArgs

jisedlac · jisedlac · commit 0045441670a4 · 2024-07-02T17:52:22.000+02:00
diff --git a/integrations/vscode/src/monitoredProcesses.ts b/integrations/vscode/src/monitoredProcesses.ts
@@ -248,7 +248,7 @@ class ConfigurationProvider implements vscode.DebugConfigurationProvider {
                     });
                 }
             }
-            if (vmArgs) {
+            if (vmArgs.length) {
                 if (!config.vmArgs) {
                     config.vmArgs = vmArgs.join(' ');
                 } else {
@@ -259,6 +259,8 @@ class ConfigurationProvider implements vscode.DebugConfigurationProvider {
                     }
                 }
                 logUtils.logInfo(`[monitoredProcess] Added vmArgs for process startup: ${vmArgs.join(' ')}`);
+            } else {
+                logUtils.logInfo('[monitoredProcess] No vmArgs added for process startup');
             }
             resolve(config);
         });

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ class ConfigurationProvider implements vscode.DebugConfigurationProvider {`
`248`	`248`	`});`
`249`	`249`	`}`
`250`	`250`	`}`
`251`		`- if (vmArgs) {`
	`251`	`+ if (vmArgs.length) {`
`252`	`252`	`if (!config.vmArgs) {`
`253`	`253`	`config.vmArgs = vmArgs.join(' ');`
`254`	`254`	`} else {`
`@@ -259,6 +259,8 @@ class ConfigurationProvider implements vscode.DebugConfigurationProvider {`
`259`	`259`	`}`
`260`	`260`	`}`
`261`	`261`	logUtils.logInfo(`[monitoredProcess] Added vmArgs for process startup: ${vmArgs.join(' ')}`);
	`262`	`+ } else {`
	`263`	`+ logUtils.logInfo('[monitoredProcess] No vmArgs added for process startup');`
`262`	`264`	`}`
`263`	`265`	`resolve(config);`
`264`	`266`	`});`