Skip to content

Commit 1152b45

Browse files
thurkathurka
committed
use for-each loop
1 parent cceb2ef commit 1152b45

File tree

16 files changed

+63
-78
lines changed

16 files changed

+63
-78
lines changed

‎visualvm/libs.profiler/lib.profiler.charts/src/org/graalvm/visualvm/lib/charts/ChartComponent.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -570,13 +570,12 @@ protected void itemsChanged(List<ChartItemChange> itemChanges) {
570570
// Update chart appearance
571571
if (appearanceChange) {
572572
LongRect uiBounds = null;
573-
for (int i = 0; i < itemChanges.size(); i++) {
574-
ChartItemChange change = itemChanges.get(i);
573+
for (ChartItemChange change : itemChanges) {
575574
ChartItem item = change.getItem();
576575
ItemPainter painter = paintersModel.getPainter(item);
577576
if (painter.isAppearanceChange(change)) {
578-
if (uiBounds == null) uiBounds =
579-
new LongRect(painter.getDirtyBounds(change, getChartContext(item)));
577+
if (uiBounds == null)
578+
uiBounds = new LongRect(painter.getDirtyBounds(change, getChartContext(item)));
580579
else
581580
LongRect.add(uiBounds, painter.getDirtyBounds(change, getChartContext(item)));
582581
}

‎visualvm/libs.profiler/lib.profiler.charts/src/org/graalvm/visualvm/lib/charts/axis/BytesAxisUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ public static long[] getBytesUnits(double scale, int minDistance) {
6767
long bytesRadix = 0;
6868

6969
while (true) {
70-
for (int i = 0; i < bytesUnitsGrid.length; i++)
71-
if ((bytesUnitsGrid[i] * scale * bytesFactor) >= minDistance)
72-
return new long[] { bytesUnitsGrid[i] * bytesFactor, bytesRadix };
70+
for (long l : bytesUnitsGrid)
71+
if ((l * scale * bytesFactor) >= minDistance)
72+
return new long[]{l * bytesFactor, bytesRadix};
7373

7474
bytesFactor *= 1024;
7575
bytesRadix += 1;

‎visualvm/libs.profiler/lib.profiler.charts/src/org/graalvm/visualvm/lib/charts/axis/DecimalAxisUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ public static long getDecimalUnits(double scale, int minDistance) {
3939
long decimalFactor = 1;
4040

4141
while (true) {
42-
for (int i = 0; i < decimalUnitsGrid.length; i++)
43-
if ((decimalUnitsGrid[i] * scale * decimalFactor) >= minDistance)
44-
return decimalUnitsGrid[i] * decimalFactor;
42+
for (long l : decimalUnitsGrid)
43+
if ((l * scale * decimalFactor) >= minDistance)
44+
return l * decimalFactor;
4545

4646
decimalFactor *= 10;
4747
}

‎visualvm/libs.profiler/lib.profiler.charts/src/org/graalvm/visualvm/lib/charts/axis/TimeAxisUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,9 @@ public class TimeAxisUtils {
8787
public static long getTimeUnits(double scale, int minDistance) {
8888
if (Double.isNaN(scale) || scale == Double.POSITIVE_INFINITY || scale <= 0) return -1;
8989

90-
for (int i = 0; i < timeUnitsGrid.length; i++)
91-
if (timeUnitsGrid[i] * scale >= minDistance)
92-
return timeUnitsGrid[i];
90+
for (long l : timeUnitsGrid)
91+
if (l * scale >= minDistance)
92+
return l;
9393
return timeUnitsGrid[timeUnitsGrid.length - 1];
9494
}
9595

‎visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/charts/BarChart.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -573,9 +573,9 @@ protected void updateOffScreenImageSize() {
573573
private int getMaxY(int[] yItems) {
574574
int max = Integer.MIN_VALUE;
575575

576-
for (int i = 0; i < yItems.length; i++) {
577-
if (max < yItems[i]) {
578-
max = yItems[i];
576+
for (int yItem : yItems) {
577+
if (max < yItem) {
578+
max = yItem;
579579
}
580580
}
581581

‎visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/charts/DateTimeAxisUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ public static String getMinutesValue(long mark, boolean useDayMark) {
128128
}
129129

130130
public static long getOptimalUnits(double factor) {
131-
for (int i = 0; i < timeUnitsGrid.length; i++) {
132-
if ((timeUnitsGrid[i] * factor) >= MIN_TIMEMARK_STEP) {
133-
return timeUnitsGrid[i];
131+
for (long l : timeUnitsGrid) {
132+
if ((l * factor) >= MIN_TIMEMARK_STEP) {
133+
return l;
134134
}
135135
}
136136

‎visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/charts/DecimalAxisUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,9 @@ public static long getOptimalUnits(double factor, int minimumVerticalMarksDistan
4545
long decimalFactor = 1;
4646

4747
while (true) {
48-
for (int i = 0; i < timeUnitsGrid.length; i++) {
49-
if ((timeUnitsGrid[i] * decimalFactor * factor) >= minimumVerticalMarksDistance) {
50-
return timeUnitsGrid[i] * decimalFactor;
48+
for (long l : timeUnitsGrid) {
49+
if ((l * decimalFactor * factor) >= minimumVerticalMarksDistance) {
50+
return l * decimalFactor;
5151
}
5252
}
5353

‎visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/charts/DynamicPieChartModel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ private void updateItemValuesRel() {
108108
double sum = 0d;
109109

110110
// compute sum of all item values
111-
for (int i = 0; i < itemValues.length; i++) {
112-
sum += itemValues[i];
111+
for (double itemValue : itemValues) {
112+
sum += itemValue;
113113
}
114114

115115
// compute new relative item values

‎visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/cpu/StatisticsPanel.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -562,15 +562,14 @@ private void initComponents(HTMLTextArea navArea, PieChart pieChart) {
562562
}
563563

564564
private void refreshItemPresenters() {
565-
for (int i = 0; i < itemPresenters.size(); i++) {
566-
((ChartItemPresenter) itemPresenters.get(i)).refresh();
565+
for (ChartItemPresenter itemPresenter : itemPresenters) {
566+
itemPresenter.refresh();
567567
}
568568
}
569569

570570
// --- Private implementation ------------------------------------------------
571571
private void repopulateItemPresenters() {
572-
for (int i = 0; i < itemPresenters.size(); i++) {
573-
ChartItemPresenter itemPresenter = (ChartItemPresenter) itemPresenters.get(i);
572+
for (ChartItemPresenter itemPresenter : itemPresenters) {
574573
container.remove(itemPresenter.nameLabel);
575574
container.remove(itemPresenter.valueLabel);
576575
container.remove(itemPresenter.filler);
@@ -632,8 +631,8 @@ private void updateItemPresenters() {
632631
}
633632

634633
private void updateSnippets() {
635-
for (int i = 0; i < snippets.size(); i++) {
636-
container.remove((JComponent) snippets.get(i));
634+
for (SnippetPanel snippet : snippets) {
635+
container.remove(snippet);
637636
}
638637

639638
container.remove(snippetsBottomFiller);

‎visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/memory/LiveAllocResultsPanel.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -331,8 +331,8 @@ public void exportData(int typeOfFile, ExportDataDumper eDD, String viewName) {
331331
private void exportHTML(ExportDataDumper eDD, String viewName) {
332332
// Header
333333
StringBuffer result = new StringBuffer("<HTML><HEAD><meta http-equiv=\"Content-type\" content=\"text/html; charset=utf-8\" /><TITLE>"+viewName+"</TITLE></HEAD><BODY><TABLE border=\"1\"><tr>"); // NOI18N
334-
for (int i = 0; i < (columnNames.length); i++) {
335-
result.append("<th>").append(columnNames[i]).append("</th>"); // NOI18N
334+
for (String columnName : columnNames) {
335+
result.append("<th>").append(columnName).append("</th>"); // NOI18N
336336
}
337337
result.append("</tr>"); // NOI18N
338338
eDD.dumpData(result);
@@ -350,11 +350,11 @@ private void exportHTML(ExportDataDumper eDD, String viewName) {
350350

351351
private void exportXML(ExportDataDumper eDD, String viewName) {
352352
// Header
353-
String newline = System.getProperty("line.separator"); // NOI18N
353+
String newline = System.lineSeparator();
354354
StringBuffer result = new StringBuffer("<?xml version=\"1.0\" encoding=\"UTF-8\"?>"+newline+"<ExportedView Name=\""+viewName+"\">"+newline); // NOI18N
355355
result.append("<TableData NumRows=\"").append(nTrackedItems).append("\" NumColumns=\"4\">").append(newline).append("<TableHeader>"); // NOI18N
356-
for (int i = 0; i < (columnNames.length); i++) {
357-
result.append(" <TableColumn><![CDATA[").append(columnNames[i]).append("]]></TableColumn>").append(newline); // NOI18N
356+
for (String columnName : columnNames) {
357+
result.append(" <TableColumn><![CDATA[").append(columnName).append("]]></TableColumn>").append(newline); // NOI18N
358358
}
359359
result.append("</TableHeader>"); // NOI18N
360360
eDD.dumpData(result);
@@ -376,8 +376,8 @@ private void exportCSV(String separator, ExportDataDumper eDD) {
376376
String newLine = "\r\n"; // NOI18N
377377
String quote = "\""; // NOI18N
378378

379-
for (int i = 0; i < (columnNames.length); i++) {
380-
result.append(quote).append(columnNames[i]).append(quote).append(separator);
379+
for (String columnName : columnNames) {
380+
result.append(quote).append(columnName).append(quote).append(separator);
381381
}
382382
result.deleteCharAt(result.length()-1);
383383
result.append(newLine);

0 commit comments

Comments
 (0)