Skip to content

Commit 15d4ea7

Browse files
committed
JvmJvmstatModel.getJavaHome() can return null
1 parent 034caeb commit 15d4ea7

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

visualvm/sa/src/com/sun/tools/visualvm/sa/SaModelProvider.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,21 +104,27 @@ public SaModel createModelFor(DataSource ds) {
104104
}
105105

106106
private File getJdkHome(final JvmJvmstatModel jvmstat) {
107-
File jdkHome = new File(jvmstat.getJavaHome());
108-
if ("jre".equals(jdkHome.getName())) { // NOI18N
109-
jdkHome = jdkHome.getParentFile();
107+
String javaHome = jvmstat.getJavaHome();
108+
if (javaHome != null) {
109+
File jdkHome = new File(javaHome);
110+
if ("jre".equals(jdkHome.getName())) { // NOI18N
111+
jdkHome = jdkHome.getParentFile();
112+
}
113+
return jdkHome;
110114
}
111-
return jdkHome;
115+
return null;
112116
}
113117

114118
static File getSaJar(File jdkHome) {
115-
File saJar = new File(jdkHome,SA_JAR);
116-
try {
117-
if (saJar.exists()) {
118-
return saJar.getCanonicalFile();
119+
if (jdkHome != null) {
120+
File saJar = new File(jdkHome,SA_JAR);
121+
try {
122+
if (saJar.exists()) {
123+
return saJar.getCanonicalFile();
124+
}
125+
} catch (IOException ex) {
126+
LOGGER.log(Level.INFO, saJar.getPath(), ex);
119127
}
120-
} catch (IOException ex) {
121-
LOGGER.log(Level.INFO, saJar.getPath(), ex);
122128
}
123129
return null;
124130
}

0 commit comments

Comments
 (0)