Logical value for String class

thurka · thurka · commit 2774e1dedd60 · 2020-02-03T15:37:29.000+01:00
diff --git a/visualvm/heapviewer.truffle/src/org/graalvm/visualvm/heapviewer/truffle/lang/javascript/JavaScriptNodes.java b/visualvm/heapviewer.truffle/src/org/graalvm/visualvm/heapviewer/truffle/lang/javascript/JavaScriptNodes.java
@@ -142,6 +142,12 @@ static String getLogicalValue(JavaScriptObject object, String type, Heap heap) {
                     logicalValue = valueField.getValue();
                 }
             }
+        } else if ("String".equals(type) || "JSString".equals(type)) { // NOI18N
+            FieldValue stringField = object.getFieldValue("string (hidden)"); // NOI18N
+            if (stringField instanceof ObjectFieldValue) {
+                Instance val = ((ObjectFieldValue)stringField).getInstance();
+                logicalValue = DetailsSupport.getDetailsString(val, heap);
+            }
         } else if ("Error".equals(type)) { // NOI18N
             FieldValue valueField = object.getFieldValue("name"); // NOI18N
 

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,12 @@ static String getLogicalValue(JavaScriptObject object, String type, Heap heap) {`
`142`	`142`	`logicalValue = valueField.getValue();`
`143`	`143`	`}`
`144`	`144`	`}`
	`145`	`+ } else if ("String".equals(type) \|\| "JSString".equals(type)) { // NOI18N`
	`146`	`+ FieldValue stringField = object.getFieldValue("string (hidden)"); // NOI18N`
	`147`	`+ if (stringField instanceof ObjectFieldValue) {`
	`148`	`+ Instance val = ((ObjectFieldValue)stringField).getInstance();`
	`149`	`+ logicalValue = DetailsSupport.getDetailsString(val, heap);`
	`150`	`+ }`
`145`	`151`	`} else if ("Error".equals(type)) { // NOI18N`
`146`	`152`	`FieldValue valueField = object.getFieldValue("name"); // NOI18N`
`147`	`153`