Skip to content

Commit 291fc36

Browse files
committed
GH-362 JDK 18-ea support added
1 parent afca12e commit 291fc36

File tree

18 files changed

+43
-16
lines changed

18 files changed

+43
-16
lines changed

plugins/jfr.streaming/src/org/graalvm/visualvm/jfr/streaming/ThreadMonitoringProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public ThreadMonitoredDataResponseProvider getMonitoredDataResponseProvider(Appl
5656
try {
5757
Jvm jvm = JvmFactory.getJVMFor(app);
5858
String ver = jvm.getJavaVersion();
59-
if (isJavaVersion(ver, "17")) {
59+
if (isJavaVersion(ver, "17") || isJavaVersion(ver, "18")) {
6060
JmxModel jmx = JmxModelFactory.getJmxModelFor(app);
6161
RemoteRecordingStream rs = new RemoteRecordingStream(jmx.getMBeanServerConnection());
6262
JFRThreadDataProvider rp = new JFRThreadDataProvider(rs, threadMXBean);

visualvm/jvmstat/src/org/graalvm/visualvm/jvmstat/JvmJvmstatModelProvider.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,8 @@ public JvmJvmstatModel createModelFor(Application app) {
7676
else if (isJavaVersion(javaVersion,"16")) model = new JvmJvmstatModel_8(app,jvmstat); // NOI18N
7777
// JVM 17
7878
else if (isJavaVersion(javaVersion,"17")) model = new JvmJvmstatModel_8(app,jvmstat); // NOI18N
79+
// JVM 18
80+
else if (isJavaVersion(javaVersion,"18")) model = new JvmJvmstatModel_8(app,jvmstat); // NOI18N
7981
}
8082

8183
if (model == null) {

visualvm/launcher/visualvm.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ visualvm_default_cachedir="${DEFAULT_CACHEDIR_ROOT}/dev"
5858
# (can be overridden by explicit command line switches)
5959
#
6060

61-
visualvm_default_options="-J-Xms24m -J-Xmx768m -J-Dnetbeans.accept_license_class=org.graalvm.visualvm.modules.startup.AcceptLicense -J-Dnetbeans.importclass=org.graalvm.visualvm.modules.startup.ImportSettings -J-Dsun.jvmstat.perdata.syncWaitMs=10000 -J-Dsun.java2d.noddraw=true -J-Dsun.java2d.d3d=false -J-Dorg.netbeans.core.TimeableEventQueue.quantum=360000 -J-Dpolyglot.js.nashorn-compat=true -J-Dsun.misc.URLClassPath.disableJarChecking=true -J-Djdk.attach.allowAttachSelf=true -J-Dorg.openide.util.ImageUtilities.level=950 -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED -J--add-exports=java.desktop/sun.awt=ALL-UNNAMED -J--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor.event=ALL-UNNAMED -J--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED -J--add-exports=java.desktop/sun.swing=ALL-UNNAMED -J--add-exports=jdk.attach/sun.tools.attach=ALL-UNNAMED -J--add-opens=java.desktop/sun.awt.X11=ALL-UNNAMED -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED -J--add-opens=java.base/java.net=ALL-UNNAMED -J--add-opens=java.base/java.lang.ref=ALL-UNNAMED -J--add-opens=java.base/java.lang=ALL-UNNAMED -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED -J--add-opens=java.desktop/javax.swing.plaf.basic=ALL-UNNAMED -J-XX:+IgnoreUnrecognizedVMOptions -J-Dnetbeans.logger.console=true -J-Dnetbeans.exception.report.min.level=900 -J-ea"
61+
visualvm_default_options="-J-Xms24m -J-Xmx768m -J-Dnetbeans.accept_license_class=org.graalvm.visualvm.modules.startup.AcceptLicense -J-Dnetbeans.importclass=org.graalvm.visualvm.modules.startup.ImportSettings -J-Dsun.jvmstat.perdata.syncWaitMs=10000 -J-Dsun.java2d.noddraw=true -J-Dsun.java2d.d3d=false -J-Dorg.netbeans.core.TimeableEventQueue.quantum=360000 -J-Dpolyglot.js.nashorn-compat=true -J-Dsun.misc.URLClassPath.disableJarChecking=true -J-Djdk.attach.allowAttachSelf=true -J-Dorg.openide.util.ImageUtilities.level=950 -J-DTopSecurityManager.disable=true -J--add-exports=java.desktop/com.sun.java.swing.plaf.gtk=ALL-UNNAMED -J--add-exports=java.desktop/sun.awt=ALL-UNNAMED -J--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor.event=ALL-UNNAMED -J--add-exports=jdk.internal.jvmstat/sun.jvmstat.monitor=ALL-UNNAMED -J--add-exports=java.desktop/sun.swing=ALL-UNNAMED -J--add-exports=jdk.attach/sun.tools.attach=ALL-UNNAMED -J--add-opens=java.desktop/sun.awt.X11=ALL-UNNAMED -J--add-opens=java.desktop/javax.swing.plaf.synth=ALL-UNNAMED -J--add-opens=java.base/java.net=ALL-UNNAMED -J--add-opens=java.base/java.lang.ref=ALL-UNNAMED -J--add-opens=java.base/java.lang=ALL-UNNAMED -J--add-opens=java.desktop/javax.swing=ALL-UNNAMED -J--add-opens=java.desktop/javax.swing.plaf.basic=ALL-UNNAMED -J-XX:+IgnoreUnrecognizedVMOptions -J-Dnetbeans.logger.console=true -J-Dnetbeans.exception.report.min.level=900 -J-ea"
6262
# for development purposes you may wish to append: -J-Dnetbeans.logger.console=true -J-Dnetbeans.exception.report.min.level=900 -J-ea
6363

6464
# Default location of JDK:
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Manifest-Version: 1.0
22
OpenIDE-Module: org.graalvm.visualvm.lib.common/2
33
OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/lib/common/Bundle.properties
4-
OpenIDE-Module-Specification-Version: 2.4
4+
OpenIDE-Module-Specification-Version: 2.5
55
OpenIDE-Module-Needs: org.graalvm.visualvm.lib.common.Profiler
66

visualvm/libs.profiler/lib.profiler.common/nbproject/project.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ questions.
3636
<compile-dependency/>
3737
<run-dependency>
3838
<release-version>2</release-version>
39-
<specification-version>2.9</specification-version>
39+
<specification-version>2.11</specification-version>
4040
</run-dependency>
4141
</dependency>
4242
<dependency>

visualvm/libs.profiler/lib.profiler.common/src/org/graalvm/visualvm/lib/common/integration/Bundle.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ IntegrationUtils_PlatformJava140=Java SE 14
3535
IntegrationUtils_PlatformJava150=Java SE 15
3636
IntegrationUtils_PlatformJava160=Java SE 16
3737
IntegrationUtils_PlatformJava170=Java SE 17
38+
IntegrationUtils_PlatformJava180=Java SE 18
3839
IntegrationUtils_PlatformJavaCvm=CVM
3940
IntegrationUtils_PlatformWindowsOs=Windows, 32bit JVM
4041
IntegrationUtils_PlatformWindowsAmd64Os=Windows, 64bit JVM
@@ -77,6 +78,7 @@ IntegrationUtils_Jdk140Name=Java SE 14 (JRE or JDK)
7778
IntegrationUtils_Jdk150Name=Java SE 15 (JRE or JDK)
7879
IntegrationUtils_Jdk160Name=Java SE 16 (JRE or JDK)
7980
IntegrationUtils_Jdk170Name=Java SE 17 (JRE or JDK)
81+
IntegrationUtils_Jdk180Name=Java SE 18 (JRE or JDK)
8082
IntegrationUtils_JdkCvmName=CVM
8183
IntegrationUtils_RemoteString=remote
8284
# HTML-formatted

visualvm/libs.profiler/lib.profiler.common/src/org/graalvm/visualvm/lib/common/integration/IntegrationUtils.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ public class IntegrationUtils {
6262
public static final String PLATFORM_JAVA_150 = messages.getString("IntegrationUtils_PlatformJava150"); // NOI18N
6363
public static final String PLATFORM_JAVA_160 = messages.getString("IntegrationUtils_PlatformJava160"); // NOI18N
6464
public static final String PLATFORM_JAVA_170 = messages.getString("IntegrationUtils_PlatformJava170"); // NOI18N
65+
public static final String PLATFORM_JAVA_180 = messages.getString("IntegrationUtils_PlatformJava180"); // NOI18N
6566
public static final String PLATFORM_JAVA_CVM = messages.getString("IntegrationUtils_PlatformJavaCvm"); // NOI18N
6667
public static final String PLATFORM_WINDOWS_OS = messages.getString("IntegrationUtils_PlatformWindowsOs"); // NOI18N
6768
public static final String PLATFORM_WINDOWS_AMD64_OS = messages.getString("IntegrationUtils_PlatformWindowsAmd64Os"); // NOI18N
@@ -97,6 +98,7 @@ public class IntegrationUtils {
9798
private static final String JDK_150_NAME = messages.getString("IntegrationUtils_Jdk150Name"); // NOI18N
9899
private static final String JDK_160_NAME = messages.getString("IntegrationUtils_Jdk160Name"); // NOI18N
99100
private static final String JDK_170_NAME = messages.getString("IntegrationUtils_Jdk170Name"); // NOI18N
101+
private static final String JDK_180_NAME = messages.getString("IntegrationUtils_Jdk180Name"); // NOI18N
100102
private static final String JDK_CVM_NAME = messages.getString("IntegrationUtils_JdkCvmName"); // NOI18N
101103
private static final String HTML_REMOTE_STRING = "&lt;" + messages.getString("IntegrationUtils_RemoteString") + "&gt;"; // NOI18N
102104
private static final String EXPORT_SETENV_MESSAGE = messages.getString("IntegrationUtils_ExportSetenvMessage"); // NOI18N
@@ -284,6 +286,8 @@ public static String getJavaPlatformFromJavaVersionString(String javaVersionStri
284286
return PLATFORM_JAVA_160;
285287
} else if (javaVersionString.equals(CommonConstants.JDK_170_STRING)) {
286288
return PLATFORM_JAVA_170;
289+
} else if (javaVersionString.equals(CommonConstants.JDK_180_STRING)) {
290+
return PLATFORM_JAVA_180;
287291
} else if (javaVersionString.equals(CommonConstants.JDK_CVM_STRING)) {
288292
return PLATFORM_JAVA_CVM;
289293
}
@@ -363,6 +367,8 @@ public static String getJavaPlatformName(String javaPlatform) {
363367
return JDK_160_NAME;
364368
} else if (javaPlatform.equals(PLATFORM_JAVA_170)) {
365369
return JDK_170_NAME;
370+
} else if (javaPlatform.equals(PLATFORM_JAVA_180)) {
371+
return JDK_180_NAME;
366372
} else if (javaPlatform.equals(PLATFORM_JAVA_CVM)) {
367373
return JDK_CVM_NAME;
368374
}
@@ -398,6 +404,8 @@ public static String getJavaPlatformNativeLibrariesDirectoryName(String javaPlat
398404
return "jdk16"; //NOI18N // for JDK 16 we use the same as for 6.0 for now
399405
} else if (javaPlatform.equals(PLATFORM_JAVA_170)) {
400406
return "jdk16"; //NOI18N // for JDK 17 we use the same as for 6.0 for now
407+
} else if (javaPlatform.equals(PLATFORM_JAVA_180)) {
408+
return "jdk16"; //NOI18N // for JDK 17 we use the same as for 6.0 for now
401409
} else if (javaPlatform.equals(PLATFORM_JAVA_CVM)) {
402410
return "cvm"; // NOI18N
403411
}
@@ -456,6 +464,8 @@ public static String getLocalJavaPlatform() {
456464
return PLATFORM_JAVA_160;
457465
} else if (jdkVersion == Platform.JDK_170) {
458466
return PLATFORM_JAVA_170;
467+
} else if (jdkVersion == Platform.JDK_180) {
468+
return PLATFORM_JAVA_180;
459469
}
460470

461471
return null;
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Manifest-Version: 1.0
22
OpenIDE-Module: org.graalvm.visualvm.lib.jfluid/2
33
OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/lib/jfluid/Bundle.properties
4-
OpenIDE-Module-Specification-Version: 2.10
4+
OpenIDE-Module-Specification-Version: 2.11
55

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/TargetAppRunner.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -684,7 +684,8 @@ private boolean startTargetVM(String[] jvmArgs, String mainClassName, String[] m
684684
|| jdkVer.equals(JDK_140_STRING)
685685
|| jdkVer.equals(JDK_150_STRING)
686686
|| jdkVer.equals(JDK_160_STRING)
687-
|| jdkVer.equals(JDK_170_STRING)) {
687+
|| jdkVer.equals(JDK_170_STRING)
688+
|| jdkVer.equals(JDK_180_STRING)) {
688689
// for now the 1.6 and 1.7 and 1.8 and 9 and 10+ profiling uses the same jfluid-server as 1.5
689690
jdkVer = JDK_15_STRING;
690691
}

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/global/CommonConstants.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public interface CommonConstants {
8888
public static final int JDK_150 = 13;
8989
public static final int JDK_160 = 14;
9090
public static final int JDK_170 = 15;
91+
public static final int JDK_180 = 16;
9192
public static final int JDK_CVM = 5;
9293
public static final int JDK_UNSUPPORTED = -1;
9394

@@ -105,6 +106,7 @@ public interface CommonConstants {
105106
public static final String JDK_150_STRING = "jdk150"; // NOI18N
106107
public static final String JDK_160_STRING = "jdk160"; // NOI18N
107108
public static final String JDK_170_STRING = "jdk170"; // NOI18N
109+
public static final String JDK_180_STRING = "jdk180"; // NOI18N
108110
public static final String JDK_CVM_STRING = "cvm"; // NOI18N
109111
public static final String JDK_UNSUPPORTED_STRING = "UNSUPPORTED_JDK"; // NOI18N
110112

0 commit comments

Comments
 (0)