Skip to content

Commit 3316747

Browse files
thurkathurka
committed
unused parameter removed
1 parent 24e5131 commit 3316747

File tree

9 files changed

+47
-47
lines changed

9 files changed

+47
-47
lines changed

‎visualvm/heapviewer.truffle/nbproject/project.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<compile-dependency/>
2222
<run-dependency>
2323
<release-version>2</release-version>
24-
<specification-version>2.6</specification-version>
24+
<specification-version>2.7</specification-version>
2525
</run-dependency>
2626
</dependency>
2727
<dependency>

‎visualvm/heapviewer.truffle/src/org/graalvm/visualvm/heapviewer/truffle/TruffleObjectPropertyPlugin.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,18 +97,18 @@ public TruffleObjectPropertyPlugin(String name, String description, Icon icon, S
9797

9898
TreeTableViewColumn[] columns = mergedPropertiesKey == null ?
9999
new TreeTableViewColumn[] {
100-
new TreeTableViewColumn.Name(heap),
101-
new TreeTableViewColumn.LogicalValue(heap),
100+
new TreeTableViewColumn.Name(),
101+
new TreeTableViewColumn.LogicalValue(),
102102
new TreeTableViewColumn.OwnSize(heap, false, false),
103103
new TreeTableViewColumn.RetainedSize(heap, false, false),
104-
new TreeTableViewColumn.ObjectID(heap)
104+
new TreeTableViewColumn.ObjectID()
105105
} : new TreeTableViewColumn[] {
106-
new TreeTableViewColumn.Name(heap),
107-
new TreeTableViewColumn.LogicalValue(heap),
106+
new TreeTableViewColumn.Name(),
107+
new TreeTableViewColumn.LogicalValue(),
108108
new TreeTableViewColumn.Count(heap, true, true),
109109
new TreeTableViewColumn.OwnSize(heap, false, false),
110110
new TreeTableViewColumn.RetainedSize(heap, false, false),
111-
new TreeTableViewColumn.ObjectID(heap)
111+
new TreeTableViewColumn.ObjectID()
112112
};
113113
objectsView = new TreeTableView(viewID, context, actions, columns) {
114114
protected HeapViewerNode[] computeData(RootNode root, Heap heap, String viewID, HeapViewerNodeFilter viewFilter, List<DataType> dataTypes, List<SortOrder> sortOrders, Progress progress) throws InterruptedException {

‎visualvm/heapviewer/manifest.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ AutoUpdate-Show-In-Client: false
33
AutoUpdate-Essential-Module: true
44
OpenIDE-Module: org.graalvm.visualvm.heapviewer/2
55
OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/heapviewer/Bundle.properties
6-
OpenIDE-Module-Specification-Version: 2.6
6+
OpenIDE-Module-Specification-Version: 2.7
77

‎visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/java/impl/JavaDiffObjectsView.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,14 +146,14 @@ private static enum Aggregation {
146146

147147
TreeTableViewColumn[] columns = compareRetained ?
148148
new TreeTableViewColumn[] {
149-
new TreeTableViewColumn.Name(heap),
149+
new TreeTableViewColumn.Name(),
150150
// new TreeTableViewColumn.LogicalValue(heap),
151151
countC,
152152
sizeC,
153153
retainedC
154154
} :
155155
new TreeTableViewColumn[] {
156-
new TreeTableViewColumn.Name(heap),
156+
new TreeTableViewColumn.Name(),
157157
// new TreeTableViewColumn.LogicalValue(heap),
158158
countC,
159159
sizeC

‎visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/java/impl/JavaFieldsPlugin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,12 @@ class JavaFieldsPlugin extends HeapViewPlugin {
134134
heap = context.getFragment().getHeap();
135135

136136
TreeTableViewColumn[] columns = new TreeTableViewColumn[] {
137-
new TreeTableViewColumn.Name(heap),
138-
new TreeTableViewColumn.LogicalValue(heap),
137+
new TreeTableViewColumn.Name(),
138+
new TreeTableViewColumn.LogicalValue(),
139139
new TreeTableViewColumn.Count(heap, true, true),
140140
new TreeTableViewColumn.OwnSize(heap, false, false),
141141
new TreeTableViewColumn.RetainedSize(heap, false, false),
142-
new TreeTableViewColumn.ObjectID(heap)
142+
new TreeTableViewColumn.ObjectID()
143143
};
144144
objectsView = new TreeTableView("java_objects_fields", context, actions, columns) { // NOI18N
145145
@Override

‎visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/java/impl/JavaReferencesPlugin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,12 @@ class JavaReferencesPlugin extends HeapViewPlugin {
126126
heap = context.getFragment().getHeap();
127127

128128
TreeTableViewColumn[] columns = new TreeTableViewColumn[] {
129-
new TreeTableViewColumn.Name(heap),
130-
new TreeTableViewColumn.LogicalValue(heap),
129+
new TreeTableViewColumn.Name(),
130+
new TreeTableViewColumn.LogicalValue(),
131131
new TreeTableViewColumn.Count(heap, true, true),
132132
new TreeTableViewColumn.OwnSize(heap, false, false),
133133
new TreeTableViewColumn.RetainedSize(heap, false, false),
134-
new TreeTableViewColumn.ObjectID(heap)
134+
new TreeTableViewColumn.ObjectID()
135135
};
136136
objectsView = new TreeTableView("java_objects_references", context, actions, columns) { // NOI18N
137137
protected HeapViewerNode[] computeData(RootNode root, Heap heap, String viewID, HeapViewerNodeFilter viewFilter, List<DataType> dataTypes, List<SortOrder> sortOrders, Progress progress) throws InterruptedException {

‎visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/java/impl/PathToGCRootPlugin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,12 @@ public PathToGCRootPlugin(HeapContext context, HeapViewerActions actions) {
129129
heap = context.getFragment().getHeap();
130130

131131
TreeTableViewColumn[] columns = new TreeTableViewColumn[] {
132-
new TreeTableViewColumn.Name(heap),
133-
new TreeTableViewColumn.LogicalValue(heap),
132+
new TreeTableViewColumn.Name(),
133+
new TreeTableViewColumn.LogicalValue(),
134134
new TreeTableViewColumn.Count(heap, true, true),
135135
new TreeTableViewColumn.OwnSize(heap, false, false),
136136
new TreeTableViewColumn.RetainedSize(heap, false, false),
137-
new TreeTableViewColumn.ObjectID(heap)
137+
new TreeTableViewColumn.ObjectID()
138138
};
139139
objectsView = new TreeTableView("java_objects_gcroots", context, actions, columns) { // NOI18N
140140
protected HeapViewerNode[] computeData(RootNode root, Heap heap, String viewID, HeapViewerNodeFilter viewFilter, List<DataType> dataTypes, List<SortOrder> sortOrders, Progress progress) throws InterruptedException {

‎visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/oql/OQLConsoleView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ protected void queryFinished(boolean hasObjectsResults, boolean hasHTMLResults,
314314
};
315315

316316
TreeTableViewColumn[] ownColumns = new TreeTableViewColumn[] {
317-
new TreeTableViewColumn.Name(heap),
317+
new TreeTableViewColumn.Name(),
318318
new TreeTableViewColumn.Count(heap, false, false),
319319
new TreeTableViewColumn.OwnSize(heap, true, true),
320320
new TreeTableViewColumn.RetainedSize(heap, true, false)

‎visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/ui/TreeTableViewColumn.java

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -87,75 +87,75 @@ public TreeTableViewColumn(String name, int position, DataType dataType, boolean
8787

8888
public static TreeTableViewColumn[] classes(Heap heap, boolean sort) {
8989
return new TreeTableViewColumn[] {
90-
new Name(heap),
91-
new LogicalValue(heap),
90+
new Name(),
91+
new LogicalValue(),
9292
new Count(heap),
9393
new OwnSize(heap, true, sort),
9494
new RetainedSize(heap),
95-
new ObjectID(heap)
95+
new ObjectID()
9696
};
9797
}
9898

9999
public static TreeTableViewColumn[] classesMinimal(Heap heap, boolean sort) {
100100
return new TreeTableViewColumn[] {
101-
new Name(heap),
102-
new LogicalValue(heap),
101+
new Name(),
102+
new LogicalValue(),
103103
new Count(heap, false, false),
104104
new OwnSize(heap, false, false),
105105
new RetainedSize(heap, true, sort),
106-
new ObjectID(heap)
106+
new ObjectID()
107107
};
108108
}
109109

110110
public static TreeTableViewColumn[] classesPlain(Heap heap) {
111111
return new TreeTableViewColumn[] {
112-
new Name(heap),
113-
new LogicalValue(heap),
112+
new Name(),
113+
new LogicalValue(),
114114
new Count(heap, false, false),
115115
new OwnSize(heap, false, false),
116116
new RetainedSize(heap, false, false),
117-
new ObjectID(heap)
117+
new ObjectID()
118118
};
119119
}
120120

121121
public static TreeTableViewColumn[] instances(Heap heap, boolean sort) {
122122
return new TreeTableViewColumn[] {
123-
new Name(heap),
124-
new LogicalValue(heap),
123+
new Name(),
124+
new LogicalValue(),
125125
new OwnSize(heap, true, sort),
126126
new RetainedSize(heap),
127-
new ObjectID(heap)
127+
new ObjectID()
128128
};
129129
}
130130

131131
public static TreeTableViewColumn[] instancesMinimal(Heap heap, boolean sort) {
132132
return new TreeTableViewColumn[] {
133-
new Name(heap),
134-
new LogicalValue(heap),
133+
new Name(),
134+
new LogicalValue(),
135135
new OwnSize(heap, false, false),
136136
new RetainedSize(heap, true, sort),
137-
new ObjectID(heap)
137+
new ObjectID()
138138
};
139139
}
140140

141141
public static TreeTableViewColumn[] instancesPlain(Heap heap) {
142142
return new TreeTableViewColumn[] {
143-
new Name(heap),
144-
new LogicalValue(heap),
143+
new Name(),
144+
new LogicalValue(),
145145
new OwnSize(heap, false, false),
146146
new RetainedSize(heap, false, false),
147-
new ObjectID(heap)
147+
new ObjectID()
148148
};
149149
}
150150

151151

152152
public static class Name extends TreeTableViewColumn {
153153

154-
public Name(Heap heap) {
155-
this(heap, false);
154+
public Name() {
155+
this(false);
156156
}
157157

158-
public Name(Heap heap, boolean initiallySorting) {
158+
public Name(boolean initiallySorting) {
159159
super(Bundle.TreeTableViewColumn_ColName(), 100, DataType.NAME, true, initiallySorting);
160160
}
161161

@@ -166,11 +166,11 @@ public static class LogicalValue extends TreeTableViewColumn {
166166
private final LabelRenderer renderer;
167167
private final int preferredWidth;
168168

169-
public LogicalValue(Heap heap) {
170-
this(heap, false, false);
169+
public LogicalValue() {
170+
this(false, false);
171171
}
172172

173-
public LogicalValue(Heap heap, boolean initiallyVisible, boolean initiallySorting) {
173+
public LogicalValue(boolean initiallyVisible, boolean initiallySorting) {
174174
super(Bundle.TreeTableViewColumn_ColLogicalValue(), 150, DataType.LOGICAL_VALUE, initiallyVisible, initiallySorting);
175175

176176
renderer = new LabelRenderer() {
@@ -268,11 +268,11 @@ public static class ObjectID extends TreeTableViewColumn {
268268
private final LabelRenderer renderer;
269269
private final int preferredWidth;
270270

271-
public ObjectID(Heap heap) {
272-
this(heap, false, false);
271+
public ObjectID() {
272+
this(false, false);
273273
}
274274

275-
public ObjectID(Heap heap, boolean initiallyVisible, boolean initiallySorting) {
275+
public ObjectID(boolean initiallyVisible, boolean initiallySorting) {
276276
super(Bundle.TreeTableViewColumn_ColObjectId(), 500, DataType.OBJECT_ID, initiallyVisible, initiallySorting);
277277

278278
renderer = new LabelRenderer() {

0 commit comments

Comments
 (0)