GH-330 histogram is not available for read-only JMX connection

thurka · thurka · commit 4334a79b1147 · 2021-07-28T12:27:14.000+02:00
diff --git a/visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxSupport.java b/visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxSupport.java
@@ -408,6 +408,7 @@ String getFlagValue(String name) {
     }
 
     HeapHistogram takeHeapHistogram() {
+        if (isReadOnlyConnection()) return null;
         String histo = executeJCmd(HISTOGRAM_COMMAND, Collections.singletonMap(ALL_OBJECTS_OPTION, null));
         if (histo != null) {
             return new HeapHistogramImpl((String)histo);

Original file line number	Diff line number	Diff line change
`@@ -408,6 +408,7 @@ String getFlagValue(String name) {`
`408`	`408`	`}`
`409`	`409`
`410`	`410`	`HeapHistogram takeHeapHistogram() {`
	`411`	`+ if (isReadOnlyConnection()) return null;`
`411`	`412`	`String histo = executeJCmd(HISTOGRAM_COMMAND, Collections.singletonMap(ALL_OBJECTS_OPTION, null));`
`412`	`413`	`if (histo != null) {`
`413`	`414`	`return new HeapHistogramImpl((String)histo);`