Skip to content

Commit 47ac148

Browse files
committed
GH-311 Fixed Logfile/Options location instructions on macOS
- Tools | Options in profiler libs left hardcoded (no dependency on VisualVM-Core)
1 parent 04fdad8 commit 47ac148

File tree

37 files changed

+73
-49
lines changed

37 files changed

+73
-49
lines changed

visualvm/core/manifest.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ OpenIDE-Module: org.graalvm.visualvm.core/2
55
OpenIDE-Module-Layer: org/graalvm/visualvm/core/layer.xml
66
OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/core/Bundle.properties
77
OpenIDE-Module-Install: org/graalvm/visualvm/core/Install$Impl.class
8-
OpenIDE-Module-Specification-Version: 2.3
8+
OpenIDE-Module-Specification-Version: 2.4
99

visualvm/core/src/org/graalvm/visualvm/core/Bundle.properties

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,7 @@ Services/AutoupdateType/com_sun_tools_visualvm_core_update_center.instance=Visua
3131
Menu/Applications=&Applications
3232
Toolbars/Snapshot=&Snapshot
3333
Toolbars/DataSource=&Data Source
34+
OptionsHandle=Tools | Options
35+
OptionsHandleMac=VisualVM | Preferences...
36+
LogfileHandle=Help | About | Logfile
37+
LogfileHandleMac=VisualVM | About VisualVM | Logfile

visualvm/core/src/org/graalvm/visualvm/core/VisualVM.java

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@
2828
import java.util.ArrayList;
2929
import java.util.Collection;
3030
import org.graalvm.visualvm.core.datasupport.ComparableWeakReference;
31+
import org.openide.util.NbBundle;
3132
import org.openide.util.RequestProcessor;
33+
import org.openide.util.Utilities;
3234

3335
/**
3436
*
@@ -91,4 +93,17 @@ synchronized boolean closing() {
9193
return true;
9294
}
9395

96+
97+
public final String getOptionsHandle() {
98+
return Utilities.isMac() ?
99+
NbBundle.getMessage(VisualVM.class, "OptionsHandleMac") : // NOI18N
100+
NbBundle.getMessage(VisualVM.class, "OptionsHandle"); // NOI18N
101+
}
102+
103+
public final String getLogfileHandle() {
104+
return Utilities.isMac() ?
105+
NbBundle.getMessage(VisualVM.class, "LogfileHandleMac") : // NOI18N
106+
NbBundle.getMessage(VisualVM.class, "LogfileHandle"); // NOI18N
107+
}
108+
94109
}

visualvm/coredump/manifest.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ OpenIDE-Module: org.graalvm.visualvm.coredump/2
55
OpenIDE-Module-Layer: org/graalvm/visualvm/coredump/resources/layer.xml
66
OpenIDE-Module-Install: org/graalvm/visualvm/coredump/Installer.class
77
OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/coredump/Bundle.properties
8-
OpenIDE-Module-Specification-Version: 2.0
8+
OpenIDE-Module-Specification-Version: 2.1
99

visualvm/coredump/nbproject/project.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<compile-dependency/>
1313
<run-dependency>
1414
<release-version>2</release-version>
15-
<specification-version>2.0</specification-version>
15+
<specification-version>2.4</specification-version>
1616
</run-dependency>
1717
</dependency>
1818
<dependency>

visualvm/coredump/src/org/graalvm/visualvm/coredump/impl/Bundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,4 +89,4 @@ Title_Unresolved_CoreDumps=Could Not Load Core Dump
8989

9090
MSG_Unresolved_CoreDumps=<html><b>These core dumps could not be found:</b><br>Do you want to load them on next VisualVM session?<br><br></html>
9191

92-
MSG_CoreDump_Failed=<b>Failed to read the VM coredump file.</b><br><br>Check the VisualVM logfile (Help | About | Logfile).
92+
MSG_CoreDump_Failed=<b>Failed to read the VM coredump file.</b><br><br>Check the VisualVM logfile ({0}).

visualvm/coredump/src/org/graalvm/visualvm/coredump/impl/CoreDumpOverviewView.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
import javax.swing.BorderFactory;
3737
import javax.swing.ImageIcon;
3838
import javax.swing.JPanel;
39+
import org.graalvm.visualvm.core.VisualVM;
3940
import org.openide.util.ImageUtilities;
4041
import org.openide.util.NbBundle;
4142

@@ -157,7 +158,7 @@ private String getGeneralProperties(SaModel saAgent) {
157158
data.append("<b>"+jhLbl+":</b> " + saAgent.getJavaHome() + "<br>"); // NOI18N
158159
data.append("<b>"+flagsLbl+":</b> " + (jvmFlags == null || jvmFlags.isEmpty() ? NbBundle.getMessage(CoreDumpOverviewView.class, "LBL_none") : jvmFlags) + "<br><br>"); // NOI18N
159160
} else {
160-
data.append(NbBundle.getMessage(CoreDumpOverviewView.class, "MSG_CoreDump_Failed")); // NOI18N
161+
data.append(NbBundle.getMessage(CoreDumpOverviewView.class, "MSG_CoreDump_Failed", VisualVM.getInstance().getLogfileHandle())); // NOI18N
161162
}
162163

163164
return data.toString();

visualvm/host/manifest.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ OpenIDE-Module-Layer: org/graalvm/visualvm/host/resources/layer.xml
66
OpenIDE-Module-Install: org/graalvm/visualvm/host/Installer.class
77
OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/host/Bundle.properties
88
OpenIDE-Module-Recommends: org.graalvm.visualvm.jvm
9-
OpenIDE-Module-Specification-Version: 2.0
9+
OpenIDE-Module-Specification-Version: 2.1
1010

visualvm/host/nbproject/project.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<compile-dependency/>
1313
<run-dependency>
1414
<release-version>2</release-version>
15-
<specification-version>2.0</specification-version>
15+
<specification-version>2.4</specification-version>
1616
</run-dependency>
1717
</dependency>
1818
<dependency>

visualvm/host/src/org/graalvm/visualvm/host/impl/Bundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ LBL_DnsName=DNS name\:
4949
LBL_IpAddress=IP address\:
5050

5151
LBL_RememberAction=&Remember selected action
52-
TTP_RememberAction=Select to perform the action automatically on subsequent sessions. Can be reset using Tools | Options | General | Reset Do Not Show Again confirmations.
52+
TTP_RememberAction=Select to perform the action automatically on subsequent sessions. Can be reset using {0} | General | Reset Do Not Show Again confirmations.

0 commit comments

Comments
 (0)