lower the number of javac warnings

Author: thurka

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericEvent.java

@@ -256,9 +256,9 @@ protected <T> T getValue(IAttribute<T> attribute) throws JFRPropertyNotAvailable
 
 
     @Override
-    public List<Comparable> getDisplayableValues(boolean includeExperimental) {
+    public List<Comparable<?>> getDisplayableValues(boolean includeExperimental) {
         IType type = item.getType();        
-        List<Comparable> values = new ArrayList<>();
+        List<Comparable<?>> values = new ArrayList<>();
         Iterator<IAccessorKey> keys = DisplayableSupport.displayableAccessorKeys(type, includeExperimental);
         while (keys.hasNext()) {
             IAccessorKey key = keys.next();

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/DisplayableSupport.java

@@ -64,7 +64,7 @@ final class DisplayableSupport {
     private static final DefaultProcessor DEFAULT_PROCESSOR = new DefaultProcessor();
     private static final DefaultFormat DEFAULT_FORMAT = new DefaultFormat();
 
-    private static final FormatProcessor[] FORMAT_PROCESSORS = new FormatProcessor[] {
+    private static final FormatProcessor<? extends Annotation>[] FORMAT_PROCESSORS = new FormatProcessor<?>[] {
         new TimestampFormatProcessor(),
         new TimespanFormatProcessor(),
         new MemoryAddressFormatProcessor(),
@@ -79,7 +79,7 @@ final class DisplayableSupport {
         new RecordedClassLoaderProcessor()
     };
 
-    private static final Set<String> PRIMITIVE_NUMERIC = new HashSet(Arrays.asList(new String[] {
+    private static final Set<String> PRIMITIVE_NUMERIC = new HashSet<>(Arrays.asList(new String[] {
         "byte", "short", "int", "long", "char", "float", "double" // char?
     }));
 
@@ -164,7 +164,7 @@ static JFRDataDescriptor getDataDescriptor(ValueDescriptor descriptor) {
     }
 
 
-    static Comparable getDisplayValue(JFRJDK11Event event, ValueDescriptor descriptor) {
+    static Comparable<?> getDisplayValue(JFRJDK11Event event, ValueDescriptor descriptor) {
 //        List<AnnotationElement> annotations = descriptor.getAnnotationElements();
 //        for (AnnotationElement annotation : annotations) System.err.println(">>> ANNOTATION " + annotation.getTypeName() + " - " + annotation.getValues());
 //        System.err.println(">>> ContentType " + descriptor.getContentType());
@@ -232,7 +232,7 @@ Format createFormat(ValueDescriptor descriptor, A annotation) {
             return null;
         }
 
-        Comparable createValue(JFRJDK11Event event, ValueDescriptor descriptor, A annotation) throws JFRPropertyNotAvailableException {
+        Comparable<?> createValue(JFRJDK11Event event, ValueDescriptor descriptor, A annotation) throws JFRPropertyNotAvailableException {
             Object value = event.getValue(descriptor.getName());
             return value instanceof Comparable ? (Comparable)value :
                    value != null ? value.toString() : null;
@@ -258,7 +258,7 @@ Format createFormat(ValueDescriptor descriptor, Timestamp annotation) {
         }
 
         @Override
-        Comparable createValue(JFRJDK11Event event, ValueDescriptor descriptor, Timestamp annotation) throws JFRPropertyNotAvailableException {
+        Comparable<?> createValue(JFRJDK11Event event, ValueDescriptor descriptor, Timestamp annotation) throws JFRPropertyNotAvailableException {
             return event.getInstant(descriptor.getName());
         }
 
@@ -290,7 +290,7 @@ Format createFormat(ValueDescriptor descriptor, Timespan annotation) {
         }
 
         @Override
-        Comparable createValue(JFRJDK11Event event, ValueDescriptor descriptor, Timespan annotation) throws JFRPropertyNotAvailableException {
+        Comparable<?> createValue(JFRJDK11Event event, ValueDescriptor descriptor, Timespan annotation) throws JFRPropertyNotAvailableException {
             return event.getDuration(descriptor.getName());
         }
 
@@ -470,7 +470,7 @@ Format createFormat() {
             return null;
         }
 
-        Comparable createValue(JFRJDK11Event event, ValueDescriptor descriptor) throws JFRPropertyNotAvailableException {
+        Comparable<?> createValue(JFRJDK11Event event, ValueDescriptor descriptor) throws JFRPropertyNotAvailableException {
             Object value = event.getValue(descriptor.getName());
             return value instanceof Comparable ? (Comparable)value :
                    value == null ? "" : value.toString();
@@ -535,12 +535,12 @@ String createValue(JFRJDK11Event event, ValueDescriptor descriptor) throws JFRPr
 
     private static class DefaultProcessor {
 
-        Comparable createValue(JFRJDK11Event event, ValueDescriptor descriptor) throws JFRPropertyNotAvailableException {
+        Comparable<?> createValue(JFRJDK11Event event, ValueDescriptor descriptor) throws JFRPropertyNotAvailableException {
             Object value = event.getValue(descriptor.getName());
 
             if (value == null) return null;
 
-            if (value instanceof Comparable) return (Comparable)value;
+            if (value instanceof Comparable) return (Comparable<?>)value;
 
             return value.toString(); // Also includes RecordedObject which needs to be handled separately!
         }

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/JFRJDK11Event.java

@@ -99,8 +99,8 @@ public Object getValue(String key) throws JFRPropertyNotAvailableException {
 
 
     @Override
-    public List<Comparable> getDisplayableValues(boolean includeExperimental) {
-        List<Comparable> values = new ArrayList();
+    public List<Comparable<?>> getDisplayableValues(boolean includeExperimental) {
+        List<Comparable<?>> values = new ArrayList<>();
         Iterator<ValueDescriptor> descriptors = DisplayableSupport.displayableValueDescriptors(event.getEventType(), includeExperimental);
         while (descriptors.hasNext()) values.add(DisplayableSupport.getDisplayValue(this, descriptors.next()));
         return values;

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/JFRJDK11EventType.java

@@ -81,7 +81,7 @@ public boolean isExperimental() {
 
     @Override
     public List<JFRDataDescriptor> getDisplayableDataDescriptors(boolean includeExperimental) {
-        List<JFRDataDescriptor> ddescriptors = new ArrayList();
+        List<JFRDataDescriptor> ddescriptors = new ArrayList<>();
         Iterator<ValueDescriptor> vdescriptors = DisplayableSupport.displayableValueDescriptors(type, includeExperimental);
         while (vdescriptors.hasNext()) ddescriptors.add(DisplayableSupport.getDataDescriptor(vdescriptors.next()));
         return ddescriptors;

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/JFRJDK11Model.java

@@ -75,7 +75,7 @@ public void visitEvents(JFREventVisitor... visitors) {
 
         // Notify visitors that are not done 'visit'
         try (RecordingFile events = new RecordingFile(snapshotFile.toPath())) {
-            List<JFREventVisitor> _visitors = new ArrayList(Arrays.asList(visitors));
+            List<JFREventVisitor> _visitors = new ArrayList<>(Arrays.asList(visitors));
             long id = 0;
             while (!_visitors.isEmpty() && events.hasMoreEvents()) {
                 RecordedEvent revent = events.readEvent();
@@ -103,7 +103,7 @@ public void visitEventTypes(JFREventTypeVisitor... visitors) {
         // Notify visitors that are not done 'visit'
         try (RecordingFile events = new RecordingFile(snapshotFile.toPath())) {
             Iterator<EventType> types = events.readEventTypes().iterator();
-            List<JFREventTypeVisitor> _visitors = new ArrayList(Arrays.asList(visitors));
+            List<JFREventTypeVisitor> _visitors = new ArrayList<>(Arrays.asList(visitors));
             while (!_visitors.isEmpty() && types.hasNext()) {
                 EventType etype = types.next();
                 String typeId = getTypeId(etype);

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/JFRJDK11StackTrace.java

@@ -48,7 +48,7 @@ final class JFRJDK11StackTrace extends JFRStackTrace {
     @Override
     public List<JFRStackFrame> getFrames() {
         List<RecordedFrame> recordedFrames = stackTrace.getFrames();
-        List<JFRStackFrame> frames = new ArrayList(recordedFrames.size());
+        List<JFRStackFrame> frames = new ArrayList<>(recordedFrames.size());
 
         for (RecordedFrame recordedFrame : recordedFrames)
             frames.add(new JFRJDK11StackFrame(recordedFrame));

visualvm/jfr/src/org/graalvm/visualvm/jfr/model/JFREvent.java

@@ -118,6 +118,6 @@ public String getString(String key) throws JFRPropertyNotAvailableException {
     public abstract Object getValue(String key) throws JFRPropertyNotAvailableException;
 
 
-    public abstract List<Comparable> getDisplayableValues(boolean includeExperimental);
+    public abstract List<Comparable<?>> getDisplayableValues(boolean includeExperimental);
 
 }