Skip to content

Commit 53de8ce

Browse files
committed
Fixed displaying red/green bars in diff results (JDBC live results)
1 parent 1aae26f commit 53de8ce

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/jdbc/JDBCTreeTableView.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,10 @@ ExportUtils.ExportProvider[] getExportProviders() {
211211

212212
private HideableBarRenderer[] renderers;
213213

214+
HideableBarRenderer.BarDiffMode barDiffMode() {
215+
return HideableBarRenderer.BarDiffMode.MODE_BAR_DIFF;
216+
}
217+
214218
private void initUI() {
215219
treeTableModel = new JDBCTreeTableModel(PrestimeCPUCCTNode.EMPTY);
216220

@@ -245,8 +249,12 @@ protected void popupHidden() {
245249
treeTable.setDefaultSortOrder(1, SortOrder.DESCENDING);
246250

247251
renderers = new HideableBarRenderer[2];
252+
253+
HideableBarRenderer.BarDiffMode barDiffMode = barDiffMode();
248254
renderers[0] = new HideableBarRenderer(new NumberPercentRenderer(new McsTimeRenderer()));
255+
renderers[0].setBarDiffMode(barDiffMode);
249256
renderers[1] = new HideableBarRenderer(new NumberRenderer());
257+
renderers[1].setBarDiffMode(barDiffMode);
250258

251259
long refTime = 123456;
252260
renderers[0].setMaxValue(refTime);

visualvm/libs.profiler/lib.profiler.ui/src/org/graalvm/visualvm/lib/ui/jdbc/LiveJDBCView.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@
6868
import org.graalvm.visualvm.lib.ui.swing.ProfilerTreeTable;
6969
import org.graalvm.visualvm.lib.ui.swing.SearchUtils;
7070
import org.graalvm.visualvm.lib.jfluid.utils.Wildcards;
71+
import org.graalvm.visualvm.lib.ui.swing.renderer.HideableBarRenderer;
7172

7273
/**
7374
*
@@ -238,6 +239,7 @@ protected void populatePopup(JPopupMenu popup, Object value, ClientUtils.SourceC
238239
protected void popupShowing() { LiveJDBCView.this.popupShowing(); }
239240
protected void popupHidden() { LiveJDBCView.this.popupHidden(); }
240241
protected boolean hasBottomFilterFindMargin() { return true; }
242+
HideableBarRenderer.BarDiffMode barDiffMode() { return HideableBarRenderer.BarDiffMode.MODE_BAR_NORMAL; }
241243
};
242244
jdbcCallsView.notifyOnFocus(new Runnable() {
243245
public void run() { lastFocused = jdbcCallsView; }

0 commit comments

Comments
 (0)