use for-each loop

Author: thurka

visualvm/application/src/org/graalvm/visualvm/application/type/MainClassApplicationTypeFactory.java

@@ -143,9 +143,7 @@ private static String descr(String key) {
 
     protected MainClassApplicationTypeFactory() {
         map = new HashMap<>();
-        for (int i = 0; i < appmatrix.length; i++) {
-            String[] appDesc = appmatrix[i];
-            
+        for (String[] appDesc : appmatrix) {
             map.put(appDesc[CLASS_NAME],appDesc);
         }
     }

visualvm/application/src/org/graalvm/visualvm/application/type/NetBeansApplicationType.java

@@ -80,9 +80,7 @@ public String getName() {
      * {@inheritDoc}
      */
     public String getVersion() {
-        Iterator<String> clIt = getClusters().iterator();
-        while(clIt.hasNext()) {
-            String cluster = clIt.next();
+        for (String cluster : getClusters()) {
             if (cluster.startsWith(NB_CLUSTER)) {
                 String ver = cluster.substring(NB_CLUSTER.length());
 

visualvm/applicationviews/src/org/graalvm/visualvm/application/views/threads/ThreadMXBeanDataManager.java

@@ -191,8 +191,7 @@ private void fillInThreadData() {
                 }
             }
             // set remaining threads as terminated
-            for (Iterator<Long> it = threadIdSet.iterator(); it.hasNext();) {
-                Long elem = it.next();
+            for (Long elem : threadIdSet) {
                 tids[nThreads] = elem.intValue();
                 states[nThreads] = CommonConstants.THREAD_STATUS_ZOMBIE;
                 nThreads++;

visualvm/core/src/org/graalvm/visualvm/core/datasource/Storage.java

@@ -194,8 +194,9 @@ public void clearCustomProperty(String key) {
     public synchronized void clearCustomProperties(String[] keys) {
         Properties prop = getCustomProperties(false);
         if (prop != null)
-            for (int i = 0; i < keys.length; i++)
-                prop.remove(keys[i]);
+            for (String key : keys) {
+                prop.remove(key);
+            }
         storeCustomProperties(); // NOTE: this could be done lazily if storeCustomProperties() was public
     }
 

visualvm/core/src/org/graalvm/visualvm/core/datasupport/Utils.java

@@ -326,7 +326,9 @@ public static boolean delete(File file, boolean deleteOnExit) {
 
         if (file.isDirectory()) {
             File[] files = file.listFiles();
-            for (int i = 0; i < files.length; i++) delete(files[i], deleteOnExit);
+            for (File file1 : files) {
+                delete(file1, deleteOnExit);
+            }
         }
 
         if (!file.delete()) {

visualvm/heapviewer.console/src/org/graalvm/visualvm/heapviewer/console/r/RQueries.java

@@ -327,9 +327,7 @@ protected void fireActionPerformed(ActionEvent e) {
                     SwingUtilities.invokeLater(new Runnable() {
                         public void run() {
                             List<Query> l = customQueries.list();
-                            Iterator<Query> i = l.iterator();
-                            while (i.hasNext()) {
-                                Query q = i.next();
+                            for (Query q : l) {
                                 if (sameQuery(query, q)) {
                                     Query qq = RQueryCustomizer.editCustomizer(query, ""); // NOI18N
                                     if (qq == null) return;

visualvm/heapviewer/src/org/graalvm/visualvm/heapviewer/java/impl/JavaDiffDumpSelector.java

@@ -180,9 +180,9 @@ void populateSnapshotsList() {
             FileObject[] snapshotsOnDisk = listSavedHeapdumps(heapdumpDir);
             FileObject snapshotFile = (heapdumpFile != null) ? FileUtil.toFileObject(heapdumpFile) : null;
 
-            for (int i = 0; i < snapshotsOnDisk.length; i++) {
-                if (((snapshotFile == null) || !snapshotsOnDisk[i].equals(snapshotFile))) {
-                    listModel.addElement(snapshotsOnDisk[i]);
+            for (FileObject snapshotsOnDisk1 : snapshotsOnDisk) {
+                if ((snapshotFile == null) || !snapshotsOnDisk1.equals(snapshotFile)) {
+                    listModel.addElement(snapshotsOnDisk1);
                 }
             }
 
@@ -634,10 +634,10 @@ static FileObject[] listSavedHeapdumps(File directory) {
 
             ArrayList /*<FileObject>*/ files = new ArrayList /*<FileObject>*/();
 
-            for (int i = 0; i < children.length; i++) {
-                FileObject child = children[i];
-                if (checkHprofFile(FileUtil.toFile(children[i])))
+            for (FileObject child : children) {
+                if (checkHprofFile(FileUtil.toFile(child))) {
                     files.add(child);
+                }
             }
 
             Collections.sort(files,

visualvm/host/src/org/graalvm/visualvm/host/impl/HostProvider.java

@@ -164,9 +164,7 @@ public void run() {
                         Set<Host> remoteHostsSet = remoteHosts.getDataSources(Host.class);
                         if (!createOnly && remoteHostsSet.contains(newHost)) {
                             storage.deleteCustomPropertiesStorage();
-                            Iterator<Host> existingHosts = remoteHostsSet.iterator();
-                            while (existingHosts.hasNext()) {
-                                Host existingHost = existingHosts.next();
+                            for (Host existingHost : remoteHostsSet) {
                                 if (existingHost.equals(newHost)) {
                                     newHost = existingHost;
                                     break;

visualvm/libs.profiler/lib.profiler.charts/src/org/graalvm/visualvm/lib/charts/PaintersModel.java

@@ -105,8 +105,9 @@ public void addPainters(ChartItem[] addedItems, ItemPainter[] addedPainters) {
         }
 
         public void removePainters(ChartItem[] removedItems) {
-            for (int i = 0; i < removedItems.length; i++)
-                painters.remove(removedItems[i]);
+            for (ChartItem removedItem : removedItems) {
+                painters.remove(removedItem);
+            }
         }
 
 

visualvm/libs.profiler/lib.profiler.charts/src/org/graalvm/visualvm/lib/charts/xy/synchronous/SynchronousXYItemsModel.java

@@ -64,9 +64,9 @@ public SynchronousXYItemsModel(Timeline timeline, SynchronousXYItem[] items) {
     // --- Public interface ----------------------------------------------------
 
     public void addItems(SynchronousXYItem[] addedItems) {
-        for (int i = 0; i < addedItems.length; i++) {
-            addedItems[i].setTimeline(timeline);
-            items.add(addedItems[i]);
+        for (SynchronousXYItem addedItem : addedItems) {
+            addedItem.setTimeline(timeline);
+            items.add(addedItem);
         }
 
         fireItemsAdded(Arrays.asList((ChartItem[])addedItems));