code simplification

Author: thurka

visualvm/host/src/org/graalvm/visualvm/host/impl/HostCustomizer.java

@@ -170,8 +170,7 @@ public void run() {
         displaynameField.setEnabled(displaynameCheckbox.isSelected());
 
         boolean hostValid = !hostname.isEmpty() && !displayname.isEmpty();
-        boolean settingsValid = settingsPanel == null ? true :
-                                settingsPanel.settingsValid();
+        boolean settingsValid = settingsPanel == null || settingsPanel.settingsValid();
 
         okButton.setEnabled(hostValid && settingsValid);
       }

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericClass.java

@@ -54,7 +54,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericClass ? type.equals(((JFRGenericClass)o).type) : false;
+        return o instanceof JFRGenericClass && type.equals(((JFRGenericClass) o).type);
     }
 
 }

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericEvent.java

@@ -277,7 +277,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericEvent ? item.equals(((JFRGenericEvent)o).item) : false;
+        return o instanceof JFRGenericEvent && item.equals(((JFRGenericEvent) o).item);
     }
 
 

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericEventType.java

@@ -105,7 +105,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericEventType ? type.equals(((JFRGenericEventType)o).type) : false;
+        return o instanceof JFRGenericEventType && type.equals(((JFRGenericEventType) o).type);
     }
 
 }

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericMethod.java

@@ -67,7 +67,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericMethod ? method.equals(((JFRGenericMethod)o).method) : false;
+        return o instanceof JFRGenericMethod && method.equals(((JFRGenericMethod) o).method);
     }
 
 }

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericStackFrame.java

@@ -76,7 +76,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericStackFrame ? stackFrame.equals(((JFRGenericStackFrame)o).stackFrame) : false;
+        return o instanceof JFRGenericStackFrame && stackFrame.equals(((JFRGenericStackFrame) o).stackFrame);
     }
 
 }

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericStackTrace.java

@@ -69,7 +69,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericStackTrace ? stackTrace.equals(((JFRGenericStackTrace)o).stackTrace) : false;
+        return o instanceof JFRGenericStackTrace && stackTrace.equals(((JFRGenericStackTrace) o).stackTrace);
     }
 
 }

visualvm/jfr.generic/src/org/graalvm/visualvm/jfr/generic/model/impl/JFRGenericThread.java

@@ -61,7 +61,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRGenericThread ? thread.equals(((JFRGenericThread)o).thread) : false;
+        return o instanceof JFRGenericThread && thread.equals(((JFRGenericThread) o).thread);
     }
 
 }

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/DisplayableSupport.java

@@ -79,9 +79,8 @@ final class DisplayableSupport {
         new RecordedClassLoaderProcessor()
     };
 
-    private static final Set<String> PRIMITIVE_NUMERIC = new HashSet<>(Arrays.asList(new String[] {
-        "byte", "short", "int", "long", "char", "float", "double" // char?
-    }));
+    private static final Set<String> PRIMITIVE_NUMERIC = new HashSet<>(Arrays.asList("byte", "short", "int", "long", "char", "float", "double" // char?
+    ));
 
 
     static Iterator<ValueDescriptor> displayableValueDescriptors(final EventType type, final boolean includeExperimental) {

visualvm/jfr.jdk11/src/org/graalvm/visualvm/jfr/jdk11/model/impl/JFRJDK11Class.java

@@ -54,7 +54,7 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object o) {
-        return o instanceof JFRJDK11Class ? rclass.equals(((JFRJDK11Class)o).rclass) : false;
+        return o instanceof JFRJDK11Class && rclass.equals(((JFRJDK11Class) o).rclass);
     }
 
 }