Portability Flaw: Locale Dependent Comparison - Fortify

Author: jisedlac

visualvm/charts/src/com/sun/tools/visualvm/charts/xy/XYPainter.java

@@ -32,6 +32,7 @@
 import java.awt.Polygon;
 import java.awt.Rectangle;
 import java.util.List;
+import java.util.Locale;
 import org.netbeans.lib.profiler.charts.ChartContext;
 import org.netbeans.lib.profiler.charts.ChartItem;
 import org.netbeans.lib.profiler.charts.swing.LongRect;
@@ -57,7 +58,7 @@ public class XYPainter extends SynchronousXYItemPainter {
     // --- Initializer ---------------------------------------------------------
 
     {
-        String _mode = System.getProperty("visualvm.charts.defaultMode", "minmax").toLowerCase(); // NOI18N
+        String _mode = System.getProperty("visualvm.charts.defaultMode", "minmax").toLowerCase(Locale.ENGLISH); // NOI18N
         if ("fast".equals(_mode)) { // NOI18N
             mode = 0;
         } else {

visualvm/heapviewer/src/com/sun/tools/visualvm/heapviewer/oql/OQLQueries.java

@@ -37,6 +37,7 @@
 import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.Locale;
 import javax.swing.BorderFactory;
 import javax.swing.Icon;
 import javax.swing.JComponent;
@@ -292,7 +293,7 @@ private void loadFromFile(final Handler handler) {
         chooser.setFileFilter(new FileFilter() {
             public boolean accept(File f) {
                 if (f.isDirectory()) return true;
-                String fname = f.getName().toLowerCase();
+                String fname = f.getName().toLowerCase(Locale.ENGLISH);
                 if (fname.endsWith(".oql") || fname.endsWith(".txt")) return true; // NOI18N
                 return false;
             }
@@ -367,7 +368,7 @@ private void saveToFile(OQLSupport.Query query, final String queryText, final Ha
         chooser.setFileFilter(new FileFilter() {
             public boolean accept(File f) {
                 if (f.isDirectory()) return true;
-                String fname = f.getName().toLowerCase();
+                String fname = f.getName().toLowerCase(Locale.ENGLISH);
                 if (fname.endsWith(".oql") || fname.endsWith(".txt")) return true; // NOI18N
                 return false;
             }
@@ -380,7 +381,7 @@ public String getDescription() {
             File file = chooser.getSelectedFile();
             lastDirectory = file.getParentFile();
 
-            String fname = file.getName().toLowerCase();
+            String fname = file.getName().toLowerCase(Locale.ENGLISH);
             if (!fname.endsWith(".oql") && !fname.endsWith(".txt")) // NOI18N
                 file = new File(file.getParentFile(), file.getName() + ".oql"); // NOI18N
             final File fileF = file;