Skip to content

Commit 7a17d02

Browse files
committed
distinguish unknown/unresolved strings by its ID
1 parent 0fa6a00 commit 7a17d02

File tree

1 file changed

+6
-5
lines changed
  • visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/heap

1 file changed

+6
-5
lines changed

visualvm/libs.profiler/lib.profiler/src/org/graalvm/visualvm/lib/jfluid/heap/StringSegment.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,16 +71,17 @@ String getStringByID(long stringID) {
7171
}
7272

7373
private String createStringByID(long stringID) {
74-
return getString(getStringOffsetByID(stringID));
74+
long start = getStringOffsetByID(stringID);
75+
76+
if (start == -1) {
77+
return "<unresolved string 0x"+Long.toHexString(stringID)+">"; // NOI18N
78+
}
79+
return getString(start);
7580
}
7681

7782
private String getString(long start) {
7883
HprofByteBuffer dumpBuffer = getDumpBuffer();
7984

80-
if (start == -1) {
81-
return "<unknown string>"; // NOI18N
82-
}
83-
8485
int len = dumpBuffer.getInt(start + lengthOffset);
8586
byte[] chars = new byte[len - dumpBuffer.getIDSize()];
8687
dumpBuffer.get(start + UTF8CharsOffset, chars);

0 commit comments

Comments
 (0)