engine options can be changed without reopening of the monitored application

Author: thurka

visualvm/sampler.truffle/src/org/graalvm/visualvm/sampler/truffle/SamplerImpl.java

@@ -80,6 +80,7 @@
 import javax.swing.JToggleButton;
 import javax.swing.SwingUtilities;
 import org.graalvm.visualvm.core.VisualVM;
+import org.graalvm.visualvm.lib.common.ProfilingSettings;
 import org.graalvm.visualvm.lib.common.ProfilingSettingsPresets;
 import org.graalvm.visualvm.lib.jfluid.results.cpu.CPUResultsSnapshot;
 import org.graalvm.visualvm.lib.jfluid.results.memory.SampledMemoryResultsSnapshot;
@@ -562,6 +563,12 @@ public void takeThreadDump(boolean openView) {
                     };
 
                 cpuSampler = new CPUSamplerSupport(application, ti, snapshotDumper, threadDumper) {
+                    @Override
+                    public boolean startSampling(ProfilingSettings settings, int samplingRate, int refreshRate) {
+                        setOptions(cpuSettings.getMode(), cpuSettings.isSplitCompiledInlined());
+                        return super.startSampling(settings, samplingRate, refreshRate);
+                    }
+
                     protected Timer getTimer() { return SamplerImpl.this.getTimer(); }
                 };
                 SwingUtilities.invokeLater(new Runnable() {

visualvm/sampler.truffle/src/org/graalvm/visualvm/sampler/truffle/cpu/Bundle.properties

@@ -54,7 +54,7 @@ MSG_unavailable_threads=Not available. Cannot access truffle JMX in target appli
 
 MSG_unavailable_stacktraces=Not available. StackTraces instrument is not available. Please start your application with --stacktraces commandline option.
 
-SEP_EngineSettings=Engine settings (reopen required)
+SEP_EngineSettings=Engine settings
 
 LBL_Mode=Mode\:
 

visualvm/sampler.truffle/src/org/graalvm/visualvm/sampler/truffle/cpu/CPUSamplerSupport.java

@@ -116,6 +116,10 @@ public DataViewComponent.DetailsView[] getDetailsView() {
         return detailsViews.clone();
     }
 
+    public void setOptions(String mode, boolean trackFlags) {
+        threadInfoProvider.setOptions(mode, trackFlags);
+    }
+
     public boolean startSampling(ProfilingSettings settings, int samplingRate, int refreshRate) {
         GenericFilter sf = settings.getInstrumentationFilter();
         InstrumentationFilter filter = new InstrumentationFilter(sf);

visualvm/sampler.truffle/src/org/graalvm/visualvm/sampler/truffle/cpu/CPUSettingsSupport.java

@@ -60,8 +60,8 @@ public abstract class CPUSettingsSupport {
     private static final String PROP_SPLIT_COMPILED_INLINED = "CPUSettingsSupport.SplitCompiledInlined"; // NOI18N
 
     private static enum Mode {
-        ROOTS { @Override public String toString() { return NbBundle.getMessage(CPUSettingsSupport.class, "MODE_ROOTS"); } }, // NOI18N
         EXCLUDE_INLINED_ROOTS { @Override public String toString() { return NbBundle.getMessage(CPUSettingsSupport.class, "MODE_EXCLUDE_INLINED_ROOTS"); } }, // NOI18N
+        ROOTS { @Override public String toString() { return NbBundle.getMessage(CPUSettingsSupport.class, "MODE_ROOTS"); } }, // NOI18N
         STATEMENTS { @Override public String toString() { return NbBundle.getMessage(CPUSettingsSupport.class, "MODE_STATEMENTS"); } }, // NOI18N
     };
 

visualvm/sampler.truffle/src/org/graalvm/visualvm/sampler/truffle/cpu/ThreadInfoProvider.java

@@ -148,6 +148,15 @@ boolean loadAgent(Application app) {
         return false;
     }
 
+    void setOptions(String mode, boolean trackFlags) {
+        try {
+            tbean.setMode(mode);
+            tbean.setTrackFlags(trackFlags);
+        } catch (Exception ex) {
+            LOGGER.log(Level.INFO, "threadBean.setMode(), setTrackFlags()", ex); // NOI18N
+        }
+    }
+
     private static void loadAgentIntoTargetJVM(final VirtualMachine virtualMachine, final String jar, final String options)
                                             throws IOException, AgentLoadException, AgentInitializationException  {
         try {