Support external sources viewer command with quoted spaces, improved tooltip wording in Add Source Root dialog

Author: jisedlac

plugins/sources/src/org/graalvm/visualvm/sources/options/SourcesOptionsPanel.java

@@ -114,7 +114,7 @@
     "SourcesOptionsPanel_SubdirectoriesChoice=S&ubdirectories:",                // NOI18N
     "SourcesOptionsPanel_SubdirectoriesToolTip=Sources are in the selected subdirectories of the source root(s)", // NOI18N
     "SourcesOptionsPanel_CustomSubpathsChoice=&Custom subpaths:",               // NOI18N
-    "SourcesOptionsPanel_CustomSubpathsToolTip=Sources are in the defined subdirectories of the source root(s) - no wildcards allowed", // NOI18N
+    "SourcesOptionsPanel_CustomSubpathsToolTip=Sources are in the defined subpaths of the source root(s) - no wildcards allowed", // NOI18N
     "SourcesOptionsPanel_SourcesEncoding=Sources Encoding:"                     // NOI18N
 })
 final class SourcesOptionsPanel extends JPanel {

plugins/sources/src/org/graalvm/visualvm/sources/viewer/ExternalViewerLauncher.java

@@ -27,14 +27,18 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.StringTokenizer;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
 import org.graalvm.visualvm.core.datasource.Storage;
 
 /**
  * @author Jiri Sedlacek
  */
 class ExternalViewerLauncher implements Runnable {
 
+    private static final String COMMAND_STRINGS_REGEX = "\"[^\"]*\"|\\S+";      // NOI18N
+    
+    
     private final String command;
 
 
@@ -57,9 +61,12 @@ protected void failed(IOException e) {}
 
 
     public static List<String> getCommandStrings(String commandString) {
-        StringTokenizer tokenizer = new StringTokenizer(commandString);
         List<String> command = new ArrayList();
-        while (tokenizer.hasMoreTokens()) command.add(tokenizer.nextToken());
+        
+        Pattern pattern = Pattern.compile(COMMAND_STRINGS_REGEX);
+        Matcher matcher = pattern.matcher(commandString);
+        while (matcher.find()) command.add(matcher.group());
+        
         return command;
     }