Skip to content

Commit 8ce9bdf

Browse files
committed
HG-74 - do not use importPackage()
(cherry picked from commit d6a8788)
1 parent b2650ef commit 8ce9bdf

File tree

2 files changed

+39
-4
lines changed

2 files changed

+39
-4
lines changed

plugins/tracerjavafx/manifest.mf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@ OpenIDE-Module: com.sun.tools.visualvm.modules.tracer.javafx
33
OpenIDE-Module-Layer: com/sun/tools/visualvm/modules/tracer/javafx/layer.xml
44
OpenIDE-Module-Localizing-Bundle: com/sun/tools/visualvm/modules/tracer/javafx/Bundle.properties
55
OpenIDE-Module-Requires: net.java.btrace.visualvm.tracer.deployer
6-
OpenIDE-Module-Specification-Version: 1.0.4
6+
OpenIDE-Module-Specification-Version: 1.0.5
77

plugins/tracerjavafx/src/com/sun/tools/visualvm/modules/tracer/javafx/fx_tracer.js

Lines changed: 38 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,11 @@
2323
* questions.
2424
*/
2525

26-
importPackage(net.java.btrace.visualvm.tracer.deployer);
27-
2826
var loc = new L11N("com.sun.tools.visualvm.modules.tracer.javafx")
2927

3028
var scriptPath = "nbres:/com/sun/tools/visualvm/modules/tracer/javafx/resources/JavaFXTracer.probe"
31-
var btraceDeployer = BTraceDeployer.instance()
29+
var btraceDeployer = typeof(Packages.net.java.btrace.visualvm.tracer.deployer.BTraceDeployer) == "function" ?
30+
Packages.net.java.btrace.visualvm.tracer.deployer.BTraceDeployer.instance() : undefined;
3231

3332
VisualVM.Tracer.addPackages({
3433
// JavaFX Metrics package
@@ -46,6 +45,10 @@ VisualVM.Tracer.addPackages({
4645
// FX Metrics
4746
name: loc.message("VisualVM/Tracer/packages/jfx/probes/metrics"),
4847
desc: "Monitors Invalidation Rate and Replacement Rate",
48+
reqs: "Requires BTrace Deployer plugin.",
49+
validator: function() {
50+
return btraceDeployer != undefined;
51+
},
4952
deployment: {
5053
deployer: btraceDeployer,
5154
fragment: "metrics",
@@ -70,6 +73,10 @@ VisualVM.Tracer.addPackages({
7073
// FX Objects
7174
name: loc.message("VisualVM/Tracer/packages/jfx/probes/objects"),
7275
desc: "Monitors Overall Rate and Hot Class Rate",
76+
reqs: "Requires BTrace Deployer plugin.",
77+
validator: function() {
78+
return btraceDeployer != undefined;
79+
},
7380
deployment: {
7481
deployer: btraceDeployer,
7582
fragment: "objects",
@@ -88,6 +95,10 @@ VisualVM.Tracer.addPackages({
8895
// Average FPS
8996
name: loc.message("VisualVM/Tracer/packages/jfx/probes/fps"),
9097
desc: "Monitors average frame per second rate",
98+
reqs: "Requires BTrace Deployer plugin.",
99+
validator: function() {
100+
return btraceDeployer != undefined;
101+
},
91102
deployment: {
92103
deployer: btraceDeployer,
93104
fragment: "fps",
@@ -106,6 +117,10 @@ VisualVM.Tracer.addPackages({
106117
// Scenegraph mouse and key statistics
107118
name: loc.message("VisualVM/Tracer/packages/jfx/probes/pulseCount"),
108119
desc: "Monitors mouse and keyboard activity",
120+
reqs: "Requires BTrace Deployer plugin.",
121+
validator: function() {
122+
return btraceDeployer != undefined;
123+
},
109124
deployment: {
110125
deployer: btraceDeployer,
111126
fragment: "pulseCount",
@@ -130,6 +145,10 @@ VisualVM.Tracer.addPackages({
130145
// Scenegraph mouse and key event timing
131146
name: loc.message("VisualVM/Tracer/packages/jfx/probes/pulseTiming"),
132147
desc: "Monitors mouse and keyboard event timing",
148+
reqs: "Requires BTrace Deployer plugin.",
149+
validator: function() {
150+
return btraceDeployer != undefined;
151+
},
133152
deployment: {
134153
deployer: btraceDeployer,
135154
fragment: "pulseTiming",
@@ -154,6 +173,10 @@ VisualVM.Tracer.addPackages({
154173
// Scenegraph timing monitoring
155174
name: loc.message("VisualVM/Tracer/packages/jfx/probes/sgTiming"),
156175
desc: "Monitors scenegraph timing",
176+
reqs: "Requires BTrace Deployer plugin.",
177+
validator: function() {
178+
return btraceDeployer != undefined;
179+
},
157180
deployment: {
158181
deployer: btraceDeployer,
159182
fragment: "sgTiming",
@@ -184,6 +207,10 @@ VisualVM.Tracer.addPackages({
184207
// Scenegraph nodes statistics
185208
name: loc.message("VisualVM/Tracer/packages/jfx/probes/sgNode"),
186209
desc: "Scenegraph nodes statistic",
210+
reqs: "Requires BTrace Deployer plugin.",
211+
validator: function() {
212+
return btraceDeployer != undefined;
213+
},
187214
deployment: {
188215
deployer: btraceDeployer,
189216
fragment: "sgNode",
@@ -208,6 +235,10 @@ VisualVM.Tracer.addPackages({
208235
// Scenegraph CSS statistics
209236
name: loc.message("VisualVM/Tracer/packages/jfx/probes/sgCss"),
210237
desc: "Scenegraph CSS statistic",
238+
reqs: "Requires BTrace Deployer plugin.",
239+
validator: function() {
240+
return btraceDeployer != undefined;
241+
},
211242
deployment: {
212243
deployer: btraceDeployer,
213244
fragment: "sgCss",
@@ -244,6 +275,10 @@ VisualVM.Tracer.addPackages({
244275
// Synchronization calls
245276
name: loc.message("VisualVM/Tracer/packages/jfx/probes/synCalls"),
246277
desc: "Monitors amount of synchronization calls",
278+
reqs: "Requires BTrace Deployer plugin.",
279+
validator: function() {
280+
return btraceDeployer != undefined;
281+
},
247282
deployment: {
248283
deployer: btraceDeployer,
249284
fragment: "synCalls",

0 commit comments

Comments
 (0)