Skip to content

Commit 8f93990

Browse files
committed
CPU Sampler improvements
- Copy context menu action - improved Thread renderer - improved texts in UI
1 parent 9117135 commit 8f93990

File tree

2 files changed

+15
-5
lines changed

2 files changed

+15
-5
lines changed

visualvm/sampler/src/com/sun/tools/visualvm/sampler/cpu/Bundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ MSG_unavailable_threads=Not available. Cannot access threads in target applicati
5454

5555
LBL_ThreadAlloc=Thread CPU time
5656

57-
COL_Thread_name=Thread Name
57+
COL_Thread_name=Name
5858

5959
COL_ABytes=Thread Time (CPU)
6060

visualvm/sampler/src/com/sun/tools/visualvm/sampler/cpu/ThreadsCPUView.java

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import java.awt.Component;
3131
import java.awt.Container;
3232
import java.awt.Dimension;
33+
import java.awt.Font;
3334
import java.awt.LayoutManager;
3435
import java.awt.Toolkit;
3536
import java.awt.event.ActionEvent;
@@ -58,7 +59,7 @@
5859
import org.netbeans.lib.profiler.ui.swing.ProfilerTableContainer;
5960
import org.netbeans.lib.profiler.ui.swing.SearchUtils;
6061
import org.netbeans.lib.profiler.ui.swing.renderer.HideableBarRenderer;
61-
import org.netbeans.lib.profiler.ui.swing.renderer.JavaNameRenderer;
62+
import org.netbeans.lib.profiler.ui.swing.renderer.LabelRenderer;
6263
import org.netbeans.lib.profiler.ui.swing.renderer.McsTimeRenderer;
6364
import org.netbeans.lib.profiler.ui.swing.renderer.NumberPercentRenderer;
6465
import org.netbeans.lib.profiler.ui.swing.renderer.NumberRenderer;
@@ -205,6 +206,9 @@ private void initComponents() {
205206
// return ThreadsCPUView.this.getUserValueForRow(row);
206207
// }
207208
protected void populatePopup(JPopupMenu popup, Object value, Object userValue) {
209+
popup.add(createCopyMenuItem());
210+
popup.addSeparator();
211+
208212
popup.add(new JMenuItem(FilterUtils.ACTION_FILTER) {
209213
protected void fireActionPerformed(ActionEvent e) { ThreadsCPUView.this.activateFilter(); }
210214
});
@@ -226,6 +230,8 @@ protected void popupHidden() {
226230
}
227231
};
228232

233+
table.setColumnToolTips(new String[] { "Thread name", "Total thread CPU time", "Thread CPU time in last 1 second" });
234+
229235
table.providePopupMenu(true);
230236

231237
table.setMainColumn(0);
@@ -239,7 +245,11 @@ protected void popupHidden() {
239245
renderers[0] = new HideableBarRenderer(new NumberPercentRenderer(new McsTimeRenderer()));
240246
renderers[1] = new HideableBarRenderer(new NumberPercentRenderer(new McsTimeRenderer()));
241247

242-
table.setColumnRenderer(0, new JavaNameRenderer(Icons.getIcon(ProfilerIcons.THREAD)));
248+
LabelRenderer threadRenderer = new LabelRenderer();
249+
threadRenderer.setIcon(Icons.getIcon(ProfilerIcons.THREAD));
250+
threadRenderer.setFont(threadRenderer.getFont().deriveFont(Font.BOLD));
251+
252+
table.setColumnRenderer(0, threadRenderer);
243253
table.setColumnRenderer(1, renderers[0]);
244254
table.setColumnRenderer(2, renderers[1]);
245255

@@ -305,10 +315,10 @@ protected void fireActionPerformed(ActionEvent e) {
305315
toolbar.addSeparator();
306316
toolbar.addSpace(5);
307317

308-
toolbar.add(new GrayLabel("Threads:"));
318+
toolbar.add(new GrayLabel("Statistics:"));
309319
toolbar.addSpace(5);
310320

311-
toolbar.add(new JLabel("Count:"));
321+
toolbar.add(new JLabel("Threads Count:"));
312322
final Dimension tcDim = new Dimension(-1, -1);
313323
final JLabel threadsCountL = new JLabel() {
314324
public Dimension getPreferredSize() {

0 commit comments

Comments
 (0)