Optimization in JmxHeartbeat

jisedlac · jisedlac · commit 90fa85dbbaa3 · 2020-02-11T11:19:39.000+01:00
diff --git a/visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxHeartbeat.java b/visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxHeartbeat.java
@@ -142,7 +142,7 @@ protected void pingFinished(JmxApplication... apps) {
             boolean pendingUnavailable;
 
             synchronized (unavailable) {
-                if (apps != null && apps.length > 0) unavailable.addAll(Arrays.asList(apps));
+                if (apps.length > 0) unavailable.addAll(Arrays.asList(apps));
                 cleanupUnavailableApps(unavailable);
                 pendingUnavailable = !unavailable.isEmpty();
                 heartbeatRunning = false;
@@ -179,7 +179,7 @@ protected void schedule(JmxApplication... apps) {
         
         @Override
         protected void pingFinished(JmxApplication... apps) {
-            fallback.schedule(apps);
+            if (apps.length > 0) fallback.schedule(apps);
         }
         
     }

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,7 @@ protected void pingFinished(JmxApplication... apps) {`
`142`	`142`	`boolean pendingUnavailable;`
`143`	`143`
`144`	`144`	`synchronized (unavailable) {`
`145`		`- if (apps != null && apps.length > 0) unavailable.addAll(Arrays.asList(apps));`
	`145`	`+ if (apps.length > 0) unavailable.addAll(Arrays.asList(apps));`
`146`	`146`	`cleanupUnavailableApps(unavailable);`
`147`	`147`	`pendingUnavailable = !unavailable.isEmpty();`
`148`	`148`	`heartbeatRunning = false;`
`@@ -179,7 +179,7 @@ protected void schedule(JmxApplication... apps) {`
`179`	`179`
`180`	`180`	`@Override`
`181`	`181`	`protected void pingFinished(JmxApplication... apps) {`
`182`		`- fallback.schedule(apps);`
	`182`	`+ if (apps.length > 0) fallback.schedule(apps);`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`}`