if heap dump cannot be taken via Attach API, try to use JMX

thurka · thurka · commit 949be7e15f9d · 2017-11-21T09:46:01.000+01:00
diff --git a/visualvm/jvm/src/com/sun/tools/visualvm/jvm/JVMImpl.java b/visualvm/jvm/src/com/sun/tools/visualvm/jvm/JVMImpl.java
@@ -387,7 +387,6 @@ public File takeHeapDump() throws IOException {
             if (attach.takeHeapDump(dumpFile.getAbsolutePath())) {
                 return dumpFile;
             }
-            return null;
         }
         if (getJmxModel().takeHeapDump(dumpFile.getAbsolutePath())) {
             return dumpFile;

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,6 @@ public File takeHeapDump() throws IOException {`
`387`	`387`	`if (attach.takeHeapDump(dumpFile.getAbsolutePath())) {`
`388`	`388`	`return dumpFile;`
`389`	`389`	`}`
`390`		`- return null;`
`391`	`390`	`}`
`392`	`391`	`if (getJmxModel().takeHeapDump(dumpFile.getAbsolutePath())) {`
`393`	`392`	`return dumpFile;`