Skip to content

Commit 992df98

Browse files
committed
Make sure an initialized Progress (timer started) is always finished (timer stopped) - guest languages.
1 parent 1ccc5c1 commit 992df98

File tree

3 files changed

+16
-15
lines changed

3 files changed

+16
-15
lines changed

visualvm/heapviewer.truffle/src/org/graalvm/visualvm/heapviewer/truffle/TruffleObjectMergedFields.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,9 +133,9 @@ private Set<FieldDescriptor> getAllObjectsFields(Progress progress) throws Inter
133133
Set<FieldDescriptor> allFields = new HashSet();
134134
Iterator<O> objectsI = objectsIterator();
135135

136-
progress.setupKnownSteps(objects.getObjectsCount());
137-
138136
try {
137+
progress.setupKnownSteps(objects.getObjectsCount());
138+
139139
while (objectsI.hasNext()) {
140140
progress.step();
141141

@@ -210,10 +210,10 @@ protected HeapViewerNode[] lazilyComputeChildren(Heap heap, String viewID, HeapV
210210
if (fieldType == 0) {
211211
final InstanceCounter values = new InstanceCounter(objectsCount());
212212

213-
progress.setupKnownSteps(objectsCount());
214-
215213
Iterator<O> objects = objectsIterator();
216214
try {
215+
progress.setupKnownSteps(objectsCount());
216+
217217
while (objects.hasNext()) {
218218
O o = objects.next();
219219
progress.step();
@@ -274,10 +274,10 @@ protected String getNodesContainerString(String firstNodeIdx, String lastNodeIdx
274274
} else {
275275
final Map<String, Integer> values = new HashMap();
276276

277-
progress.setupKnownSteps(objectsCount());
278-
279277
Iterator<O> objects = objectsIterator();
280278
try {
279+
progress.setupKnownSteps(objectsCount());
280+
281281
while (objects.hasNext()) {
282282
O o = objects.next();
283283
progress.step();

visualvm/heapviewer.truffle/src/org/graalvm/visualvm/heapviewer/truffle/TruffleObjectMergedReferences.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,9 @@ protected HeapViewerNode[] getNodes(HeapViewerNode parent, String viewID, HeapVi
104104

105105
Iterator<O> objectsI = objectsIterator();
106106

107-
progress.setupKnownSteps(objectsCount());
108107
try {
108+
progress.setupKnownSteps(objectsCount());
109+
109110
while (objectsI.hasNext()) {
110111
O object = objectsI.next();
111112
progress.step();

visualvm/heapviewer.truffle/src/org/graalvm/visualvm/heapviewer/truffle/TruffleObjectsProvider.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -146,9 +146,9 @@ public HeapViewerNode[] getDominators(HeapViewerNode parent, HeapContext context
146146
List<Instance> searchInstances = heap.getBiggestObjectsByRetainedSize(maxSearchInstances);
147147
Iterator<Instance> searchInstancesIt = searchInstances.iterator();
148148

149-
progress.setupKnownSteps(searchInstances.size());
150-
151149
try {
150+
progress.setupKnownSteps(searchInstances.size());
151+
152152
while (searchInstancesIt.hasNext()) {
153153
Instance instance = searchInstancesIt.next();
154154
progress.step();
@@ -189,9 +189,9 @@ protected String getNodesContainerString(String firstNodeIdx, String lastNodeIdx
189189
} else {
190190
TruffleType.TypesComputer<O, T> tcomputer = new TruffleType.TypesComputer(language, heap);
191191

192-
progress.setupKnownSteps(dominators.size());
193-
194192
try {
193+
progress.setupKnownSteps(dominators.size());
194+
195195
for (Instance dominator : dominators) {
196196
progress.step();
197197
tcomputer.addObject(language.createObject(dominator));
@@ -235,9 +235,9 @@ public HeapViewerNode[] getGCRoots(HeapViewerNode parent, HeapContext context, S
235235

236236
final List<GCRoot> gcroots = new ArrayList(heap.getGCRoots());
237237

238-
progress.setupUnknownSteps();
239-
240238
try {
239+
progress.setupUnknownSteps();
240+
241241
Iterator<GCRoot> gcrootsI = gcroots.iterator();
242242
while (gcrootsI.hasNext()) {
243243
Instance instance = gcrootsI.next().getInstance();
@@ -277,9 +277,9 @@ protected String getNodesContainerString(String firstNodeIdx, String lastNodeIdx
277277
} else {
278278
TruffleType.TypesComputer<O, T> tcomputer = new TruffleType.TypesComputer(language, heap);
279279

280-
progress.setupUnknownSteps();
281-
282280
try {
281+
progress.setupUnknownSteps();
282+
283283
for (GCRoot gcroot : gcroots) {
284284
tcomputer.addObject(language.createObject(gcroot.getInstance()));
285285
progress.step();

0 commit comments

Comments
 (0)