getCommandLine() does not work for read-only connection

thurka · thurka · commit 9de0398f750d · 2020-01-28T09:55:12.000+01:00
diff --git a/visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxModelImpl.java b/visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxModelImpl.java
@@ -309,7 +309,11 @@ public boolean isTakeThreadDumpSupported() {
     }
 
     public String getCommandLine() {
-        return getJmxSupport().getCommandLine();
+        JmxSupport support = getJmxSupport();
+        if (support.isReadOnlyConnection()) {
+            return null;
+        }
+        return support.getCommandLine();
     }
 
     private JmxSupport getJmxSupport() {

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,11 @@ public boolean isTakeThreadDumpSupported() {`
`309`	`309`	`}`
`310`	`310`
`311`	`311`	`public String getCommandLine() {`
`312`		`- return getJmxSupport().getCommandLine();`
	`312`	`+ JmxSupport support = getJmxSupport();`
	`313`	`+ if (support.isReadOnlyConnection()) {`
	`314`	`+ return null;`
	`315`	`+ }`
	`316`	`+ return support.getCommandLine();`
`313`	`317`	`}`
`314`	`318`
`315`	`319`	`private JmxSupport getJmxSupport() {`