Fixed notifications synchronization, fixed handling exceptions & added missing logging

Author: jisedlac

visualvm/core/src/org/graalvm/visualvm/core/ui/DataSourceWindow.java

@@ -38,6 +38,8 @@
 import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 import javax.swing.JPanel;
 import javax.swing.SwingUtilities;
 import org.openide.util.RequestProcessor;
@@ -53,6 +55,8 @@ class DataSourceWindow extends TopComponent implements PropertyChangeListener {
     private static final RequestProcessor PROCESSOR =
             new RequestProcessor("DataSourceWindow Processor", 5); // NOI18N
 
+    private static final Logger LOGGER = Logger.getLogger(DataSourceWindow.class.getName());
+    
     private int viewsCount = 0;
     private DataSource dataSource;
     private DataSourceDescriptor dataSourceDescriptor;
@@ -145,15 +149,18 @@ public void removeView(final DataSourceView view) {
         }
 
         PROCESSOR.post(new Runnable() {
-            public void run() { view.viewRemoved(); }
+            public void run() {
+                try { view.viewRemoved(); }
+                catch (Exception e) { LOGGER.log(Level.WARNING, "Failed notifying removed view " + view, e); } // NOI18N
+            }
         });
 
         DataSourceWindowManager.sharedInstance().unregisterClosedView(view);
         viewsCount--;
         if (viewsCount == 0 && isOpened()) close();
     }
 
-    void clearView(final DataSourceView view) {
+    void clearView(final DataSourceView view, RequestProcessor notificationProcessor) {
         if (viewsCount == 1 && Objects.equals(singleViewContainer.getName(), view.getName())) {
             singleViewContainer.removeAll();
             if (singleViewContainer.getCaption() != null) singleViewContainer.getCaption().finish();
@@ -167,8 +174,11 @@ void clearView(final DataSourceView view) {
             tabbedContainer.clearView(viewIndex);
         }
 
-        PROCESSOR.post(new Runnable() {
-            public void run() { view.viewRemoved(); }
+        notificationProcessor.post(new Runnable() {
+            public void run() {
+                try { view.viewRemoved(); }
+                catch (Exception e) { LOGGER.log(Level.WARNING, "Failed notifying removed view " + view, e); } // NOI18N
+            }
         });
     }
 
@@ -193,7 +203,10 @@ void updateView(final DataSourceView view, int index) {
         }
 
         PROCESSOR.post(new Runnable() {
-            public void run() { view.viewAdded(); }
+            public void run() {
+                try { view.viewAdded(); }
+                catch (Exception e) { LOGGER.log(Level.WARNING, "Failed post-initialize view " + view, e); } // NOI18N
+            }
         });
     }
 

visualvm/core/src/org/graalvm/visualvm/core/ui/DataSourceWindowManager.java

@@ -387,7 +387,7 @@ public void run() {
                     public void run() {
                         final Set<DataSourceView> opened = openedViews.get(dataSource);
                         for (DataSourceView view : oldViews.values()) {
-                            window.clearView(view);
+                            window.clearView(view, processor);
                             opened.remove(view);
                         }
 
@@ -396,7 +396,8 @@ public void run() {
                                 final List<? extends DataSourceView> newViews = DataSourceViewsManager.sharedInstance().getViews(dataSource);
                                 for (DataSourceView view : newViews) {
                                     opened.add(view);
-                                    view.viewWillBeAdded();
+                                    try { view.viewWillBeAdded(); }
+                                    catch (Exception e) { LOGGER.log(Level.SEVERE, "Failed to pre-initialize view " + view, e); } // NOI18N
                                     oldViews.remove(view.getName());
                                 }
                                 if (opened.isEmpty()) openedViews.remove(dataSource);