JFRSnapshotSupport.takeJfrDump() can optionally stop JFR recording

Author: thurka

visualvm/jfr/src/org/graalvm/visualvm/jfr/JFRSnapshotSupport.java

@@ -126,8 +126,8 @@ static void register() {
         jfrDumpProvider.initialize();
     }
 
-    public static void takeJfrDump(Application application, boolean openView) {
-        jfrDumpProvider.createJfrDump(application, openView);
+    public static void takeJfrDump(Application application, boolean openView, boolean stopJfr) {
+        jfrDumpProvider.createJfrDump(application, openView, stopJfr);
     }
 
     public static void takeRemoteJfrDump(Application application, String dumpFile, boolean customizeDumpFile) {

visualvm/jfr/src/org/graalvm/visualvm/jfr/impl/JFRDumpAction.java

@@ -74,7 +74,7 @@ protected void actionPerformed(Set<DataSource> dataSources, ActionEvent actionEv
                 boolean tagged = (actionEvent.getModifiers() & Toolkit.
                         getDefaultToolkit().getMenuShortcutKeyMask()) != 0;
                 if (application.isLocalApplication()) {
-                    JFRSnapshotSupport.takeJfrDump(application, !tagged);
+                    JFRSnapshotSupport.takeJfrDump(application, !tagged, false);
                 } else {
                     JFRSnapshotSupport.takeRemoteJfrDump(application, null, !tagged);
                 }

visualvm/jfr/src/org/graalvm/visualvm/jfr/impl/JFRRecordingProvider.java

@@ -137,7 +137,7 @@ public void remoteJfrStopRecording(Application application) {
         jfrStopRecording(application);
     }
 
-    public void createJfrDump(final Application application, final boolean openView) {
+    public void createJfrDump(final Application application, final boolean openView, final boolean stopJfr) {
         VisualVM.getInstance().runTask(new Runnable() {
             public void run() {
                 Jvm jvm = JvmFactory.getJVMFor(application);
@@ -168,6 +168,13 @@ public void run() {
                             if (openView) {
                                 DataSourceWindowManager.sharedInstance().openDataSource(jfrDump);
                             }
+                            if (stopJfr) {
+                                jvm.stopJfrRecording();
+                                Set<DataSource> ds = ActionUtils.getSelectedDataSources();
+                                JFRDumpAction.instance().updateState(ds);
+                                JFRStartAction.instance().updateState(ds);
+                                JFRStopAction.instance().updateState(ds);
+                            }
                         } else {
                             notifyJfrDumpFailed(application);
                         }