GH-187 try to detect tunneled JMX application

Author: thurka

visualvm/application/manifest.mf

@@ -5,5 +5,5 @@ OpenIDE-Module: org.graalvm.visualvm.application/2
 OpenIDE-Module-Layer: org/graalvm/visualvm/application/resources/layer.xml
 OpenIDE-Module-Install: org/graalvm/visualvm/application/Installer.class
 OpenIDE-Module-Localizing-Bundle: org/graalvm/visualvm/application/resources/Bundle.properties
-OpenIDE-Module-Specification-Version: 2.3
+OpenIDE-Module-Specification-Version: 2.4
 

visualvm/application/src/org/graalvm/visualvm/application/Application.java

@@ -117,7 +117,7 @@ public final Host getHost() {
      * 
      * @return true if the application is running on Host.LOCALHOST, false otherwise.
      */
-    public final boolean isLocalApplication() {
+    public boolean isLocalApplication() {
         return Host.LOCALHOST.equals(getHost());
     }
 

visualvm/jmx/nbproject/project.xml

@@ -12,7 +12,7 @@
                     <compile-dependency/>
                     <run-dependency>
                         <release-version>2</release-version>
-                        <specification-version>2.0</specification-version>
+                        <specification-version>2.4</specification-version>
                     </run-dependency>
                 </dependency>
                 <dependency>

visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxApplication.java

@@ -28,6 +28,7 @@
 import java.beans.PropertyChangeEvent;
 import java.beans.PropertyChangeListener;
 import java.io.IOException;
+import java.lang.management.ManagementFactory;
 import org.graalvm.visualvm.application.Application;
 import org.graalvm.visualvm.application.jvm.Jvm;
 import org.graalvm.visualvm.core.datasource.Storage;
@@ -41,6 +42,8 @@
 import org.graalvm.visualvm.tools.jmx.JvmMXBeans;
 import org.graalvm.visualvm.tools.jmx.JvmMXBeansFactory;
 import java.lang.management.RuntimeMXBean;
+import java.util.Map;
+import java.util.Objects;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import javax.management.remote.JMXServiceURL;
@@ -110,6 +113,37 @@ public int getPid() {
         return pid;
     }
 
+    private static final String[] HOST_PROPS = {
+        "os.arch",
+        "os.name",
+        "os.version",
+        "user.home",
+        "user.name"
+    };
+    public boolean isLocalApplication() {
+        if (super.isLocalApplication()) {
+            // try to detect tunneled application
+            if (getState() == Stateful.STATE_AVAILABLE) {
+                if (jmxModel != null && jmxModel.getConnectionState() == ConnectionState.CONNECTED) {
+                    JvmMXBeans mxbeans = JvmMXBeansFactory.getJvmMXBeans(jmxModel);
+                    if (mxbeans != null) {
+                        RuntimeMXBean rt = mxbeans.getRuntimeMXBean();
+                        if (rt != null) {
+                            Map<String, String> appProperties = rt.getSystemProperties();
+                            if (!matchProps(HOST_PROPS, appProperties)) {
+                                return false;
+                            }
+                            if (!checkHostName(ManagementFactory.getRuntimeMXBean(), rt)) {
+                                return false;
+                            }
+                        }
+                    }
+                }
+            }
+            return true;
+        }
+        return false;
+    }
 
     public boolean supportsUserRemove() {
         return true;
@@ -247,5 +281,32 @@ final boolean isHeartbeatDisabled() {
     static boolean supportsHeartbeat(JmxApplication app) {
         return !app.isRemoved() && !app.isHeartbeatDisabled();
     }
+
+    private boolean matchProps(String[] propNames, Map<String, String> appProperties) {
+        for (String prop : propNames) {
+            String localProp = System.getProperty(prop);
+            String appProp = appProperties.get(prop);
+            if (!Objects.equals(localProp, appProp)) {
+                return false;
+            }
+        }
+        return true;
+    }
+
+    private boolean checkHostName(RuntimeMXBean localRuntime, RuntimeMXBean remoteRuntime) {
+        String localHost = getHostName(localRuntime.getName());
+        String remoteHost = getHostName(remoteRuntime.getName());
+
+        return Objects.equals(localHost, remoteHost);
+    }
 
+    private String getHostName(String runtimeName) {
+        if (runtimeName == null) return null;
+        int index = runtimeName.indexOf("@");       // NOI18N
+
+        if (index >= 0) {
+            return runtimeName.substring(index+1);
+        }
+        return null;
+    }
 }

visualvm/jvmstat/src/org/graalvm/visualvm/jvmstat/application/JvmstatApplicationProvider.java

@@ -382,8 +382,14 @@ public MonitoredHost getMonitoredHost(Application app) {
             return getLocalMonitoredHost();
         }
         if (!(app instanceof JvmstatApplication)) {
-            String appId = createId(app.getHost(),app.getPid());
+            Host host = app.getHost();
+            String appId = createId(host, app.getPid());
+
             japp = applications.get(appId);
+            if (japp!=null && !host.equals(japp.getHost())) {
+                // app is application running on different host via e.g. ssh tunnel
+                japp = null;
+            }
         } else {
             japp = (JvmstatApplication) app;
         }