Skip to content

Commit d115eed

Browse files
committed
Do not enable Refresh button when pausing profiler results for popup menu
1 parent 0e5bb60 commit d115eed

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

visualvm/profiler/src/com/sun/tools/visualvm/profiler/CPULivePanel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ protected void foundInReverseCalls() {
219219
protected void fireItemStateChanged(ItemEvent event) {
220220
boolean paused = isSelected();
221221
if (updater != null) updater.setPaused(paused);
222-
lrRefreshButton.setEnabled(paused);
222+
lrRefreshButton.setEnabled(paused && !popupPause);
223223
if (!paused) refreshResults(true);
224224
}
225225
};

visualvm/profiler/src/com/sun/tools/visualvm/profiler/JDBCLivePanel.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,7 @@ protected void showSQLQuery(String query, String htmlQuery) {
228228
protected void fireItemStateChanged(ItemEvent event) {
229229
boolean paused = isSelected();
230230
updater.setPaused(paused);
231-
boolean selected = lrPauseButton.isSelected();
232-
lrRefreshButton.setEnabled(selected);
231+
lrRefreshButton.setEnabled(paused && !popupPause);
233232
if (!paused) refreshResults(true);
234233
}
235234
};

visualvm/profiler/src/com/sun/tools/visualvm/profiler/MemoryLivePanel.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ protected void popupHidden() {
194194
protected void fireItemStateChanged(ItemEvent event) {
195195
boolean paused = isSelected();
196196
updater.setPaused(paused);
197-
lrRefreshButton.setEnabled(paused);
197+
lrRefreshButton.setEnabled(paused && !popupPause);
198198
if (!paused) refreshResults(true);
199199
}
200200
};

visualvm/sampler/src/com/sun/tools/visualvm/sampler/cpu/CPUView.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,9 @@ protected void foundInReverseCalls() {
215215

216216
lrPauseButton = new JToggleButton(Icons.getIcon(GeneralIcons.PAUSE)) {
217217
protected void fireItemStateChanged(ItemEvent event) {
218-
boolean selected = lrPauseButton.isSelected();
219-
lrRefreshButton.setEnabled(selected);
220-
if (!selected) refresher.refresh();
218+
boolean paused = lrPauseButton.isSelected();
219+
lrRefreshButton.setEnabled(paused && !popupPause);
220+
if (!paused) refresher.refresh();
221221
}
222222
};
223223
lrPauseButton.setToolTipText(Bundle.MethodsFeatureUI_pauseResults());

0 commit comments

Comments
 (0)