Snapshot.java, line 393 (Null Dereference) - Fortify

jisedlac · jisedlac · commit e6832a1a7d41 · 2019-03-06T15:45:44.000+01:00
diff --git a/visualvm/libs.profiler/profiler.oql/src/org/graalvm/visualvm/lib/profiler/oql/engine/api/impl/Snapshot.java b/visualvm/libs.profiler/profiler.oql/src/org/graalvm/visualvm/lib/profiler/oql/engine/api/impl/Snapshot.java
@@ -389,7 +389,7 @@ public State(ReferenceChain path, Iterator<Instance> iterator) {
             State s1 = stack.poll();
             if (s1 == null) break;
             s1.hits.addAndGet(s.hits.get());
-            if (s.hits.get() == 0L) {
+            if (s.hits.get() == 0L && path != null) {
                 ignored.add(path.getObj());
             }
             s = s1;

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ public State(ReferenceChain path, Iterator<Instance> iterator) {`
`389`	`389`	`State s1 = stack.poll();`
`390`	`390`	`if (s1 == null) break;`
`391`	`391`	`s1.hits.addAndGet(s.hits.get());`
`392`		`- if (s.hits.get() == 0L) {`
	`392`	`+ if (s.hits.get() == 0L && path != null) {`
`393`	`393`	`ignored.add(path.getObj());`
`394`	`394`	`}`
`395`	`395`	`s = s1;`