Skip to content

Commit ed2113e

Browse files
committed
create special version of JmxModel when jmx application is not connected (state != STATE_AVAILABLE)
1 parent 1a5bd2a commit ed2113e

File tree

2 files changed

+112
-1
lines changed

2 files changed

+112
-1
lines changed
Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
/*
2+
* Copyright (c) 2007, 2020, Oracle and/or its affiliates. All rights reserved.
3+
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4+
*
5+
* This code is free software; you can redistribute it and/or modify it
6+
* under the terms of the GNU General Public License version 2 only, as
7+
* published by the Free Software Foundation. Oracle designates this
8+
* particular file as subject to the "Classpath" exception as provided
9+
* by Oracle in the LICENSE file that accompanied this code.
10+
*
11+
* This code is distributed in the hope that it will be useful, but WITHOUT
12+
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13+
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14+
* version 2 for more details (a copy is included in the LICENSE file that
15+
* accompanied this code).
16+
*
17+
* You should have received a copy of the GNU General Public License version
18+
* 2 along with this work; if not, write to the Free Software Foundation,
19+
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
20+
*
21+
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
22+
* or visit www.oracle.com if you need additional information or have any
23+
* questions.
24+
*/
25+
package org.graalvm.visualvm.jmx.impl;
26+
27+
import java.util.Properties;
28+
import javax.management.MBeanServerConnection;
29+
import javax.management.remote.JMXServiceURL;
30+
import org.graalvm.visualvm.application.jvm.HeapHistogram;
31+
import org.graalvm.visualvm.tools.jmx.JmxModel;
32+
33+
/**
34+
*
35+
* @author Tomas Hurka
36+
*/
37+
class DisconnectedJmxModel extends JmxModel {
38+
39+
private final JMXServiceURL url;
40+
41+
DisconnectedJmxModel(JmxApplication app) {
42+
url = app.getJMXServiceURL();
43+
}
44+
45+
@Override
46+
public ConnectionState getConnectionState() {
47+
return ConnectionState.DISCONNECTED;
48+
}
49+
50+
@Override
51+
public MBeanServerConnection getMBeanServerConnection() {
52+
return null;
53+
}
54+
55+
@Override
56+
public JMXServiceURL getJMXServiceURL() {
57+
return url;
58+
}
59+
60+
@Override
61+
public Properties getSystemProperties() {
62+
return null;
63+
}
64+
65+
@Override
66+
public boolean isTakeHeapDumpSupported() {
67+
return false;
68+
}
69+
70+
@Override
71+
public boolean takeHeapDump(String fileName) {
72+
return false;
73+
}
74+
75+
@Override
76+
public boolean isTakeThreadDumpSupported() {
77+
return false;
78+
}
79+
80+
@Override
81+
public String takeThreadDump() {
82+
return null;
83+
}
84+
85+
@Override
86+
public String takeThreadDump(long[] threadIds) {
87+
return null;
88+
}
89+
90+
@Override
91+
public HeapHistogram takeHeapHistogram() {
92+
return null;
93+
}
94+
95+
@Override
96+
public String getFlagValue(String name) {
97+
return null;
98+
}
99+
100+
@Override
101+
public void setFlagValue(String name, String value) {
102+
}
103+
104+
@Override
105+
public String getCommandLine() {
106+
return null;
107+
}
108+
}

visualvm/jmx/src/org/graalvm/visualvm/jmx/impl/JmxModelProvider.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import org.graalvm.visualvm.core.model.AbstractModelProvider;
2929
import org.graalvm.visualvm.core.model.ModelProvider;
3030
import org.graalvm.visualvm.application.Application;
31+
import org.graalvm.visualvm.core.datasupport.Stateful;
3132
import org.graalvm.visualvm.tools.jmx.JmxModel;
3233
import org.graalvm.visualvm.tools.jvmstat.JvmstatModel;
3334
import org.graalvm.visualvm.tools.jvmstat.JvmstatModelFactory;
@@ -57,7 +58,9 @@ public JmxModel createModelFor(Application app) {
5758
JvmstatModel jvmstat;
5859

5960
if (app instanceof JmxApplication) {
60-
return new JmxModelImpl((JmxApplication) app);
61+
if (app.getState() == Stateful.STATE_AVAILABLE)
62+
return new JmxModelImpl((JmxApplication) app);
63+
return new DisconnectedJmxModel((JmxApplication) app);
6164
}
6265
jvmstat = JvmstatModelFactory.getJvmstatFor(app);
6366
if (jvmstat != null) {

0 commit comments

Comments
 (0)