Skip to content

Commit 690190a

Browse files
authored
Merge pull request #319 from galiacheng/main
Remove availability zone restriction as Reza suggests.
2 parents b2e8fc0 + ff5b79d commit 690190a

File tree

7 files changed

+24
-10
lines changed

7 files changed

+24
-10
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<properties>
4141
<!-- versions start -->
4242
<!-- weblogic azure aks versions -->
43-
<version.wls-on-aks-azure-marketplace>1.0.78</version.wls-on-aks-azure-marketplace>
43+
<version.wls-on-aks-azure-marketplace>1.0.79</version.wls-on-aks-azure-marketplace>
4444
<!-- weblogic azure vm versions -->
4545
<version.arm-oraclelinux-wls>1.0.27</version.arm-oraclelinux-wls>
4646
<version.arm-oraclelinux-wls-admin>1.0.51</version.arm-oraclelinux-wls-admin>

weblogic-azure-aks/src/main/arm/createUiDefinition.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,6 @@
329329
"Standard_DS2_v2"
330330
],
331331
"constraints": {
332-
"numAvailabilityZonesRequired": 3,
333-
"zone": "3",
334332
"excludedSizes": [
335333
"Standard_A0",
336334
"Standard_A1",

weblogic-azure-aks/src/main/arm/scripts/inline-scripts/validateParameters.sh

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -596,11 +596,24 @@ function validate_appgateway_vnet() {
596596
fi
597597
}
598598

599+
function query_available_zones() {
600+
if [[ "${createAKSCluster,,}" == "true" ]]; then
601+
outputAvailableZones=$(az vm list-skus -l ${location} --size ${aksAgentPoolVMSize} --zone true | jq -c '.[] | .locationInfo[] | .zones')
602+
fi
603+
604+
if [ -z "${outputAvailableZones}" ]; then
605+
outputAvailableZones="[]"
606+
fi
607+
608+
export outputAvailableZones="${outputAvailableZones}"
609+
}
610+
599611
function output_result() {
600612
echo "AKS version: ${outputAksVersion}"
601613
result=$(jq -n -c \
602614
--arg aksVersion "$outputAksVersion" \
603-
'{aksVersion: $aksVersion}')
615+
--arg agentAvailabilityZones "${outputAvailableZones}" \
616+
'{aksVersion: $aksVersion, agentAvailabilityZones: $agentAvailabilityZones}')
604617
echo "result is: $result"
605618
echo $result >$AZ_SCRIPTS_OUTPUT_PATH
606619
}
@@ -650,5 +663,7 @@ fi
650663

651664
validate_appgateway_vnet
652665

666+
query_available_zones
667+
653668
output_result
654669

weblogic-azure-aks/src/main/bicep/mainTemplate.bicep

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,7 @@ module wlsDomainDeployment 'modules/setupWebLogicCluster.bicep' = if (!enableCus
567567
aksClusterNamePrefix: aksClusterNamePrefix
568568
aksClusterRGName: aksClusterRGName
569569
aksClusterName: aksClusterName
570+
aksAgentAvailabilityZones:validateInputs.outputs.aksAgentAvailabilityZones
570571
aksVersion: validateInputs.outputs.aksVersion
571572
appPackageUrls: appPackageUrls
572573
appReplicas: appReplicas
@@ -639,6 +640,7 @@ module wlsDomainWithCustomSSLDeployment 'modules/setupWebLogicCluster.bicep' = i
639640
aksClusterNamePrefix: aksClusterNamePrefix
640641
aksClusterRGName: aksClusterRGName
641642
aksClusterName: aksClusterName
643+
aksAgentAvailabilityZones:validateInputs.outputs.aksAgentAvailabilityZones
642644
aksVersion: validateInputs.outputs.aksVersion
643645
appPackageUrls: appPackageUrls
644646
appReplicas: appReplicas

weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_aks.bicep

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ param aciResourcePermissions bool = true
77
param aciRetentionInDays int = 120
88
@description('Pricing tier: PerGB2018 or legacy tiers (Free, Standalone, PerNode, Standard or Premium) which are not available to all customers.')
99
param aciWorkspaceSku string = 'pergb2018'
10+
param agentAvailabilityZones array = []
1011
@maxLength(12)
1112
@minLength(1)
1213
@description('The name for this node pool. Node pool must contain only lowercase letters and numbers. For Linux node pools the name cannot be longer than 12 characters.')
@@ -27,11 +28,6 @@ param location string
2728
param utcValue string = utcNow()
2829

2930
var const_aksAgentPoolOSDiskSizeGB = 128
30-
var const_aksAvailabilityZones = [
31-
'1'
32-
'2'
33-
'3'
34-
]
3531
var name_aciWorkspace = 'Workspace-${guid(utcValue)}-${location}'
3632
// Generate a unique AKS name scoped to subscription.
3733
var name_aksClusterNameForSV = '${aksClusterNamePrefix}${uniqueString(utcValue)}'
@@ -79,7 +75,7 @@ resource aksCluster 'Microsoft.ContainerService/managedClusters@${azure.apiVersi
7975
osDiskType: 'Managed'
8076
kubeletDiskType: 'OS'
8177
type: 'VirtualMachineScaleSets'
82-
availabilityZones: const_aksAvailabilityZones
78+
availabilityZones: agentAvailabilityZones
8379
mode: 'System'
8480
osType: 'Linux'
8581
}

weblogic-azure-aks/src/main/bicep/modules/_deployment-scripts/_ds-validate-parameters.bicep

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,3 +247,4 @@ resource deploymentScript 'Microsoft.Resources/deploymentScripts@${azure.apiVers
247247
}
248248

249249
output aksVersion string = deploymentScript.properties.outputs.aksVersion
250+
output aksAgentAvailabilityZones array = json(deploymentScript.properties.outputs.agentAvailabilityZones)

weblogic-azure-aks/src/main/bicep/modules/setupWebLogicCluster.bicep

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ param aciRetentionInDays int = 120
2929
param aciWorkspaceSku string = 'pergb2018'
3030
param acrName string = ''
3131
param acrResourceGroupName string = ''
32+
param aksAgentAvailabilityZones array = []
3233
@maxLength(12)
3334
@minLength(1)
3435
@description('The name for this node pool. Node pool must contain only lowercase letters and numbers. For Linux node pools the name cannot be longer than 12 characters.')
@@ -161,6 +162,7 @@ module aksClusterDeployment './_azure-resoruces/_aks.bicep' = if (createAKSClust
161162
aciResourcePermissions: aciResourcePermissions
162163
aciRetentionInDays: aciRetentionInDays
163164
aciWorkspaceSku: aciWorkspaceSku
165+
agentAvailabilityZones: aksAgentAvailabilityZones
164166
aksAgentPoolName: aksAgentPoolName
165167
aksAgentPoolNodeCount: aksAgentPoolNodeCount
166168
aksAgentPoolNodeMaxCount: aksAgentPoolNodeMaxCount

0 commit comments

Comments
 (0)