Skip to content

Commit 29b1e96

Browse files
authored
Merge pull request #70 from oracle/issue#69-element-id-cannot-be-property
Issue#69 - Allow ID to be specified as @@prop:key@@. Fixes #69
2 parents c148c18 + 5e5c36e commit 29b1e96

File tree

5 files changed

+12
-1
lines changed

5 files changed

+12
-1
lines changed

core/src/main/antlr4/oracle/weblogic/deploy/yaml/Yaml.g4

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,11 +287,12 @@ fragment ID_CONTINUE
287287
fragment QUOTED_ID_START
288288
: ID_START
289289
| '$'
290+
| '@'
290291
;
291292

292293
fragment QUOTED_ID_CONTINUE
293294
: ID_CONTINUE
294-
| [@#\-(){}[\]]
295+
| [@#\-(){}[\]:]
295296
;
296297

297298
fragment SQUOTED_STRING_CHARS

core/src/test/python/variables_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ def testSubstituteYaml(self):
3131
self.assertEqual(model['topology']['Server']['s1']['ListenPort'], '1009')
3232
self.assertEqual(model['topology']['Server']['s2']['Cluster'], 'myCluster')
3333
self.assertEqual(True, 'myCluster' in model['topology']['Cluster'])
34+
self.assertEqual(True, 's3' in model['topology']['Server'])
3435

3536
def testSubstituteJson(self):
3637
model = FileToPython(self._resources_dir + '/variables-test.json', self._use_ordering).parse()
@@ -40,6 +41,7 @@ def testSubstituteJson(self):
4041
self.assertEqual(model['topology']['Server']['s1']['ListenPort'], '1009')
4142
self.assertEqual(model['topology']['Server']['s2']['Cluster'], 'myCluster')
4243
self.assertEqual(True, 'myCluster' in model['topology']['Cluster'])
44+
self.assertEqual(True, 's3' in model['topology']['Server'])
4345

4446
def testVariableNotFound(self):
4547
"""

core/src/test/resources/variables-test.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
"ListenAddress": "127.0.0.1",
2121
"ListenPort": 8101,
2222
"Cluster": "@@PROP:my.cluster@@"
23+
},
24+
"@@PROP:server3.id@@": {
25+
"ListenAddress": "127.0.0.2",
26+
"ListenPort": 8102
2327
}
2428
}
2529
}

core/src/test/resources/variables-test.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,6 @@ topology:
1515
ListenAddress: 127.0.0.1
1616
ListenPort: 8101
1717
Cluster: '@@PROP:my.cluster@@'
18+
'@@PROP:server3.id@@':
19+
ListenAddress: 127.0.0.2
20+
ListenPort: 8102

core/src/test/resources/variables.properties

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
my.port=1009
55
my.server=myServer
66
my.cluster=myCluster
7+
server3.id=s3
78

89
my-abc=xyz
910
my_arf=123

0 commit comments

Comments
 (0)