Detect lexical errors for JSON and YAML parsers (#582)

* Parsers check for lexical errors as well as parser errors

Author: rakillen

core/src/main/java/oracle/weblogic/deploy/json/AbstractJsonTranslator.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2019, Oracle Corporation and/or its affiliates.  All rights reserved.
+ * Copyright (c) 2017, 2020, Oracle Corporation and/or its affiliates.  All rights reserved.
  * Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
  */
 package oracle.weblogic.deploy.json;
@@ -288,6 +288,9 @@ protected PyDictionary parseInternal(String jsonFileName, InputStream jsonStream
             try {
                 CharStream input = CharStreams.fromStream(jsonStream);
                 JSONLexer lexer = new JSONLexer(input);
+                lexer.removeErrorListeners();
+                lexer.addErrorListener(errorListener);
+
                 CommonTokenStream tokens = new CommonTokenStream(lexer);
                 JSONParser parser = new JSONParser(tokens);
 

core/src/main/java/oracle/weblogic/deploy/yaml/AbstractYamlTranslator.java

@@ -175,6 +175,9 @@ protected PyDictionary parseInternal(String yamlFileName, InputStream yamlStream
             try {
                 CharStream input = CharStreams.fromStream(yamlStream);
                 YamlLexer lexer = new YamlLexer(input);
+                lexer.removeErrorListeners();
+                lexer.addErrorListener(errorListener);
+
                 CommonTokenStream tokens = new CommonTokenStream(lexer);
                 YamlParser parser = new YamlParser(tokens);
 

core/src/test/java/oracle/weblogic/deploy/json/JsonTranslatorTest.java

@@ -0,0 +1,44 @@
+/*
+ * Copyright (c) 2020, Oracle Corporation and/or its affiliates.
+ * Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
+ */
+package oracle.weblogic.deploy.json;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+public class JsonTranslatorTest {
+
+    /**
+     * Verify that a lexical error will throw an Exception
+     */
+    @Test
+    public void testLexicalError() {
+        // Temporarily disable logging for this test. Intended lexical failure will log a stack trace.
+        Logger logger = Logger.getLogger("wlsdeploy.json");
+        Level originalLevel  = logger.getLevel();
+        logger.setLevel(Level.OFF);
+
+        try {
+            // JSON { "abc": "xyz"\ } causes lexical error
+            String text = "{ \"abc\": \"xyz\"/ }";
+            InputStream stream = new ByteArrayInputStream(text.getBytes(UTF_8));
+            JsonStreamTranslator translator = new JsonStreamTranslator("String", stream);
+            translator.parse();
+            Assert.fail("Test must raise JsonException when model has a lexical error");
+
+        } catch(JsonException e) {
+            // expected result
+
+        } finally {
+            logger.setLevel(originalLevel);
+        }
+    }
+}

core/src/test/java/oracle/weblogic/deploy/yaml/YamlTranslatorTest.java

@@ -0,0 +1,46 @@
+/*
+ * Copyright (c) 2020, Oracle Corporation and/or its affiliates.
+ * Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
+ */
+package oracle.weblogic.deploy.yaml;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.InputStream;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+import static java.nio.charset.StandardCharsets.UTF_8;
+
+public class YamlTranslatorTest {
+
+    /**
+     * Verify that a lexical error will throw an Exception
+     */
+    @Test
+    public void testLexicalError() {
+        // Temporarily disable logging for this test. Intended lexical failure will log a stack trace.
+        Logger logger = Logger.getLogger("wlsdeploy.yaml");
+        Level originalLevel  = logger.getLevel();
+        logger.setLevel(Level.OFF);
+
+        try {
+            // YAML causes lexical error:
+            // abc:
+            //   xyz: aa-bb
+            String text = "abc:\n  xyz: aa-bb\n";
+            InputStream stream = new ByteArrayInputStream(text.getBytes(UTF_8));
+            YamlStreamTranslator translator = new YamlStreamTranslator("String", stream);
+            translator.parse();
+            Assert.fail("Test must raise YamlException when model has a lexical error");
+
+        } catch(YamlException e) {
+            // expected result
+
+        } finally {
+            logger.setLevel(originalLevel);
+        }
+    }
+}