Skip to content

Commit 3e8536f

Browse files
committed
made sure VERSION_INVALID condition results in validation warning (instead of error), regardless of validation mode
1 parent ee568a2 commit 3e8536f

File tree

1 file changed

+5
-20
lines changed

1 file changed

+5
-20
lines changed

core/src/main/python/wlsdeploy/tool/validate/validator.py

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -478,21 +478,15 @@ def __validate_model_section(self, model_section_key, model_dict, valid_section_
478478
section_dict_key)
479479
if result == ValidationCodes.VERSION_INVALID:
480480
# key is a VERSION_INVALID folder
481-
if self._validation_mode == _ValidationModes.STANDALONE:
482-
validation_result.add_warning('WLSDPLY-05027', message)
483-
else:
484-
validation_result.add_error('WLSDPLY-05027', message)
481+
validation_result.add_warning('WLSDPLY-05027', message)
485482
elif result == ValidationCodes.INVALID:
486483
validation_result.add_error('WLSDPLY-05026', section_dict_key, 'folder',
487484
model_folder_path, '%s' % ', '.join(valid_section_folders))
488485
else:
489486
result, message = self._alias_helper.is_valid_model_attribute_name(validation_location,
490487
section_dict_key)
491488
if result == ValidationCodes.VERSION_INVALID:
492-
if self._validation_mode == _ValidationModes.STANDALONE:
493-
validation_result.add_warning('WLSDPLY-05027', message)
494-
else:
495-
validation_result.add_error('WLSDPLY-05027', message)
489+
validation_result.add_warning('WLSDPLY-05027', message)
496490
elif result == ValidationCodes.INVALID:
497491
validation_result.add_error('WLSDPLY-05029', section_dict_key,
498492
model_folder_path, '%s' % ', '.join(valid_attr_infos))
@@ -679,10 +673,7 @@ def __process_model_node(self, model_node, validation_location, validation_resul
679673
result, message = self._alias_helper.is_valid_model_folder_name(validation_location, key)
680674
if result == ValidationCodes.VERSION_INVALID:
681675
# key is a VERSION_INVALID folder
682-
if self._validation_mode == _ValidationModes.STANDALONE:
683-
validation_result.add_warning('WLSDPLY-05027', message)
684-
else:
685-
validation_result.add_error('WLSDPLY-05027', message)
676+
validation_result.add_warning('WLSDPLY-05027', message)
686677
elif result == ValidationCodes.INVALID:
687678
# key is an INVALID folder
688679
validation_result.add_error('WLSDPLY-05026', key, 'folder',
@@ -696,10 +687,7 @@ def __process_model_node(self, model_node, validation_location, validation_resul
696687
result, message = self._alias_helper.is_valid_model_attribute_name(validation_location, key)
697688
if result == ValidationCodes.VERSION_INVALID:
698689
# key is a VERSION_INVALID attribute
699-
if self._validation_mode == _ValidationModes.STANDALONE:
700-
validation_result.add_warning('WLSDPLY-05027', message)
701-
else:
702-
validation_result.add_error('WLSDPLY-05027', message)
690+
validation_result.add_warning('WLSDPLY-05027', message)
703691
elif result == ValidationCodes.INVALID:
704692
# key is an INVALID attribute
705693
validation_result.add_error('WLSDPLY-05029', key,
@@ -769,10 +757,7 @@ def __validate_attribute(self, attribute_name, attribute_value, valid_attr_infos
769757
else:
770758
result, message = self._alias_helper.is_valid_model_attribute_name(validation_location, attribute_name)
771759
if result == ValidationCodes.VERSION_INVALID:
772-
if self._validation_mode == _ValidationModes.STANDALONE:
773-
validation_result.add_warning('WLSDPLY-05027', message)
774-
else:
775-
validation_result.add_error('WLSDPLY-05027', message)
760+
validation_result.add_warning('WLSDPLY-05027', message)
776761
elif result == ValidationCodes.INVALID:
777762
validation_result.add_error('WLSDPLY-05029', attribute_name,
778763
model_folder_path, '%s' % ', '.join(valid_attr_infos))

0 commit comments

Comments
 (0)