Skip to content

Commit 6e894f9

Browse files
committed
Merge branch 'openjdk-support' into 'main'
Adding support that allows the user to run WDT using OpenJDK and removing broken support for GraalVM See merge request weblogic-cloud/weblogic-deploy-tooling!1751
2 parents e8efbf9 + 27c448d commit 6e894f9

File tree

2 files changed

+33
-67
lines changed

2 files changed

+33
-67
lines changed

installer/src/main/bin/shared.cmd

Lines changed: 28 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -24,72 +24,50 @@ GOTO :ENDFUNCTIONS
2424
SET "QUIET_ARG=%2"
2525

2626
IF NOT DEFINED JAVA_HOME (
27-
ECHO Please set the JAVA_HOME environment variable to point to a Java 8 installation >&2
28-
EXIT /B 2
27+
ECHO Please set the JAVA_HOME environment variable to point to a Java %MIN_JDK_VERSION% or higher installation >&2
28+
EXIT /B 2
2929
)
3030
FOR %%i IN ("%JAVA_HOME%") DO SET JAVA_HOME=%%~fsi
3131
IF %JAVA_HOME:~-1%==\ SET JAVA_HOME=%JAVA_HOME:~0,-1%
3232

3333
IF NOT EXIST "%JAVA_HOME%" (
34-
ECHO Your JAVA_HOME environment variable to points to a non-existent directory: %JAVA_HOME% >&2
35-
EXIT /B 2
34+
ECHO Your JAVA_HOME environment variable to points to a non-existent directory: %JAVA_HOME% >&2
35+
EXIT /B 2
3636
)
3737

3838
IF EXIST "%JAVA_HOME%\bin\java.exe" (
39-
FOR %%i IN ("%JAVA_HOME%\bin\java.exe") DO SET JAVA_EXE=%%~fsi
39+
FOR %%i IN ("%JAVA_HOME%\bin\java.exe") DO SET JAVA_EXE=%%~fsi
4040
) ELSE (
41-
ECHO Java executable does not exist at %JAVA_HOME%\bin\java.exe >&2
42-
EXIT /B 2
41+
ECHO Java executable does not exist at %JAVA_HOME%\bin\java.exe >&2
42+
EXIT /B 2
4343
)
4444

4545
SET OPEN_JDK=false
46-
SET ORACLE_ONE=0
47-
SET ORACLE_TWO=0
48-
FOR /F "tokens=1,5" %%x IN ('%JAVA_EXE% -version 2^>^&1') DO (
46+
SET GRAAL_VM=false
47+
FOR /F "tokens=1,4,6" %%x IN ('%JAVA_EXE% -version 2^>^&1') DO (
4948
IF "%%x" == "OpenJDK" (
5049
SET OPEN_JDK=true
51-
IF EXIST %ORACLE_HOME%\wlserver\server\lib\weblogic.jar (
52-
FOR /F "tokens=1-3 delims= " %%A IN ('%JAVA_EXE% -cp %ORACLE_HOME%\wlserver\server\lib\weblogic.jar weblogic.version 2^>^&1') DO (
53-
IF "%%A" == "WebLogic" (
54-
FOR /F "tokens=1-5 delims=." %%j IN ('ECHO %%C') DO (
55-
SET "ORACLE_VERSION=%%j.%%k.%%l.%%m.%%n"
56-
SET "ORACLE_ONE=%%j"
57-
SET "ORACLE_TWO=%%l"
58-
)
59-
)
60-
)
61-
SET GRAALVM=false
62-
IF "%%y" == "GraalVM" SET GRAALVM=true
63-
) ELSE (
64-
ECHO JAVA_HOME %JAVA_HOME% contains OpenJDK^, which is not supported >&2
65-
EXIT /B 2
66-
)
50+
)
51+
IF "%%y" == "GraalVM" (
52+
SET GRAAL_VM=true
53+
)
54+
IF "%%z" == "GraalVM" (
55+
SET GRAAL_VM=true
6756
)
6857
)
6958

70-
SET NOT_VALID=false
71-
IF "%OPEN_JDK%"=="true" (
72-
IF "%GRAALVM%"=="false" SET NOT_VALID=true
73-
IF %ORACLE_ONE% LSS 14 (
74-
SET NOT_VALID=true
75-
) ELSE IF %ORACLE_ONE% EQU 14 IF %ORACLE_TWO% LSS 2 SET NOT_VALID=true
76-
SET JAVA_VENDOR=GraalVM
77-
)
78-
79-
IF "%NOT_VALID%"=="true" (
80-
IF "%GRAALVM%"=="true" (
81-
SET ORACLE_VERSION
82-
ECHO JAVA_HOME %JAVA_HOME% contains GraalVM OpenJDK^, which is not supported in versions before 14.1.2 >&2
83-
EXIT /B 2
84-
)
85-
ECHO JAVA_HOME %JAVA_HOME% contains OpenJDK^, which is not supported. >&2
59+
IF "%GRAAL_VM%" == "true" (
60+
ECHO JAVA_HOME %JAVA_HOME% contains GraalVM^, which is not supported by WDT >&2
8661
EXIT /B 2
8762
)
63+
IF "%OPEN_JDK%" == "true" (
64+
ECHO JAVA_HOME %JAVA_HOME% contains OpenJDK^, which is not supported by WebLogic Server^, so use at your own risk^!
65+
)
8866

8967
FOR /F tokens^=2-5^ delims^=.-_^" %%j IN ('%JAVA_EXE% -fullversion 2^>^&1') DO (
90-
SET "JVM_FULL_VERSION=%%j.%%k.%%l_%%m"
91-
SET "JVM_VERSION_PART_ONE=%%j"
92-
SET "JVM_VERSION_PART_TWO=%%k"
68+
SET "JVM_FULL_VERSION=%%j.%%k.%%l_%%m"
69+
SET "JVM_VERSION_PART_ONE=%%j"
70+
SET "JVM_VERSION_PART_TWO=%%k"
9371
)
9472

9573
SET JVM_SUPPORTED=1
@@ -103,12 +81,12 @@ GOTO :ENDFUNCTIONS
10381
)
10482

10583
IF %JVM_SUPPORTED% NEQ 1 (
106-
EXIT /B 2
84+
EXIT /B 2
10785
) ELSE (
108-
IF NOT "%QUIET_ARG%"=="quiet" (
109-
ECHO JDK version is %JVM_FULL_VERSION%, setting JAVA_VENDOR to Sun...
110-
)
111-
IF "%JAVA_VENDOR%"=="" SET JAVA_VENDOR=Sun
86+
IF NOT "%QUIET_ARG%"=="quiet" (
87+
ECHO JDK version is %JVM_FULL_VERSION%, setting JAVA_VENDOR to Sun...
88+
)
89+
IF "%JAVA_VENDOR%"=="" SET JAVA_VENDOR=Sun
11290
)
11391
GOTO :EOF
11492

installer/src/main/bin/shared.sh

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,12 @@ javaSetup() {
3737

3838
case "${JVM_OUTPUT}" in
3939
*GraalVM*)
40-
setOracleVersion
41-
if [ -z "${ORACLE_VERSION}" ] || [ ${ORACLE_VER_ONE} -lt 14 ] || [ ${ORACLE_VER_ONE} -eq 14 ] && [ ${ORACLE_VER_THREE} -lt 2 ]; then
42-
echo "JAVA_HOME ${JAVA_HOME} contains GraalVM OpenJDK, which is not supported before 14.1.2" >&2
43-
exit 2
44-
fi
40+
echo "JAVA_HOME ${JAVA_HOME} contains GraalVM, which is not supported by WDT" >&2
41+
exit 2
4542
;;
4643
*OpenJDK*)
47-
echo "JAVA_HOME ${JAVA_HOME} contains OpenJDK, which is not supported" >&2
48-
exit 2
44+
echo "JAVA_HOME ${JAVA_HOME} contains OpenJDK, which is not supported by WebLogic Server, so use at your own risk!"
4945
;;
50-
5146
esac
5247

5348

@@ -64,19 +59,12 @@ javaSetup() {
6459
echo "You are using an unsupported JDK version ${JVM_FULL_VERSION}" >&2
6560
exit 2
6661
else
67-
if [ "$2" != "quiet" ]; then
62+
# if [ "$2" != "quiet" ]; then
6863
echo "JDK version is ${JVM_FULL_VERSION}"
69-
fi
64+
# fi
7065
fi
7166
}
7267

73-
setOracleVersion() {
74-
ORACLE_VERSION=`"${JAVA_HOME}/bin/java" -cp "$ORACLE_HOME/wlserver/server/lib/weblogic.jar" weblogic.version | grep "WebLogic Server" | cut -d " " -f3 2>&1`
75-
ORACLE_VER_ONE=`echo ${ORACLE_VERSION} | cut -d "." -f1`
76-
ORACLE_VER_THREE=`echo ${ORACLE_VERSION} | cut -d "." -f3`
77-
echo ORACLE_VERSION=$ORACLE_VERSION
78-
}
79-
8068
checkArgs() {
8169
checkJythonArgs $*
8270
}

0 commit comments

Comments
 (0)