replace warning IMG-0099 with simpler info message to avoid user confusion with patch versioning (#346)

Author: ddsharpe

imagetool/src/main/java/com/oracle/weblogic/imagetool/aru/AruPatch.java

@@ -254,36 +254,33 @@ public static AruPatch selectPatch(List<AruPatch> patches, String providedVersio
             } else if (providedVersion != null && !selected.version().equals(providedVersion)) {
                 throw new VersionNotFoundException(selected.patchId(), providedVersion, patches);
             } else {
-                // the patch has a version from ARU, warn the user if the version doesn't match the target install
-                if (psuVersion != null) {
-                    if (!selected.version().equals(psuVersion)) {
-                        logger.warning("IMG-0099", selected.patchId(), selected.version(), psuVersion);
-                    }
-                } else {
-                    if (installerVersion != null && !selected.version().equals(installerVersion)) {
-                        logger.warning("IMG-0099", selected.patchId(), selected.version(), installerVersion);
-                    }
-                }
+                logger.info("IMG-0099", selected.patchId(), selected.version(), selected.description());
             }
+            
             logger.exiting(selected);
             return selected;
         }
 
         Map<String, AruPatch> patchMap = patches.stream().collect(Collectors
             .toMap(AruPatch::version, aruPatch -> aruPatch));
-        // if the user provided a specific version, select the provided version, or fail
+        // select the correct patch version (priority order: user provided version, PSU version, GA installer version)
         if (providedVersion != null) {
+            // if the user provided a specific version, select the provided version, or fail
             if (patchMap.containsKey(providedVersion)) {
                 selected = patchMap.get(providedVersion);
             } else {
                 throw new VersionNotFoundException(patches.get(0).patchId(), providedVersion, patches);
             }
         } else if (patchMap.containsKey(psuVersion)) {
+            // if the image has a PSU installed, or the new patch list has a PSU, otherwise skip to installer version
             selected = patchMap.get(psuVersion);
         } else if (patchMap.containsKey(installerVersion)) {
             selected = patchMap.get(installerVersion);
         }
 
+        if (selected != null) {
+            logger.info("IMG-0099", selected.patchId(), selected.version(), selected.description());
+        }
         logger.exiting(selected);
         return selected;
     }

imagetool/src/main/resources/ImageTool.properties

@@ -97,7 +97,7 @@ IMG-0095=Unable to parse response for Oracle patches in fromImage: {0}
 IMG-0096=Unable to patch image {0}. The installed products could not be identified for patching. The most likely cause is that the registry.xml in this image may be invalid.
 IMG-0097=Inspecting {0}, this may take a few minutes if the image is not available locally.
 IMG-0098=Patch [[red: {0}]] is a Stack Patch Bundle, not a patch. Remove {0} from --patches and use [[cyan: --recommendedPatches]] instead.
-IMG-0099=Patch [[red: {0}]] is only for version {1} and may not be applicable to the target version {2}. Check Oracle Support, there may be another patch number for version {2}. Or check the OPatch output for results for this image.
+IMG-0099=Found patch [[cyan: {0}]] for version [[cyan: {1}]]. Bug description: "{2}"
 IMG-0100=Missing argument --fromImage. Update requires an image to be updated. Use --fromImage to specify the image to build on.
 IMG-0101=The version of OPatch that you requested is not available: {0}
 IMG-0102=WDT {0} file [[brightred: {1}]] could not be found.