Skip to content

Commit 4301caa

Browse files
committed
removed code smell from Sonar check in unit test
1 parent b90e715 commit 4301caa

File tree

1 file changed

+10
-12
lines changed

1 file changed

+10
-12
lines changed

imagetool/src/test/java/com/oracle/weblogic/imagetool/aru/VersionTest.java

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -20,28 +20,26 @@ void sameVersionNumber() {
2020
assertEquals(0, a.compareTo(b));
2121
}
2222

23+
private void compareDifferingVersions(String firstVersion, String laterVersion) {
24+
Version v1 = new Version(firstVersion);
25+
Version v2 = new Version(laterVersion);
26+
assertEquals(1, v2.compareTo(v1));
27+
assertEquals(-1, v1.compareTo(v2));
28+
}
29+
2330
@Test
2431
void differentVersionNumbers() {
25-
Version a = new Version("1.2.3");
26-
Version b = new Version("1.2.4");
27-
assertEquals(1, b.compareTo(a));
28-
assertEquals(-1, a.compareTo(b));
32+
compareDifferingVersions("1.2.3", "1.2.4");
2933
}
3034

3135
@Test
3236
void differentVersionLengths() {
33-
Version a = new Version("1.2.3");
34-
Version b = new Version("1.2.3.1");
35-
assertEquals(1, b.compareTo(a));
36-
assertEquals(-1, a.compareTo(b));
37+
compareDifferingVersions("1.2.3", "1.2.3.1");
3738
}
3839

3940
@Test
4041
void integerComparison() {
41-
Version a = new Version("13.9.4.2.9");
42-
Version b = new Version("13.9.4.2.10");
43-
assertEquals(1, b.compareTo(a));
44-
assertEquals(-1, a.compareTo(b));
42+
compareDifferingVersions("13.9.4.2.9", "13.9.4.2.10");
4543
}
4644

4745
@Test

0 commit comments

Comments
 (0)