more unit tests

Author: alai8

operator/src/test/java/oracle/kubernetes/operator/http/HttpClientStub.java

@@ -0,0 +1,21 @@
+// Copyright 2019 Oracle Corporation and/or its affiliates.  All rights reserved.
+// Licensed under the Universal Permissive License v 1.0 as shown at
+// http://oss.oracle.com/licenses/upl.
+
+package oracle.kubernetes.operator.http;
+
+public abstract class HttpClientStub extends HttpClient {
+
+  final String RESPONSE = "{}";
+
+  public HttpClientStub() {
+    super(null, null);
+  }
+
+  @Override
+  public Result executePostUrlOnServiceClusterIP(
+      String requestUrl, String serviceURL, String payload, boolean throwOnFailure)
+      throws HTTPException {
+    return new Result(RESPONSE, 200, true);
+  }
+}

operator/src/test/java/oracle/kubernetes/operator/steps/ReadHealthStepTest.java

@@ -1,4 +1,4 @@
-// Copyright 2018, Oracle Corporation and/or its affiliates.  All rights reserved.
+// Copyright 2018, 2019 Oracle Corporation and/or its affiliates.  All rights reserved.
 // Licensed under the Universal Permissive License v 1.0 as shown at
 // http://oss.oracle.com/licenses/upl.
 
@@ -8,22 +8,28 @@
 import static oracle.kubernetes.operator.logging.MessageKeys.WLS_HEALTH_READ_FAILED;
 import static oracle.kubernetes.operator.logging.MessageKeys.WLS_HEALTH_READ_FAILED_NO_HTTPCLIENT;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.Assert.*;
+import static org.hamcrest.Matchers.is;
+import static org.hamcrest.core.IsNull.nullValue;
 
 import com.meterware.simplestub.Memento;
 import com.meterware.simplestub.Stub;
 import io.kubernetes.client.models.V1Service;
+import io.kubernetes.client.models.V1ServicePort;
+import io.kubernetes.client.models.V1ServiceSpec;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.logging.Level;
 import java.util.logging.LogRecord;
 import oracle.kubernetes.TestUtils;
 import oracle.kubernetes.operator.ProcessingConstants;
 import oracle.kubernetes.operator.http.HttpClient;
+import oracle.kubernetes.operator.http.HttpClientStub;
 import oracle.kubernetes.operator.steps.ReadHealthStep.ReadHealthWithHttpClientStep;
 import oracle.kubernetes.operator.work.NextAction;
 import oracle.kubernetes.operator.work.Packet;
 import oracle.kubernetes.operator.work.Step;
+import oracle.kubernetes.weblogic.domain.model.ServerHealth;
 import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
@@ -74,25 +80,55 @@ public void withHttpClientStep_logIfMissingHTTPClient() {
     V1Service service = Stub.createStub(V1ServiceStub.class);
     Step next = new MockStep(null);
     final String SERVER_NAME = "admin-server";
-    Packet packet = Stub.createStub(PacketStub.class).withServerName(SERVER_NAME);
+    Packet packet =
+        Stub.createStub(PacketStub.class).withServerName(SERVER_NAME).withGetKeyReturnValue(null);
 
     ReadHealthWithHttpClientStep withHttpClientStep =
         new ReadHealthWithHttpClientStep(service, next);
     withHttpClientStep.apply(packet);
 
     assertThat(logRecords, containsInfo(WLS_HEALTH_READ_FAILED_NO_HTTPCLIENT, SERVER_NAME));
+    assertThat(packet.get(ProcessingConstants.SERVER_HEALTH_READ), nullValue());
+  }
+
+  @Test
+  public void withHttpClientStep_putServerHealthReadToPacketIfSucceeded() {
+    V1Service service = Stub.createStub(V1ServiceStub.class);
+    Step next = new MockStep(null);
+    final String SERVER_NAME = "admin-server";
+
+    HttpClientStub httpClientStub = Stub.createStub(HttpClientStub.class);
+
+    Packet packet =
+        Stub.createStub(PacketStub.class)
+            .withServerName(SERVER_NAME)
+            .withGetKeyReturnValue(httpClientStub);
+    packet.put(
+        ProcessingConstants.SERVER_HEALTH_MAP, new ConcurrentHashMap<String, ServerHealth>());
+
+    ReadHealthWithHttpClientStep withHttpClientStep =
+        new ReadHealthWithHttpClientStep(service, next);
+    withHttpClientStep.apply(packet);
+
+    assertThat(packet.get(ProcessingConstants.SERVER_HEALTH_READ), is(Boolean.TRUE));
   }
 
   abstract static class PacketStub extends Packet {
 
     String serverName;
     boolean getKeyThrowsException;
+    HttpClient getKeyReturnValue;
 
     PacketStub withGetKeyThrowsException(boolean getKeyThrowsException) {
       this.getKeyThrowsException = getKeyThrowsException;
       return this;
     }
 
+    PacketStub withGetKeyReturnValue(HttpClient getKeyReturnValue) {
+      this.getKeyReturnValue = getKeyReturnValue;
+      return this;
+    }
+
     PacketStub withServerName(String serverName) {
       this.serverName = serverName;
       return this;
@@ -104,15 +140,24 @@ public Object get(Object key) {
         if (getKeyThrowsException) {
           throw CLASSCAST_EXCEPTION; // to go to catch clause in WithHttpClientStep.apply() method
         }
-        return null;
+        return getKeyReturnValue;
       } else if (ProcessingConstants.SERVER_NAME.equals(key)) {
         return serverName;
       }
       return super.get(key);
     }
   }
 
-  public abstract static class V1ServiceStub extends V1Service {}
+  public abstract static class V1ServiceStub extends V1Service {
+
+    @Override
+    public V1ServiceSpec getSpec() {
+      List<V1ServicePort> ports = new ArrayList<>();
+      ports.add(new V1ServicePort().port(7001));
+      V1ServiceSpec v1ServiceSpec = new V1ServiceSpec().clusterIP("127.0.0.1").ports(ports);
+      return v1ServiceSpec;
+    }
+  }
 
   static class MockStep extends Step {
     public MockStep(Step next) {