Skip to content

Commit 08ba43f

Browse files
committed
fix the javadoc
1 parent 164940f commit 08ba43f

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

integration-tests/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ Configuration Overrides Usecases
9292

9393
| Override | Usecase |
9494
| --- | --- |
95-
| Configuration override | Override the administration server and server template properties `connect-timeout`, `max-message-size`, `restart-max`, `debug-server-life-cycle` and `debug-jmx-core` debug flags. Also T3Channel public address using Kubernetes secret. The override is verified by JMX client connecting to the serverConfig MBean tree and the values are checked against the expected values. The test client connects to the overridden T3 public address and port to connect to the MBean servers |
95+
| Configuration override | Override the administration server `connect-timeout`, `max-message-size`, `restart-max`, `debug-server-life-cycle` and `debug-jmx-core` debug flags. Also T3Channel public address using Kubernetes secret. The dynamic cluster server template's `,ax-message-size` is overridden for managed servers. The override is verified by JMX client connecting to the serverConfig MBean tree and the values are checked against the expected values. The test client connects to the overridden T3 public address and port to connect to the MBean servers |
9696
| JDBC Resource Override | Override JDBC connection pool properties; `initialCapacity`, `maxCapacity`, `test-connections-on-reserve`, `connection-harvest-max-count`, `inactive-connection-timeout-seconds`. Override the JDBC driver parameters like data source `URL`, `DB` `user` and `password` using kubernetes secret. The test verifies the overridden functionality datasource `URL`, `user`, `password` by getting the data source connection and running DDL statement it is connected to. |
9797
| JMS Resource Override | Override UniformDistributedTopic Delivery Failure Parameters, `redelivery-limit` and `expiration-policy`. The JMX test client verifies the serverConfig MBean tree for the expected delivery failure parameters, `redelivery-limit` and `expiration-policy`. |
9898
| WLDF Resource Override | Override `wldf-instrumentation-monitor` and `harvester` in a diagnostics module. The test client verifies the new instrumentation monitors/harvesters set by getting the WLDF resource from serverConfig tree with expected values. |

integration-tests/src/test/java/oracle/kubernetes/operator/ITSitConfig.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ public static void staticUnPrepare() throws Exception {
112112
}
113113

114114
/**
115-
* This test covers custom configuration override use cases for config.xml.
115+
* This test covers custom configuration override use cases for config.xml for administration
116+
* server.
116117
*
117118
* <p>The test checks the overridden config.xml attributes connect-timeout, max-message-size,
118119
* restart-max, JMXCore and ServerLifeCycle debug flags, the T3Channel public address. The
@@ -143,12 +144,11 @@ public void testCustomSitConfigOverridesForDomain() throws Exception {
143144
}
144145

145146
/**
146-
* This test covers custom configuration override use cases for config.xml.
147+
* This test covers custom configuration override use cases for config.xml for managed server.
147148
*
148-
* <p>The test checks the overridden config.xml attributes connect-timeout, max-message-size,
149-
* restart-max, JMXCore and ServerLifeCycle debug flags, the T3Channel public address. The
150-
* overridden are verified against the ServerConfig MBean tree. It does not verifies whether the
151-
* overridden values are applied to the runtime.
149+
* <p>The test checks the overridden config.xml attributes max-message-size. The overridden are
150+
* verified against the ServerConfig MBean tree. It does not verifies whether the overridden
151+
* values are applied to the runtime.
152152
*
153153
* @throws Exception when the assertion fails due to unmatched values
154154
*/

integration-tests/src/test/resources/sitconfig/java/SitConfigTests.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,13 @@ protected WLDFSystemResourceMBean getWLDFSystemModule(String resourceName) {
582582
return wldfResource;
583583
}
584584

585+
/**
586+
* Looks up the managed server public listen address and port, closes the existing MBeanServer
587+
* connection to admin server and creates MBeanServer connection to the given managed server
588+
*
589+
* @param serverName name of the managed server to which to create MBeanServerConnection
590+
* @throws Exception when connection close fails or when new connection to managed server fails.
591+
*/
585592
private void connectToManagedServer(String serverName) throws Exception {
586593
ServerMBean[] servers = runtimeServiceMBean.getDomainConfiguration().getServers();
587594
try {

0 commit comments

Comments
 (0)