Skip to content

Commit 0d6fc55

Browse files
committed
Improved implementation, as suggested by tbarnes
1 parent 3f1b75d commit 0d6fc55

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

operator/src/main/java/oracle/kubernetes/operator/helpers/KubernetesUtils.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,10 @@ public static boolean isFirstNewer(V1ObjectMeta first, V1ObjectMeta second) {
119119
DateTime time1 = first.getCreationTimestamp();
120120
DateTime time2 = second.getCreationTimestamp();
121121

122-
if (time1.isAfter(time2)) {
123-
return true;
124-
} else if (time2.isAfter(time1)) {
125-
return false;
126-
} else {
122+
if (time1.equals(time2)) {
127123
return getResourceVersion(first) > getResourceVersion(second);
124+
} else {
125+
return time1.isAfter(time2);
128126
}
129127
}
130128

0 commit comments

Comments
 (0)