Skip to content

Commit 115841b

Browse files
authored
Merge pull request #247 from oracle/feature-version-fix
Fix a bug where we were checking against the wrong version string whe…
2 parents 8a43055 + 761623e commit 115841b

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

operator/src/main/java/oracle/kubernetes/operator/helpers/ConfigMapHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public NextAction onSuccess(Packet packet, V1ConfigMap result, int statusCode,
9999
}
100100
});
101101
return doNext(create, packet);
102-
} else if (VersionHelper.matchesResourceVersion(result.getMetadata(), LabelConstants.RESOURCE_VERSION_LABEL) &&
102+
} else if (VersionHelper.matchesResourceVersion(result.getMetadata(), VersionConstants.DOMAIN_V1) &&
103103
result.getData().entrySet().containsAll(cm.getData().entrySet())) {
104104
// existing config map has correct data
105105
LOGGER.fine(MessageKeys.CM_EXISTS, domainNamespace);

operator/src/main/java/oracle/kubernetes/operator/helpers/PodHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ private static boolean validateCurrentPod(V1Pod build, V1Pod current) {
407407
// returns fields, such as nodeName, even when export=true is specified.
408408
// Therefore, we'll just compare specific fields
409409

410-
if (!VersionHelper.matchesResourceVersion(current.getMetadata(), LabelConstants.RESOURCE_VERSION_LABEL)) {
410+
if (!VersionHelper.matchesResourceVersion(current.getMetadata(), VersionConstants.DOMAIN_V1)) {
411411
return false;
412412
}
413413

operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ private static boolean validateCurrentService(V1Service build, V1Service current
368368
V1ServiceSpec buildSpec = build.getSpec();
369369
V1ServiceSpec currentSpec = current.getSpec();
370370

371-
if (!VersionHelper.matchesResourceVersion(current.getMetadata(), LabelConstants.RESOURCE_VERSION_LABEL)) {
371+
if (!VersionHelper.matchesResourceVersion(current.getMetadata(), VersionConstants.DOMAIN_V1)) {
372372
return false;
373373
}
374374

0 commit comments

Comments
 (0)