Skip to content

Commit 127b25e

Browse files
committed
improved javadoc
1 parent f9f751b commit 127b25e

File tree

1 file changed

+24
-15
lines changed
  • integration-tests/src/test/java/oracle/kubernetes/operator/utils

1 file changed

+24
-15
lines changed

integration-tests/src/test/java/oracle/kubernetes/operator/utils/Domain.java

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1315,9 +1315,11 @@ private String getNodePort() throws Exception {
13151315
}
13161316

13171317
/**
1318-
* clone docker-images sample
1318+
* Remove docker-images sample directory if exists and clone latest from github for domain home in
1319+
* image.
13191320
*
1320-
* @throws Exception
1321+
* @throws Exception if could not run the command successfully to clone of docker-images sample
1322+
* from github
13211323
*/
13221324
private void gitCloneDockerImagesSample() throws Exception {
13231325
if (!domainHomeImageBuildPath.isEmpty()) {
@@ -1339,14 +1341,16 @@ private void gitCloneDockerImagesSample() throws Exception {
13391341
.append(BaseTest.getResultDir())
13401342
.append("/docker-images");
13411343
logger.info("Executing cmd " + removeAndClone);
1342-
ExecResult result = TestUtils.exec(removeAndClone.toString());
1344+
TestUtils.exec(removeAndClone.toString());
13431345
}
13441346
}
13451347

13461348
/**
1347-
* append configOverrides to domain.yaml
1349+
* append configOverrides and configOverrideSecrets section to the generated domain.yaml and
1350+
* create the domain crd by calling kubectl create on the generated domain.yaml
13481351
*
1349-
* @throws Exception
1352+
* @throws Exception if any error occurs writing to the file or if could not run kubectl create
1353+
* command
13501354
*/
13511355
private void appendToDomainYamlAndCreate() throws Exception {
13521356
String contentToAppend =
@@ -1391,9 +1395,10 @@ public String getHostNameForCurl() throws Exception {
13911395
}
13921396

13931397
/**
1394-
* copy create-domain.py domain map contains createDomainPyScript
1398+
* Option to provide custom create-domain.py script. Copies create-domain.py to the correct
1399+
* location if domain map contains createDomainPyScript attribute.
13951400
*
1396-
* @throws IOException
1401+
* @throws IOException if error occurs when readin or writing the file
13971402
*/
13981403
private void copyCreateDomainPy() throws IOException {
13991404

@@ -1425,11 +1430,11 @@ private void copyCreateDomainPy() throws IOException {
14251430
/**
14261431
* prepare the command to call create-domain.sh based on the domain type
14271432
*
1428-
* @param outputDir
1429-
* @return
1430-
* @throws Exception
1433+
* @param outputDir directory for the generated Kubernetes YAML files for the domain when
1434+
* create-domain.sh is called
1435+
* @return the command
14311436
*/
1432-
private String prepareCmdToCallCreateDomainScript(String outputDir) throws Exception {
1437+
private String prepareCmdToCallCreateDomainScript(String outputDir) {
14331438

14341439
StringBuffer createDomainScriptCmd = new StringBuffer(BaseTest.getResultDir());
14351440
// call different create-domain.sh based on the domain type
@@ -1458,9 +1463,11 @@ private String prepareCmdToCallCreateDomainScript(String outputDir) throws Excep
14581463
}
14591464

14601465
/**
1461-
* change cluster type in domain template or properties to CONFIGURED for configured cluster
1466+
* Option to provide cluster type. Change cluster type in domain template to CONFIGURED or use
1467+
* configured cluster topology if clusterType is CONFIGURED
14621468
*
1463-
* @throws Exception
1469+
* @throws Exception when errors occured during reading/writing the file or executing the command
1470+
* to change the value in create-domain-job-template.yaml
14641471
*/
14651472
private void changeClusterTypeInCreateDomainJobTemplate() throws Exception {
14661473

@@ -1627,9 +1634,11 @@ private void callShellScriptToBuildDeployAppInPod(
16271634
}
16281635

16291636
/**
1630-
* create config map and secret for custom situational configuration
1637+
* create config map and label with domainUid and create secret used in custom situational
1638+
* configuration which contains hostname, db user, db password
16311639
*
1632-
* @throws Exception
1640+
* @throws Exception when any of the kubectl commands to create config map, label, secret fails or
1641+
* if could not run them
16331642
*/
16341643
private void createConfigMapAndSecretForSitConfig() throws Exception {
16351644

0 commit comments

Comments
 (0)