Skip to content

Commit 16d53f5

Browse files
doxiaorjeberhard
authored andcommitted
More review comments
Signed-off-by: doxiao <[email protected]>
1 parent 7aa4b18 commit 16d53f5

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ The following parameters can be provided in the inputs file.
115115
| `initialManagedServerReplicas` | Number of Managed Servers to initially start for the domain. | `2` |
116116
| `javaOptions` | Java options for starting the Administration and Managed Servers. A Java option can have references to one or more of the following pre-defined variables to obtain WebLogic domain information: `$(DOMAIN_NAME)`, `$(DOMAIN_HOME)`, `$(ADMIN_NAME)`, `$(ADMIN_PORT)`, and `$(SERVER_NAME)`. | `-Dweblogic.StdoutDebugEnabled=false` |
117117
| `logHomeOnPV` | Specifies whether the log home is stored on the persistent volume. If set to true, then you must specify the `logHome`, `persistentVolumeClaimName` and `domainPVMountPath` parameters.| `false` |
118-
| `logHome` | The in-pod name of the directory in which to store the domain, Node Manager, server logs, and server .out files. If not specified, the value is derived from the `domainUID` as `/shared/logs/<domainUID>`. This parameter is required if `logHomeOnPV` is true. Otherwise, it is ignored. | `/shared/logs/domain1` |
118+
| `logHome` | The in-pod location for domain log, server logs, server out, and node manager log files. If not specified, the value is derived from the `domainUID` as `/shared/logs/<domainUID>`. This parameter is required if `logHomeOnPV` is true. Otherwise, it is ignored. | `/shared/logs/domain1` |
119119
| `managedServerNameBase` | Base string used to generate Managed Server names. | `managed-server` |
120120
| `managedServerPort` | Port number for each Managed Server. | `8001` |
121121
| `namespace` | Kubernetes namespace in which to create the domain. | `default` |
@@ -175,8 +175,7 @@ spec:
175175
includeServerOutInPodLog: true
176176
# Whether to enable log home
177177
# logHomeEnabled: false
178-
# The in-pod name of the directory in which to store the domain, node manager, server logs, and server .out
179-
# files.
178+
# The in-pod location for domain log, server logs, server out, and node manager log files
180179
# If not specified or empty, domain log file, server logs, server out, and node manager log files
181180
# will be stored in the default logHome location of /shared/logs/<domainUID>/.
182181
# logHome: /shared/logs/domain1

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/create-domain-inputs.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ includeServerOutInPodLog: true
7474
# The default is false.
7575
logHomeOnPV: false
7676

77-
# The in-pod name of the directory in which to store the domain, node manager, server logs,
78-
# and server .out files.
77+
# The in-pod location for domain log, server logs, server out, and node manager log files
7978
# If not specified, the value is derived from the domainUID as /shared/logs/<domainUID>
8079
# This parameter is required if 'logHomeOnPV' is true.
8180
# Otherwise, it is ignored.

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ The following parameters can be provided in the inputs file.
8888
| `includeServerOutInPodLog` | Boolean indicating whether to include server .out to the pod's stdout. | `true` |
8989
| `initialManagedServerReplicas` | Number of Managed Servers to initially start for the domain. | `2` |
9090
| `javaOptions` | Java options for starting the Administration and Managed Servers. A Java option can have references to one or more of the following pre-defined variables to obtain WebLogic domain information: `$(DOMAIN_NAME)`, `$(DOMAIN_HOME)`, `$(ADMIN_NAME)`, `$(ADMIN_PORT)`, and `$(SERVER_NAME)`. | `-Dweblogic.StdoutDebugEnabled=false` |
91-
| `logHome` | The in-pod name of the directory in which to store the domain, node manager, server logs, and server .out files. If not specified, the value is derived from the `domainUID` as `/shared/logs/<domainUID>`. | `/shared/logs/domain1` |
91+
| `logHome` | The in-pod location for domain log, server logs, server out, and node manager log files. If not specified, the value is derived from the `domainUID` as `/shared/logs/<domainUID>`. | `/shared/logs/domain1` |
9292
| `managedServerNameBase` | Base string used to generate Managed Server names. | `managed-server` |
9393
| `managedServerPort` | Port number for each Managed Server. | `8001` |
9494
| `namespace` | Kubernetes namespace in which to create the domain. | `default` |
@@ -148,8 +148,7 @@ spec:
148148
includeServerOutInPodLog: true
149149
# Whether to enable log home
150150
logHomeEnabled: true
151-
# The in-pod name of the directory in which to store the domain, node manager, server logs, and server .out
152-
# files.
151+
# The in-pod name location for domain log, server logs, server out, and node manager log files
153152
# If not specified or empty, domain log file, server logs, server out, and node manager log files
154153
# will be stored in the default logHome location of /shared/logs/<domainUID>/.
155154
logHome: /shared/logs/domain1

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/create-domain-inputs.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ weblogicCredentialsSecretName: domain1-weblogic-credentials
6161
# The default is true.
6262
includeServerOutInPodLog: true
6363

64-
# The in-pod name of the directory in which to store the domain, node manager, server logs, and server .out
65-
# files.
64+
# The in-pod location for domain log, server logs, server out, and node manager log files
6665
# If not specified, the value is derived from the domainUID as /shared/logs/<domainUID>
6766
logHome: /shared/logs/domain1
6867

0 commit comments

Comments
 (0)