Skip to content

Commit 1c98317

Browse files
committed
Refinements based on review comments
Signed-off-by: doxiao <[email protected]>
1 parent 97d518e commit 1c98317

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ The script will perform the following steps:
3030
* Clone the weblogic docker-images project into the current directory using `git clone https://github.com/oracle/docker-images.git`.
3131
* Replace the built-in user name and password in the `properties/docker-build/domain_security.properties` file with the `username` and `password` that are supplied on the command line using the `-u` and `-p` options. These credentials need to match the WebLogic domain admin credentials in the secret that is specified via the `weblogicCredentialsSecretName` property in the `create-domain-inputs.yaml` file.
3232
* Build a Docker image based on the Docker sample, [Example Image with a WebLogic Server Domain using the Oracle WebLogic Deploy Tooling (WDT)](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image-wdt) and [Example Image with a WebLogic Server Domain using WLST](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image). It will create a sample WebLogic Server domain in the Docker image. Also, you can run the Docker sample, [Example Image with a WebLogic Server Domain](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image), manually with the generated `domain.properties` to create a domain home image. **Note**: Oracle recommends keeping the domain home image private in the local repository.
33+
* Create a tag that refers to the generated Docker image.
3334
* Create a Kubernetes domain YAML file, `domain.yaml`, in the directory that is created above. This YAML file can be used to create the Kubernetes resource using the `kubectl create -f` or `kubectl apply -f` command.
3435
```
3536
$ kubectl apply -f /path/to/output-directory/weblogic-domains/<domainUID>/domain.yaml
@@ -65,10 +66,10 @@ The default domain created by the script has the following characteristics:
6566
* No applications deployed.
6667
* A T3 channel.
6768

68-
If you run the sample from a machine that is remote to the Kubernetes cluster, and you need to push the new image to a registry that is local to the cluster, you need to do the following:
69-
* Set the `image` property in the inputs file to the target image name (including the tag if needed).
69+
If you run the sample from a machine that is remote to the Kubernetes cluster, and you need to push the new image to a registry that is local to the cluster, you need to do the following (also see the `image` property in the table in the next section):
70+
* Set the `image` property in the inputs file to the target image name (including the registry hostname/port and the tag if needed).
7071
* Run the `create-domain.sh` script without the `-e` option.
71-
* Push the generated image `domain-home-in-image-wdt:lastest` (or `domain-home-in-image:latest`) to the registry.
72+
* Push the `image` to the target registry.
7273
* Run the following command to create the domain.
7374

7475
```
@@ -93,7 +94,7 @@ The following parameters can be provided in the inputs file.
9394
| `domainUID` | Unique ID that will be used to identify this particular domain. Used as the name of the generated WebLogic domain as well as the name of the Kubernetes domain resource. This ID must be unique across all domains in a Kubernetes cluster. This ID cannot contain any character that is not valid in a Kubernetes service name. | `domain1` |
9495
| `exposeAdminNodePort` | Boolean indicating if the Administration Server is exposed outside of the Kubernetes cluster. | `false` |
9596
| `exposeAdminT3Channel` | Boolean indicating if the T3 administrative channel is exposed outside the Kubernetes cluster. | `false` |
96-
| `image` | WebLogic Docker image that the domain resource will pull if needed. You only need to specify this if you are going to tag the generated image to a different name. If not specified, the sample uses the internally generated image name, either "domain-home-in-image-wdt:latest" or "domain-home-in-image:latest". | |
97+
| `image` | WebLogic Docker image that the domain resource will pull if needed. You only need to specify this if you are going to tag the generated image to a different name. If you run the sample script from a machine that is remote to the Kubernetes cluster, you need to specify this to point to an image in a registry local to the cluster, and then push the generate image to that registry before starting the domain. If not specified, the sample uses the internally generated image name, either "domain-home-in-image:latest" or "domain-home-in-image-wdt:latest". | |
9798
| `imagePullPolicy` | WebLogic Docker image pull policy. Legal values are "IfNotPresent", "Always", or "Never" | `IfNotPresent` |
9899
| `imagePullSecretName` | Name of the Kubernetes secret to access the Docker Store to pull the WebLogic Server Docker image. The presence of the secret will be validated when this parameter is specified | |
99100
| `includeServerOutInPodLog` | Boolean indicating whether to include server .out to the pod's stdout. | `true` |

site/quickstart.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,9 @@ Kubernetes YAML files *and* apply them to your cluster. If you omit the `-e` op
178178
script will just generate the YAML files, but will not take any action on your cluster.
179179

180180
If you run the sample from a machine that is remote to the Kubernetes cluster, and you need to push the new image to a registry that is local to the cluster, you need to do the following:
181-
* Set the `image` property in the inputs file to the target image name (including the tag if needed).
181+
* Set the `image` property in the inputs file to the target image name (including the registry hostname/port, and the tag if needed).
182182
* Run the `create-domain.sh` script without the `-e` option.
183-
* Push the generated image `domain-home-in-image-wdt:lastest` (or `domain-home-in-image:latest`) to the registry.
183+
* Push the `image` to the registry.
184184
* Run the following command to create the domain.
185185

186186
```

0 commit comments

Comments
 (0)