Skip to content

Commit 21f9663

Browse files
committed
Leave clusterIP blank for NodePort
1 parent 6bd467e commit 21f9663

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@ protected V1ServiceSpec createServiceSpec() {
9797
if (isPublishNotReadyAddressesSupported()) {
9898
serviceSpec.setPublishNotReadyAddresses(Boolean.TRUE);
9999
}
100-
serviceSpec.clusterIP("None");
100+
if (nodePort == null) {
101+
serviceSpec.clusterIP("None");
102+
}
101103
return serviceSpec;
102104
}
103105

operator/src/test/java/oracle/kubernetes/operator/helpers/ServiceHelperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -442,7 +442,7 @@ public void whenNodePortSpecified_createServerServiceWithNodePort() {
442442
}
443443

444444
private V1Service withNodePort(V1Service service, int nodePort) {
445-
service.getSpec().setType("NodePort");
445+
service.getSpec().type("NodePort").clusterIP(null);
446446
service
447447
.getSpec()
448448
.getPorts()

0 commit comments

Comments
 (0)